Opened 5 years ago

Last modified 5 years ago

#21995 closed defect

Fix comparison operators of PoorManMap — at Version 2

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-7.5
Component: categories Keywords:
Cc: Merged in:
Authors: Julian Rüth Reviewers:
Report Upstream: N/A Work issues:
Branch: u/saraedum/fix_comparison_operators_of_poormanmap (Commits, GitHub, GitLab) Commit: 0d0f55d089dd299bfd36b6b441f142e2fbdd8fd8
Dependencies: Stopgaps:

Status badges

Description (last modified by saraedum)

PoorManMap? currently only implements __eq__ but not __hash__ nor __neq__.

This ticket implements _richcmp_ and __hash__ instead of __eq__ and makes _richcmp_ not rely on comparison of __dict__ which does not work anymore when introducing @cached_methods in PoorManMap?, see #21894.

Change History (2)

comment:1 Changed 5 years ago by saraedum

  • Branch set to u/saraedum/fix_comparison_operators_of_poormanmap

comment:2 Changed 5 years ago by saraedum

  • Commit set to 0d0f55d089dd299bfd36b6b441f142e2fbdd8fd8
  • Description modified (diff)

New commits:

0d0f55dImplement _richcmp_ and __hash__ for PoorManMap
Note: See TracTickets for help on using tickets.