Opened 3 years ago

Closed 3 years ago

#21971 closed enhancement (fixed)

py3 a few cmp removed in crypto, dynamics (py files)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.5
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2829a7f (Commits) Commit: 2829a7ff1f05fe288cf1d4697b3df50c77730e21
Dependencies: Stopgaps:

Description

as a very minor step to py3

Change History (11)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/21971
  • Commit set to 242b93b81ca0372e9005149167027571c83a2d14

New commits:

242b93bconvert a few cmp to richcmp in crypto, dynamics, finance

comment:2 Changed 3 years ago by chapoton

  • Summary changed from py3 a few cmp removed in crypto, finance, dynamics to py3 a few cmp removed in crypto, finance, dynamics (py files)

comment:3 Changed 3 years ago by git

  • Commit changed from 242b93b81ca0372e9005149167027571c83a2d14 to b48b6d5e604ce139dffe6c51fb56c217a165af9a

Branch pushed to git repo; I updated commit sha1. New commits:

4bf45ecMerge branch 'u/chapoton/21971' in 7.5.b5
b48b6d5trac 21971 a solution for cmp in flat_surfaces/strata

comment:4 Changed 3 years ago by git

  • Commit changed from b48b6d5e604ce139dffe6c51fb56c217a165af9a to c2c08dbaff3b25cc01a2fd907dfdba9838e24023

Branch pushed to git repo; I updated commit sha1. New commits:

c2c08db21971 another fix by stepping back to __cmp__

comment:5 Changed 3 years ago by git

  • Commit changed from c2c08dbaff3b25cc01a2fd907dfdba9838e24023 to 314a0e88aaf50a45c855f227504b9b4180ef23e4

Branch pushed to git repo; I updated commit sha1. New commits:

314a0e8trac 21971 one typo, still not working

comment:6 Changed 3 years ago by git

  • Commit changed from 314a0e88aaf50a45c855f227504b9b4180ef23e4 to 2829a7ff1f05fe288cf1d4697b3df50c77730e21

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2829a7fconvert a few cmp to richcmp in crypto, dynamics, finance

comment:7 Changed 3 years ago by chapoton

  • Cc tscrim jdemeyer aapitzsch added
  • Status changed from new to needs_review
  • Summary changed from py3 a few cmp removed in crypto, finance, dynamics (py files) to py3 a few cmp removed in crypto, dynamics (py files)

comment:8 Changed 3 years ago by chapoton

*ping*

comment:9 Changed 3 years ago by chapoton

*ping*

this should be an easy review..

comment:10 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

This will work for now as a __cmp__ between different parents does not make sense.

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/21971 to 2829a7ff1f05fe288cf1d4697b3df50c77730e21
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.