Opened 4 years ago

Closed 4 years ago

#21962 closed defect (fixed)

Don't import max from builtins

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.5
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4aceb7b (Commits, GitHub, GitLab) Commit: 4aceb7b762a8640b05dad1e502ce36c5808e767f
Dependencies: Stopgaps:

Status badges

Description

In src/sage/quadratic_forms/ternary.pyx, there is no reason at all for

from six.moves.builtins import max

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/don_t_import_max_from_builtins

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 4aceb7b762a8640b05dad1e502ce36c5808e767f
  • Status changed from new to needs_review

New commits:

4aceb7bDon't import max from builtins

comment:3 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/don_t_import_max_from_builtins to 4aceb7b762a8640b05dad1e502ce36c5808e767f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.