#21938 closed defect (fixed)
Problem in the documentation of block design
Reported by:  boussica  Owned by:  boussica 

Priority:  major  Milestone:  sage7.5 
Component:  documentation  Keywords:  days79 
Cc:  nthiery  Merged in:  
Authors:  Adrien Boussicault  Reviewers:  Nicolas M. Thiéry 
Report Upstream:  N/A  Work issues:  
Branch:  ec44606 (Commits)  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
In the function AffineGeometryDesign
in the file sage/combinat/designs/block_design.py
the finite fields do not appear correctly (problem of the indices q and paranthesis).
Change History (20)
comment:1 Changed 4 years ago by
 Keywords days79 added
comment:2 Changed 4 years ago by
comment:3 Changed 4 years ago by
 Description modified (diff)
 Summary changed from Problem in the documentation to Problem in the documentation of block design
comment:4 Changed 4 years ago by
comment:5 Changed 4 years ago by
 Description modified (diff)
comment:6 Changed 4 years ago by
 Description modified (diff)
 Owner changed from (none) to boussica
Ok , i confirm the bug on 0c6824fff559e93b5517e53cd90ac1f1b04accf9
comment:7 Changed 4 years ago by
 Branch set to u/boussica/problem_in_the_documentation_of_block_design
comment:8 Changed 4 years ago by
 Commit set to ec44606ca6ed6de86dc90078ebdc4bddd20de2f6
 Status changed from new to needs_review
New commits:
ec44606  Trac 21938: Correct doc of AffineGeometryDesign

comment:9 Changed 4 years ago by
 Cc nthiery added
comment:10 Changed 4 years ago by
 Reviewers set to Nicolas M. Thiéry
comment:11 Changed 4 years ago by
Hi Adrien,
Thanks for fixing this.
There is another occurence of the same issue just below. Do you mind fixing it as well?
Cheers,
comment:12 Changed 4 years ago by
Ok, just got Adrien over the phone; fixing it myself.
comment:13 Changed 4 years ago by
 Status changed from needs_review to needs_work
comment:14 Changed 4 years ago by
 Branch changed from u/boussica/problem_in_the_documentation_of_block_design to u/nthiery/problem_in_the_documentation_of_block_design
comment:15 Changed 4 years ago by
 Branch changed from u/nthiery/problem_in_the_documentation_of_block_design to u/boussica/problem_in_the_documentation_of_block_design
I checked the HTML output, and it looks good. I also fixed the other occurence. Please Adrien, look back at my changes; if you are happy with them, you can set the ticket to positive review.
comment:16 Changed 4 years ago by
Just got Adrien over the "phone", he is happy with my change. Positive review.
comment:17 Changed 4 years ago by
 Status changed from needs_work to positive_review
comment:18 Changed 4 years ago by
Good job, thank you!
comment:19 Changed 4 years ago by
 Branch changed from u/boussica/problem_in_the_documentation_of_block_design to ec44606ca6ed6de86dc90078ebdc4bddd20de2f6
 Resolution set to fixed
 Status changed from positive_review to closed
comment:20 Changed 4 years ago by
 Commit ec44606ca6ed6de86dc90078ebdc4bddd20de2f6 deleted
missing capital in name
Hello Vincent,
Please, I need more details ! Can you give me the source code were the problem is present. Your version of sage.