#21937 closed enhancement (fixed)
Library of polytopes should allow specifying backend=...
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | geometry | Keywords: | days93, polytope |
Cc: | vdelecroix, chapoton, dimpase, vbarun, Winfried, jipilab, moritz | Merged in: | |
Authors: | Jean-Philippe Labbé | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 5532e21 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description
In #20885, we are working on a new Polyhedron
backend class, Polyhedron_normaliz
Unfortunately all of the examples in sage.geometry.polyhedron.library
(such as polytopes.cross_polytope
) do not allow passing a backend
parameter, so we can't use them for testing.
Change History (10)
comment:1 Changed 5 years ago by
- Cc jipilab added
comment:2 Changed 5 years ago by
- Cc moritz added
comment:3 Changed 4 years ago by
- Branch set to u/jipilab/21937
- Commit set to 7f299c2bd7a2f87ee4984452866454587282f76c
- Status changed from new to needs_review
comment:4 Changed 4 years ago by
- Commit changed from 7f299c2bd7a2f87ee4984452866454587282f76c to 5532e2143b57b9453ae4df1cbca11125dec79671
Branch pushed to git repo; I updated commit sha1. New commits:
5532e21 | pep8
|
comment:5 Changed 4 years ago by
- Milestone changed from sage-7.5 to sage-8.2
New commits:
5532e21 | pep8
|
comment:6 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:7 Changed 4 years ago by
- Keywords days93 polytope added
comment:8 Changed 4 years ago by
Thanks Travis!
comment:9 Changed 4 years ago by
- Branch changed from u/jipilab/21937 to 5532e2143b57b9453ae4df1cbca11125dec79671
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 4 years ago by
- Commit 5532e2143b57b9453ae4df1cbca11125dec79671 deleted
Follow-up: #26365
Note: See
TracTickets for help on using
tickets.
Here's a first version. I already added tests on the examples where normaliz can do tests right away.
New commits:
First version, added backend argument