Opened 6 years ago

Last modified 6 years ago

#21929 closed task

Make "tightpage=True" the default behavior for view — at Version 15

Reported by: Moritz Firsching Owned by:
Priority: minor Milestone: sage-7.5
Component: misc Keywords: days79, beginner, latex
Cc: Jean-Philippe Labbé, Nicolas M. Thiéry Merged in:
Authors: Moritz Firsching Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: u/moritz/ticket/21929 (Commits, GitHub, GitLab) Commit: 397cd789434ca1ae6430ca0e652d1cba72e725bf
Dependencies: Stopgaps:

Status badges

Description (last modified by Nicolas M. Thiéry)

The original implementation of view, produces a pdf in a4 format, regardless of the typeset object. #6591 introduced the tightpage option which produces a document whose size matches the typeset object.

Since then, the tightpage=True option has grown popular; in fact most of the time, this is the desirable choice. Therefore this ticket makes tightpage=True the default.

Change History (15)

comment:1 Changed 6 years ago by Moritz Firsching

Branch: u/moritz/ticket/21929
Commit: 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e2

New commits:

7f932caFixing ticket 21929

comment:2 Changed 6 years ago by git

Commit: 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e215d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9

Branch pushed to git repo; I updated commit sha1. New commits:

15d6d2fChanged documentation to indicate the new default behavior

comment:3 Changed 6 years ago by Moritz Firsching

I would like to remove the many occurrences of tightpage=True in various files to reflect the new defaults.

comment:4 Changed 6 years ago by git

Commit: 15d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9800b0510e08381368e649b53ade1af09f89fb9fd

Branch pushed to git repo; I updated commit sha1. New commits:

800b051removed occurances of 'tightpage=true'

comment:5 Changed 6 years ago by Moritz Firsching

Authors: moritz
Status: newneeds_review

comment:6 Changed 6 years ago by Jean-Philippe Labbé

Hi Moritz,

Did you make a circular search do look for all instances of "tightpage=(T)true"?

comment:7 Changed 6 years ago by Jean-Philippe Labbé

Authors: moritzMoritz Firsching
Cc: Jean-Philippe Labbé added
Reviewers: Jean-Philippe Labbé

comment:8 Changed 6 years ago by Jean-Philippe Labbé

Status: needs_reviewneeds_work

Hi Moritz,

Could you also adapt the text in the documentation of view concerning the option "tightpage" so that it makes sense with the updated default value. For example, say what it does when it is set to "False".

comment:9 Changed 6 years ago by Jean-Philippe Labbé

All test passed on Sage7.5.b3.

comment:10 Changed 6 years ago by git

Commit: 800b0510e08381368e649b53ade1af09f89fb9fdbf273fa6d434bc6ceab51165d233c55cab0ecd7a

Branch pushed to git repo; I updated commit sha1. New commits:

bf273famore improvements in the documentation

comment:11 Changed 6 years ago by Moritz Firsching

Status: needs_workneeds_review

I searched for all instances of tightpage=True and hopefully didn't miss any.

The last commit addresses the changes in the documentation you suggest.


New commits:

bf273famore improvements in the documentation

comment:12 Changed 6 years ago by Jean-Philippe Labbé

Cc: Nicolas M. Thiéry added

Great! All test passed.

I would like to have a second opinion. Nicolas, anything to say about the patch?

This looks good for a positive review on my part.

comment:13 Changed 6 years ago by git

Commit: bf273fa6d434bc6ceab51165d233c55cab0ecd7a397cd789434ca1ae6430ca0e652d1cba72e725bf

Branch pushed to git repo; I updated commit sha1. New commits:

397cd78fixed one more occurance

comment:14 Changed 6 years ago by Jean-Philippe Labbé

Dear Moritz,

I did a pep8 check on latex.py. Could you remove the "blanklines containing whitespaces" and "trailing whitespaces" in line 2101 and 2103, 2118 of latex.py.

JP

comment:15 Changed 6 years ago by Nicolas M. Thiéry

Description: modified (diff)
Summary: make "tightpage" the default behavior for viewMake "tightpage=True" the default behavior for view
Note: See TracTickets for help on using tickets.