Opened 6 years ago
Closed 6 years ago
#21929 closed task (fixed)
Make "tightpage=True" the default behavior for view
Reported by: | moritz | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.5 |
Component: | misc | Keywords: | days79, beginner, latex |
Cc: | jipilab, nthiery | Merged in: | |
Authors: | Moritz Firsching | Reviewers: | Jean-Philippe Labbé |
Report Upstream: | N/A | Work issues: | |
Branch: | 1bf4697 (Commits, GitHub, GitLab) | Commit: | 1bf46974281079b09f3a08abb934b04547c629a8 |
Dependencies: | Stopgaps: |
Description (last modified by )
The original implementation of view
, produces a pdf in a4 format,
regardless of the typeset object. #6591 introduced the tightpage
option which produces a document whose size matches the typeset
object.
Since then, the tightpage=True
option has grown popular; in fact
most of the time, this is the desirable choice. Therefore this ticket
makes tightpage=True
the default.
Note: in some cases, the current implementation of tightpage crops the border of the picture. This will be fixed in a separate ticket to make tightpage even more appealing.
Change History (20)
comment:1 Changed 6 years ago by
- Branch set to u/moritz/ticket/21929
- Commit set to 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e2
comment:2 Changed 6 years ago by
- Commit changed from 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e2 to 15d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9
Branch pushed to git repo; I updated commit sha1. New commits:
15d6d2f | Changed documentation to indicate the new default behavior
|
comment:3 Changed 6 years ago by
I would like to remove the many occurrences of tightpage=True
in various files to reflect the new defaults.
comment:4 Changed 6 years ago by
- Commit changed from 15d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9 to 800b0510e08381368e649b53ade1af09f89fb9fd
Branch pushed to git repo; I updated commit sha1. New commits:
800b051 | removed occurances of 'tightpage=true'
|
comment:5 Changed 6 years ago by
- Status changed from new to needs_review
comment:6 Changed 6 years ago by
Hi Moritz,
Did you make a circular search do look for all instances of "tightpage=(T)true"?
comment:7 Changed 6 years ago by
- Cc jipilab added
- Reviewers set to Jean-Philippe Labbé
comment:8 Changed 6 years ago by
- Status changed from needs_review to needs_work
Hi Moritz,
Could you also adapt the text in the documentation of view concerning the option "tightpage" so that it makes sense with the updated default value. For example, say what it does when it is set to "False".
comment:9 Changed 6 years ago by
All test passed on Sage7.5.b3.
comment:10 Changed 6 years ago by
- Commit changed from 800b0510e08381368e649b53ade1af09f89fb9fd to bf273fa6d434bc6ceab51165d233c55cab0ecd7a
Branch pushed to git repo; I updated commit sha1. New commits:
bf273fa | more improvements in the documentation
|
comment:11 Changed 6 years ago by
- Status changed from needs_work to needs_review
I searched for all instances of tightpage=True
and hopefully didn't miss any.
The last commit addresses the changes in the documentation you suggest.
New commits:
bf273fa | more improvements in the documentation
|
comment:12 Changed 6 years ago by
- Cc nthiery added
Great! All test passed.
I would like to have a second opinion. Nicolas, anything to say about the patch?
This looks good for a positive review on my part.
comment:13 Changed 6 years ago by
- Commit changed from bf273fa6d434bc6ceab51165d233c55cab0ecd7a to 397cd789434ca1ae6430ca0e652d1cba72e725bf
Branch pushed to git repo; I updated commit sha1. New commits:
397cd78 | fixed one more occurance
|
comment:14 Changed 6 years ago by
Dear Moritz,
I did a pep8 check on latex.py. Could you remove the "blanklines containing whitespaces" and "trailing whitespaces" in line 2101 and 2103, 2118 of latex.py.
JP
comment:15 Changed 6 years ago by
- Description modified (diff)
- Summary changed from make "tightpage" the default behavior for view to Make "tightpage=True" the default behavior for view
comment:16 Changed 6 years ago by
- Description modified (diff)
comment:17 Changed 6 years ago by
For the record: we made a quick poll here at Sage Days 79, and everybody who cared voted to make tightpage=True
the default.
comment:18 Changed 6 years ago by
- Commit changed from 397cd789434ca1ae6430ca0e652d1cba72e725bf to 1bf46974281079b09f3a08abb934b04547c629a8
Branch pushed to git repo; I updated commit sha1. New commits:
1bf4697 | removed some whitespace
|
comment:19 Changed 6 years ago by
- Status changed from needs_review to positive_review
Looks ok to me now. I'm setting it to positive review.
comment:20 Changed 6 years ago by
- Branch changed from u/moritz/ticket/21929 to 1bf46974281079b09f3a08abb934b04547c629a8
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Fixing ticket 21929