Opened 5 years ago

Closed 5 years ago

#21929 closed task (fixed)

Make "tightpage=True" the default behavior for view

Reported by: moritz Owned by:
Priority: minor Milestone: sage-7.5
Component: misc Keywords: days79, beginner, latex
Cc: jipilab, nthiery Merged in:
Authors: Moritz Firsching Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 1bf4697 (Commits, GitHub, GitLab) Commit: 1bf46974281079b09f3a08abb934b04547c629a8
Dependencies: Stopgaps:

Status badges

Description (last modified by nthiery)

The original implementation of view, produces a pdf in a4 format, regardless of the typeset object. #6591 introduced the tightpage option which produces a document whose size matches the typeset object.

Since then, the tightpage=True option has grown popular; in fact most of the time, this is the desirable choice. Therefore this ticket makes tightpage=True the default.

Note: in some cases, the current implementation of tightpage crops the border of the picture. This will be fixed in a separate ticket to make tightpage even more appealing.

Change History (20)

comment:1 Changed 5 years ago by moritz

  • Branch set to u/moritz/ticket/21929
  • Commit set to 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e2

New commits:

​7f932caFixing ticket 21929

comment:2 Changed 5 years ago by git

  • Commit changed from 7f932ca4b9c6c1d5e7c732b04d6b2e17e56bb6e2 to 15d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9

Branch pushed to git repo; I updated commit sha1. New commits:

​15d6d2fChanged documentation to indicate the new default behavior

comment:3 Changed 5 years ago by moritz

I would like to remove the many occurrences of tightpage=True in various files to reflect the new defaults.

comment:4 Changed 5 years ago by git

  • Commit changed from 15d6d2f8c8da27676a5f9ba9e5f92cd8cb494ae9 to 800b0510e08381368e649b53ade1af09f89fb9fd

Branch pushed to git repo; I updated commit sha1. New commits:

​800b051removed occurances of 'tightpage=true'

comment:5 Changed 5 years ago by moritz

  • Authors set to moritz
  • Status changed from new to needs_review

comment:6 Changed 5 years ago by jipilab

Hi Moritz,

Did you make a circular search do look for all instances of "tightpage=(T)true"?

comment:7 Changed 5 years ago by jipilab

  • Authors changed from moritz to Moritz Firsching
  • Cc jipilab added
  • Reviewers set to Jean-Philippe Labbé

comment:8 Changed 5 years ago by jipilab

  • Status changed from needs_review to needs_work

Hi Moritz,

Could you also adapt the text in the documentation of view concerning the option "tightpage" so that it makes sense with the updated default value. For example, say what it does when it is set to "False".

comment:9 Changed 5 years ago by jipilab

All test passed on Sage7.5.b3.

comment:10 Changed 5 years ago by git

  • Commit changed from 800b0510e08381368e649b53ade1af09f89fb9fd to bf273fa6d434bc6ceab51165d233c55cab0ecd7a

Branch pushed to git repo; I updated commit sha1. New commits:

​bf273famore improvements in the documentation

comment:11 Changed 5 years ago by moritz

  • Status changed from needs_work to needs_review

I searched for all instances of tightpage=True and hopefully didn't miss any.

The last commit addresses the changes in the documentation you suggest.

New commits:

​bf273famore improvements in the documentation

comment:12 Changed 5 years ago by jipilab

  • Cc nthiery added

Great! All test passed.

I would like to have a second opinion. Nicolas, anything to say about the patch?

This looks good for a positive review on my part.

comment:13 Changed 5 years ago by git

  • Commit changed from bf273fa6d434bc6ceab51165d233c55cab0ecd7a to 397cd789434ca1ae6430ca0e652d1cba72e725bf

Branch pushed to git repo; I updated commit sha1. New commits:

​397cd78fixed one more occurance

comment:14 Changed 5 years ago by jipilab

Dear Moritz,

I did a pep8 check on latex.py. Could you remove the "blanklines containing whitespaces" and "trailing whitespaces" in line 2101 and 2103, 2118 of latex.py.

JP

comment:15 Changed 5 years ago by nthiery

  • Description modified (diff)
  • Summary changed from make "tightpage" the default behavior for view to Make "tightpage=True" the default behavior for view

comment:16 Changed 5 years ago by nthiery

  • Description modified (diff)

comment:17 Changed 5 years ago by nthiery

For the record: we made a quick poll here at Sage Days 79, and everybody who cared voted to make tightpage=True the default.

comment:18 Changed 5 years ago by git

  • Commit changed from 397cd789434ca1ae6430ca0e652d1cba72e725bf to 1bf46974281079b09f3a08abb934b04547c629a8

Branch pushed to git repo; I updated commit sha1. New commits:

​1bf4697removed some whitespace

comment:19 Changed 5 years ago by jipilab

  • Status changed from needs_review to positive_review

Looks ok to me now. I'm setting it to positive review.

comment:20 Changed 5 years ago by vbraun

  • Branch changed from u/moritz/ticket/21929 to 1bf46974281079b09f3a08abb934b04547c629a8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.