Opened 5 years ago

Closed 5 years ago

#21927 closed enhancement (fixed)

Unify and improve ModularSymbols_ambient.modular_symbols_of_level()

Reported by: pbruin Owned by:
Priority: minor Milestone: sage-7.5
Component: modular forms Keywords: modular symbols
Cc: mderickx Merged in:
Authors: Peter Bruin Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4cc2d79 (Commits, GitHub, GitLab) Commit: 4cc2d7911ba68e3f7a37eed86c3b6fe0ebe11d8a
Dependencies: Stopgaps:

Status badges

Description

The implementations of modular_symbols_of_level in various subclasses of ModularSymbols_ambient are very similar, but impose different conditions on the input (no condition for Gamma0 and Gamma1; too strict for GammaH, see #21798). This ticket does the following:

  • move these methods, for spaces of modular symbols for congruence subgroups of type Gamma0, Gamma1 and GammaH, to one method in ModularSymbols_ambient
  • permit the level to be given as a congruence subgroup instead of an integer
  • in any case, impose the condition that the old group contains the new group or vice versa.

The corresponding method for modular symbols with character is unchanged and overrides the one introduced here, since it operates with characters instead of the groups themselves.

Change History (4)

comment:1 Changed 5 years ago by pbruin

  • Branch set to u/pbruin/21927-modular_symbols_of_level
  • Commit set to 4cc2d7911ba68e3f7a37eed86c3b6fe0ebe11d8a
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by mderickx

  • Cc mderickx added

comment:3 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good enough

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/pbruin/21927-modular_symbols_of_level to 4cc2d7911ba68e3f7a37eed86c3b6fe0ebe11d8a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.