Opened 3 years ago

Closed 3 years ago

#21908 closed defect (fixed)

Fix _ascii_art_ for 0 in a CombinatorialFreeModule

Reported by: tscrim Owned by:
Priority: major Milestone: sage-7.5
Component: combinatorics Keywords: days79
Cc: sage-combinat, nthiery Merged in:
Authors: Travis Scrimshaw Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 43dc778 (Commits) Commit: 43dc7785fd9f75e51ae2de2ae27eb97f8b6d5dcb
Dependencies: Stopgaps:

Description

Currently it returns a string, not an AsciiArt object.

Change History (5)

comment:1 Changed 3 years ago by tscrim

Hey Nicolas, this is a quick bug that I have a branch that fixes it. Do you want to save it to use for a how-to-contribute demo?

comment:2 Changed 3 years ago by nthiery

sounds good!

comment:3 Changed 3 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Branch set to public/combinat/fix_ascii_art_CFM-21908
  • Commit set to 43dc7785fd9f75e51ae2de2ae27eb97f8b6d5dcb
  • Keywords days79 added
  • Status changed from new to needs_review

New commits:

43dc778Fix _ascii_art_ for 0 in a CFM.

comment:4 Changed 3 years ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/fix_ascii_art_CFM-21908 to 43dc7785fd9f75e51ae2de2ae27eb97f8b6d5dcb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.