Opened 3 years ago

Closed 3 years ago

#21904 closed enhancement (fixed)

py3 replace <type 'list'> by <... 'list'> in doctests

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.5
Component: python3 Keywords:
Cc: jdemeyer, jmantysalo, embray, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 797dd7b (Commits) Commit: 797dd7b4c273556d9677fadffa2ef6dd7f113857
Dependencies: Stopgaps:

Description (last modified by chapoton)

because py3 will answer <class 'list'>

done using

grep -rl "<type 'list" src/sage/ | xargs sed -i "s/<type 'list/<... 'list/g"

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/21904
  • Cc jdemeyer jmantysalo embray tscrim added
  • Commit set to 797dd7b4c273556d9677fadffa2ef6dd7f113857
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

797dd7breplace <type 'list'> by <... 'list'> (for py3 compatibility)

comment:2 Changed 3 years ago by chapoton

should be an easy review

comment:3 Changed 3 years ago by chapoton

green bot, please review (trivial one)

comment:4 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

comment:5 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to positive_review

This is OK.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/21904 to 797dd7b4c273556d9677fadffa2ef6dd7f113857
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.