Opened 4 years ago
Closed 4 years ago
#21898 closed enhancement (fixed)
py3 some __nonzero__ alias for __bool__
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | python3 | Keywords: | |
Cc: | jdemeyer, jmantysalo, tscrim | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | ae363cf (Commits) | Commit: | ae363cf10d998cf32b84219aac969d10ac41209f |
Dependencies: | Stopgaps: |
Description
this time outside of rings folder
part of #16076
Change History (8)
comment:1 Changed 4 years ago by
- Branch set to u/chapoton/21898
- Commit set to d14f0d264f0051d9b02dc9181bc8f301b257b10d
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
Looks good but let's wait for the bot.
comment:3 Changed 4 years ago by
- Commit changed from d14f0d264f0051d9b02dc9181bc8f301b257b10d to 0fb3b8030babdc9eba3caccdc7ca141adc61528e
Branch pushed to git repo; I updated commit sha1. New commits:
0fb3b80 | trac 21898 undo one specific change (abstract_method) for the moment
|
comment:4 Changed 4 years ago by
- Commit changed from 0fb3b8030babdc9eba3caccdc7ca141adc61528e to ae363cf10d998cf32b84219aac969d10ac41209f
Branch pushed to git repo; I updated commit sha1. New commits:
ae363cf | trac 21898 do not require __bool__ for the moment
|
comment:5 Changed 4 years ago by
bot is now green, please review.
comment:6 Changed 4 years ago by
- Cc jdemeyer jmantysalo tscrim added
comment:7 Changed 4 years ago by
- Reviewers set to Jori Mäntysalo
- Status changed from needs_review to positive_review
OK.
comment:8 Changed 4 years ago by
- Branch changed from u/chapoton/21898 to ae363cf10d998cf32b84219aac969d10ac41209f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
another bunch of alias "__nonzero__" for "__bool__" (not in rings folder)