Changes between Initial Version and Version 2 of Ticket #21893


Ignore:
Timestamp:
11/18/16 03:30:25 (4 years ago)
Author:
saraedum
Comment:

New commits:

a770337SymbolicRing is a singleton
901bae3SymbolicRing is a singleton
5979aefCallableSymbolicExpressionRing_class get only created through a factory
5d32dbdProperly call the super class constructors of CallableSymbolicExpressionRing_class
36c6bb0Run test suites for symbolic rings

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21893

    • Property Commit changed from to 36c6bb000fb994851cb4b8e53d2e84cf1e47829e
    • Property Branch changed from to u/saraedum/properly_initialize_symbolic_rings
  • Ticket #21893 – Description

    initial v2  
    44sage: TestSuite(f.parent()).run()
    55AttributeError
     6sage: 'sum' in dict(f.parent())
     7True
     8sage: f.parent().sum
     9AttributeError
    610}}}
     11This is because this symbolic ring does not call its super classes `__init__` and therefore it does not inherit correctly the methods of its category.
    712
    8 Also, some tests do not pass because the factory is not properly used:
     13Also, some tests do not pass because the pickling provided by factory is not properly used:
    914{{{
    1015sage: f.parent()._test_pickling()