Opened 3 years ago

Closed 2 years ago

#21885 closed enhancement (wontfix)

Enable Pynac's Giac support

Reported by: rws Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: symbolics Keywords:
Cc: frederichan Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is a followup on #20916 where Giac support in Pynac was proactively disabled because on Debian systems linking with Giac requires the libao-dev package installed. To disable Pynac's Giac support unconditionally however was too drastic a remedy. This was done better by #20946 where Giac's configure is given the option --disable-ao. This means #20916 can be reverted.

Change History (9)

comment:1 Changed 3 years ago by rws

  • Branch set to u/rws/enable_pynac_s_giac_support

comment:2 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to ccad160614d6f1584068ce6f5b958b81121344ed
  • Dependencies set to pynac-0.7.1
  • Status changed from new to needs_review

This is dependent on the upcoming pynac-0.7.1 upgrade which fixes a doctest fail. Please someone test this (with giac and pynac-0.7.1 installed) on Debian/Ubuntu which previously gave problems.


New commits:

ccad16021885: Enable Pynac's Giac support

comment:3 Changed 3 years ago by frederichan

Hi ralf, in your branch the package-version.txt is pynac 0.7.0. So is there another branch with 0.7.1, or where can I download it?

comment:4 Changed 3 years ago by rws

Frédéric, thanks for the interest. Sorry, I was a bit fast. I will change the dependency to the pynac-0.7.1 upgrade ticket when that version is released. It is possible to test pynac git master now but there are more steps involved (see https://github.com/pynac/pynac/wiki/Setting-up-a-development-environment) so I don't expect anyone to do this now.

comment:5 Changed 3 years ago by rws

  • Dependencies changed from pynac-0.7.1 to #21963

comment:6 Changed 3 years ago by rws

  • Status changed from needs_review to needs_work

comment:7 Changed 3 years ago by rws

  • Authors Ralf Stephan deleted
  • Branch u/rws/enable_pynac_s_giac_support deleted
  • Commit ccad160614d6f1584068ce6f5b958b81121344ed deleted
  • Dependencies #21963 deleted
  • Milestone changed from sage-7.5 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

Giac support in Pynac was finally turned on again in #22219 so this is a duplicate.

comment:8 Changed 3 years ago by rws

  • Status changed from needs_review to positive_review

comment:9 Changed 2 years ago by embray

  • Resolution set to wontfix
  • Status changed from positive_review to closed

Closing tickets in the sage-duplicate/invalid/wontfix module with positive_review (i.e. someone has confirmed they should be closed).

Note: See TracTickets for help on using tickets.