Opened 6 years ago

Closed 6 years ago

#21878 closed enhancement (fixed)

py3 cmp in one cython file in tests folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.5
Component: python3 Keywords:
Cc: tscrim, aapitzsch, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: bdbb694 (Commits, GitHub, GitLab) Commit: bdbb694abe8e65f5d7b06e6c4b4006bbf03a0ad4
Dependencies: Stopgaps:

GitHub link to the corresponding issue


as a tiny step to py3

get rid of cmp() by using richcmp

Change History (4)

comment:1 Changed 6 years ago by chapoton

Authors: Frédéric Chapoton
Branch: u/chapoton/21878
Cc: tscrim aapitzsch jdemeyer added
Commit: bdbb694abe8e65f5d7b06e6c4b4006bbf03a0ad4
Status: newneeds_review

New commits:

bdbb694convert cmp to richcmp in a pyx file in tests folde

comment:2 Changed 6 years ago by chapoton

bot is green ; please review

comment:3 Changed 6 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

comment:4 Changed 6 years ago by vbraun

Branch: u/chapoton/21878bdbb694abe8e65f5d7b06e6c4b4006bbf03a0ad4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.