Opened 6 years ago

Closed 6 years ago

#21870 closed defect (fixed)

Get rid of six.moves.range in Cython files (step 3)

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-7.5
Component: cython Keywords:
Cc: chapoton Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 1d83f0d (Commits, GitHub, GitLab) Commit: 1d83f0da23ec1bd4b7a92049af5df3f7f36d775c
Dependencies: Stopgaps:

Status badges

Description

See also #21476 and #21519.

Change History (8)

comment:1 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/21870
  • Commit set to 48c4a6e8896d0f582ff1595a22fa8133d4cf351a
  • Status changed from new to needs_review

here is a branch, needs to be tested

New commits:

​48c4a6etrac 21870 do not import range from six.moves in pyx files at all

comment:2 Changed 6 years ago by jdemeyer

  • Authors changed from Jeroen Demeyer to Frédéric Chapoton
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:3 Changed 6 years ago by chapoton

  • Status changed from positive_review to needs_work

one failing doctest

comment:4 Changed 6 years ago by git

  • Commit changed from 48c4a6e8896d0f582ff1595a22fa8133d4cf351a to 1d83f0da23ec1bd4b7a92049af5df3f7f36d775c

Branch pushed to git repo; I updated commit sha1. New commits:

​1d83f0dtracc 21870 fixing doctest

comment:5 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

doctest corrected, back to needs review

comment:6 Changed 6 years ago by jdemeyer

Let's wait for the patchbot...

comment:7 Changed 6 years ago by chapoton

  • Status changed from needs_review to positive_review

bot being green, I allow myself to set back to positive

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/chapoton/21870 to 1d83f0da23ec1bd4b7a92049af5df3f7f36d775c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.