Opened 3 years ago

Last modified 10 months ago

#21869 closed enhancement

A framework for discrete valuations in Sage — at Version 32

Reported by: saraedum Owned by:
Priority: major Milestone: sage-7.5
Component: commutative algebra Keywords: discrete valuations, valuations, p-adics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87
Cc: Merged in:
Authors: Julian Rüth Reviewers:
Report Upstream: N/A Work issues: move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits
Branch: u/saraedum/a_framework_for_discrete_valuations_in_sage (Commits) Commit: c0a81c8285b47f6fc89aa34bc125ac474c75f2e9
Dependencies: Stopgaps:

Description (last modified by saraedum)

This is a meta-ticket to keep track of the progress of integrating https://github.com/saraedum/mac_lane into Sage.

Review

For your convenience you can review this ticket at https://github.com/saraedum/mac_lane/pull/4 (and leave inline comments.)

Please check off [x] the following when you think that a file is in good shape (modulo the comments that you made.) Or put a [-] if it needs substantial work.

[ ] function_field/function_field_valuation.py
[ ] padics/discrete_value_group.py
[ ] padics/padic_valuation.py
[-] valuation/README.md
[x] valuation/__init__.py
[ ] valuation/all.py
[ ] valuation/augmented_valuation.py
[ ] valuation/developing_valuation.py
[ ] valuation/gauss_valuation.py
[ ] valuation/inductive_valuation.py
[ ] valuation/limit_valuation.py
[ ] valuation/mapped_valuation.py
[ ] valuation/scaled_valuation.py
[ ] valuation/trivial_valuation.py
[ ] valuation/valuation.py
[ ] valuation/valuation_space.py
[ ] valuation/valuations_catalog.py
[ ] valuation/value_group.py

Necessary changes

Fix bugs in Sage

There are a number of trivial bugs that get fixed by monkey-patches in https://github.com/saraedum/mac_lane/blob/master/__init__.py

  1. Conversion from a Function Field to its Constant Field #21872
  2. Conversion from a Function Field to its underlying Polynomial Ring #23166
  3. Coercions between Function Fields #23167
  4. Coercions are injective if the underlying map is #21879
  5. Ring homomorphisms from Fields are injective #21879
  6. Polynomial rings embed into their fraction fields #23185
  7. The embedding of a ring into a polynomial ring over that ring is injective #23203, #23204, #23211
  8. p-adic rings embed into their fraction fields #23188
  9. Morphisms of number fields are injective #21879
  10. ZZ into QQ is injective #21879
  11. quotients of polynomial rings are injective/surjective #23190
  12. ZZ into a Number Field is injective #21879
  13. ZZ into an order of a Number Field is injective #21879
  14. ZZ does not map onto QQ #23186
  15. ZpCA shifts are broken
  16. add default implementation of inverse_of_unit() #23191

Add new features to Sage

New features that the code needs to work

  1. Factorization over iterated extensions of finite fields. #21996
  2. principal_part() and sides() of a Newton Polygon (patch this in the calling code instead.)
  3. (cached_in_argument_method #22034)

Make tests non-trivial

  1. (some_elements() should be non-trivial for number fields/orders) #23192
  2. (some_elements() should be non-trivial/deterministic for rational function fields and their extensions) #23193
  3. (some_elements() should be non-trivial for fraction_fields of polynomial rings) #23194

Add the valuation code to Sage

i.e., add these files https://github.com/saraedum/mac_lane to Sage.

Change History (32)

comment:1 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:2 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:3 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:4 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:5 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:6 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:7 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:8 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:9 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:10 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:11 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:12 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:13 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:14 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:15 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:16 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:17 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:18 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:19 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:20 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:21 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:22 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:23 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:24 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:25 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:26 Changed 2 years ago by saraedum

  • Description modified (diff)

comment:27 Changed 2 years ago by saraedum

  • Branch set to u/saraedum/a_framework_for_discrete_valuations_in_sage

comment:28 Changed 2 years ago by roed

  • Commit set to 0f615c771cac39a2cce4d54b4fd190f1c84992de
  • Keywords sd87 added

Last 10 new commits:

925d8fafix typo in comment
c4a7b1aAdded a tutorial in the README
20e6110move to subdirectory for merging with sage tree
ed206ecremoving gitignore for merge with sage tree
14799b0Merge mac_lane infrastructure for discrete valuations into sage
0767201remove mac_lane LICENSE
bd1dcbfremove obsolete TODOs
0eb3fffremove monkey patches
6c3a301move valuation code to valuation/
0f615c7remove specific valuation code out of valuation/

comment:29 Changed 2 years ago by git

  • Commit changed from 0f615c771cac39a2cce4d54b4fd190f1c84992de to 4153ef9b3a920d079437825960d904205fc2ae53

Branch pushed to git repo; I updated commit sha1. New commits:

8afc361remove standalone import commands
4153ef9Wired up valuations in the Sage library

comment:30 Changed 2 years ago by git

  • Commit changed from 4153ef9b3a920d079437825960d904205fc2ae53 to c0a81c8285b47f6fc89aa34bc125ac474c75f2e9

Branch pushed to git repo; I updated commit sha1. New commits:

c0a81c8fix function lookup

comment:31 Changed 2 years ago by saraedum

  • Description modified (diff)

New commits:

c0a81c8fix function lookup

comment:32 Changed 2 years ago by saraedum

  • Authors set to Julian Rüth
  • Description modified (diff)
  • Work issues set to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits
Note: See TracTickets for help on using tickets.