id,summary,reporter,owner,description,type,status,priority,milestone,component,resolution,keywords,cc,merged,author,reviewer,upstream,work_issues,branch,commit,dependencies,stopgaps
21869,A framework for discrete valuations in Sage,saraedum,,"This is a meta-ticket to keep track of the progress of integrating https://github.com/saraedum/mac_lane into Sage.
== Fix bugs in Sage ==
There are a number of trivial bugs that get fixed by monkey-patches in https://github.com/saraedum/mac_lane/blob/master/__init__.py
1. Conversion from a Function Field to its Constant Field #21872
1. Conversion from a Function Field to its underlying Polynomial Ring #23166
1. Coercions between Function Fields #23167
1. Coercions are injective if the underlying map is #21879
1. Ring homomorphisms from Fields are injective #21879
1. Polynomial rings embed into their fraction fields #23185
1. ~~The embedding of a ring into a polynomial ring over that ring is injective~~
1. p-adic rings embed into their fraction fields #23188
1. Morphisms of number fields are injective #21879
1. ZZ into QQ is injective #21879
1. quotients of polynomial rings are injective/surjective #23190
1. ZZ into a Number Field is injective #21879
1. ZZ into an order of a Number Field is injective #21879
1. ZZ does not map onto QQ #23186
1. ~~ZpCA shifts are broken~~
1. (some_elements() should return more than just [1] for most rings.)
== Add new features to Sage ==
New features that the code needs to work
1. Factorization over iterated extensions of finite fields. #21996
1. ~~principal_part() and sides() of a Newton Polygon~~ (patch this in the calling code instead.)
1. (cached_in_argument_method #22034)
== Make tests non-trivial ==
1. (some_elements() should be non-trivial for number fields/orders)
1. (some_elements() should be non-trivial for rational function fields and their extensions)
1. (some_elements() should be non-trivial for fraction_fields of polynomial rings)
== Add the valuation code to Sage ==
i.e., add these files https://github.com/saraedum/mac_lane to Sage.",task,new,minor,sage-7.5,commutative algebra,,"discrete valuations, valuations, p-adics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm",,,,,N/A,,,,,