Opened 6 years ago

# A framework for discrete valuations in Sage — at Version 19

Reported by: Owned by: saraedum major sage-7.5 commutative algebra discrete valuations, valuations, p-adics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87 N/A

This is a meta-ticket to keep track of the progress of integrating https://github.com/saraedum/mac_lane into Sage.

## Fix bugs in Sage

There are a number of trivial bugs that get fixed by monkey-patches in https://github.com/saraedum/mac_lane/blob/master/__init__.py

1. Conversion from a Function Field to its Constant Field #21872
2. Conversion from a Function Field to its underlying Polynomial Ring #23166
3. Coercions between Function Fields #23167
4. Coercions are injective if the underlying map is #21879
5. Ring homomorphisms from Fields are injective #21879
6. Polynomial rings embed into their fraction fields #23185
7. The embedding of a ring into a polynomial ring over that ring is injective
8. p-adic rings embed into their fraction fields #23188
9. Morphisms of number fields are injective #21879
10. ZZ into QQ is injective #21879
11. quotients of polynomial rings are injective/surjective #23190
12. ZZ into a Number Field is injective #21879
13. ZZ into an order of a Number Field is injective #21879
14. ZZ does not map onto QQ #23186
15. ZpCA shifts are broken
16. (some_elements() should return more than just [1] for most rings.)

## Add new features to Sage

New features that the code needs to work

1. Factorization over iterated extensions of finite fields. #21996
2. principal_part() and sides() of a Newton Polygon (patch this in the calling code instead.)
3. (cached_in_argument_method #22034)

## Add the valuation code to Sage

i.e., add these files https://github.com/saraedum/mac_lane to Sage.

### comment:1 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:2 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:3 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:4 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:5 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:6 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:7 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:8 Changed 6 years ago by saraedum

• Description modified (diff)

### comment:9 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:10 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:11 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:12 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:13 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:14 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:15 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:16 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:17 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:18 Changed 5 years ago by saraedum

• Description modified (diff)

### comment:19 Changed 5 years ago by saraedum

• Description modified (diff)
Note: See TracTickets for help on using tickets.