Opened 5 years ago
Last modified 3 years ago
#21869 closed enhancement
A framework for discrete valuations in Sage — at Version 124
Reported by:  saraedum  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  commutative algebra  Keywords:  discrete valuations, valuations, padics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87 
Cc:  Merged in:  
Authors:  Julian Rüth  Reviewers:  GaYee Park, Stefan Wewers, David Roe, Padmavathi Srinivasan, Shiva Chidambaram 
Report Upstream:  N/A  Work issues:  33 failing doctests, check generated documentation, add references to method, comments on github 
Branch:  u/saraedum/a_framework_for_discrete_valuations_in_sage (Commits, GitHub, GitLab)  Commit:  d893c55a222ef01c0c281c7fc9032118003e8dcc 
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483  Stopgaps: 
Description (last modified by )
This is a metaticket to keep track of the progress of integrating https://github.com/saraedum/mac_lane into Sage.
Review
For your convenience you can review this ticket at https://github.com/saraedum/mac_lane/pull/4 (and leave inline comments.)
Please check off [x]
the following when you think that a file is in good shape (modulo the comments that you made.) Or put a []
if it needs substantial work. You can put your name next to file to tell others that you are already having a look at it.
[x] function_field/function_field_valuation.py (Stefan Wewers) [x] padics/discrete_value_group.py [x] padics/padic_valuation.py (David) [x] valuation/README.md [x] valuation/__init__.py [x] valuation/all.py (David) [x] valuation/augmented_valuation.py (David) [x] valuation/developing_valuation.py (Shiva) [x] valuation/gauss_valuation.py (Padmavathi) [x] valuation/inductive_valuation.py (David) [x] valuation/limit_valuation.py (David) [x] valuation/mapped_valuation.py (David) [x] valuation/scaled_valuation.py (David) [x] valuation/trivial_valuation.py (David) [x] valuation/valuation.py (David) [x] valuation/valuation_space.py (David) [x] valuation/valuations_catalog.py (David) [x] valuation/value_group.py (Padmavathi) [x] rings/function_field/function_field.py [x] rings/integer_ring.pyx [x] rings/number_field/number_field.py [x] rings/number_field/order.py [x] rings/padics/padic_generic.py [x] rings/rational_field.py
Testing
Because of all the dependencies of this ticket it is a bit hard to build this. If you have access to k8s, you can use the version in ~/Src/sagemac_lane/
to try this package out. (Please do not push all the dependencies onto this branch as this is going to make reviewing this much harder.)
Known Issues
Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:
sage t warnlong 39.1 src/sage/rings/function_field/function_field_valuation.py # 126 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/valuation.py # 9 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/limit_valuation.py # 52 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/mapped_valuation.py # 42 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/inductive_valuation.py # 13 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/augmented_valuation.py # 10 doctests failed
Necessary changes
Fix bugs in Sage
There are a number of trivial bugs that get fixed by monkeypatches in https://github.com/saraedum/mac_lane/blob/master/__init__.py
 Conversion from a Function Field to its Constant Field #21872
 Conversion from a Function Field to its underlying Polynomial Ring #23166
 Coercions between Function Fields #23167
 Coercions are injective if the underlying map is #21879
 Ring homomorphisms from Fields are injective #21879
 Polynomial rings embed into their fraction fields #23185
 The embedding of a ring into a polynomial ring over that ring is injective #23203, #23204, #23211
 padic rings embed into their fraction fields #23188
 Morphisms of number fields are injective #21879
 ZZ into QQ is injective #21879
 quotients of polynomial rings are injective/surjective #23190
 ZZ into a Number Field is injective #21879
 ZZ into an order of a Number Field is injective #21879
 ZZ does not map onto QQ #23186
ZpCA shifts are broken add default implementation of inverse_of_unit() #23191
 R[x]→S[x] is injective/surjective if R→S is #23495
Add new features to Sage
New features that the code needs to work
 Factorization over iterated extensions of finite fields. #21996
principal_part() and sides() of a Newton Polygon(patch this in the calling code instead.) (cached_in_argument_method #22034)
Make tests nontrivial
 (some_elements() should be nontrivial for number fields/orders) #23192
 (some_elements() should be nontrivial/deterministic for rational function fields and their extensions) #23193
 (some_elements() should be nontrivial for fraction_fields of polynomial rings) #23194
Add the valuation code to Sage
i.e., add these files https://github.com/saraedum/mac_lane to Sage.
Change History (124)
comment:1 Changed 5 years ago by
 Description modified (diff)
comment:2 Changed 5 years ago by
 Description modified (diff)
comment:3 Changed 5 years ago by
 Description modified (diff)
comment:4 Changed 5 years ago by
 Description modified (diff)
comment:5 Changed 5 years ago by
 Description modified (diff)
comment:6 Changed 5 years ago by
 Description modified (diff)
comment:7 Changed 5 years ago by
 Description modified (diff)
comment:8 Changed 5 years ago by
 Description modified (diff)
comment:9 Changed 4 years ago by
 Description modified (diff)
comment:10 Changed 4 years ago by
 Description modified (diff)
comment:11 Changed 4 years ago by
 Description modified (diff)
comment:12 Changed 4 years ago by
 Description modified (diff)
comment:13 Changed 4 years ago by
 Description modified (diff)
comment:14 Changed 4 years ago by
 Description modified (diff)
comment:15 Changed 4 years ago by
 Description modified (diff)
comment:16 Changed 4 years ago by
 Description modified (diff)
comment:17 Changed 4 years ago by
 Description modified (diff)
comment:18 Changed 4 years ago by
 Description modified (diff)
comment:19 Changed 4 years ago by
 Description modified (diff)
comment:20 Changed 4 years ago by
 Description modified (diff)
comment:21 Changed 4 years ago by
 Description modified (diff)
comment:22 Changed 4 years ago by
 Description modified (diff)
comment:23 Changed 4 years ago by
 Description modified (diff)
comment:24 Changed 4 years ago by
 Description modified (diff)
comment:25 Changed 4 years ago by
 Description modified (diff)
comment:26 Changed 4 years ago by
 Description modified (diff)
comment:27 Changed 4 years ago by
 Branch set to u/saraedum/a_framework_for_discrete_valuations_in_sage
comment:28 Changed 4 years ago by
 Commit set to 0f615c771cac39a2cce4d54b4fd190f1c84992de
 Keywords sd87 added
comment:29 Changed 4 years ago by
 Commit changed from 0f615c771cac39a2cce4d54b4fd190f1c84992de to 4153ef9b3a920d079437825960d904205fc2ae53
comment:30 Changed 4 years ago by
 Commit changed from 4153ef9b3a920d079437825960d904205fc2ae53 to c0a81c8285b47f6fc89aa34bc125ac474c75f2e9
Branch pushed to git repo; I updated commit sha1. New commits:
c0a81c8  fix function lookup

comment:31 Changed 4 years ago by
 Description modified (diff)
New commits:
c0a81c8  fix function lookup

comment:32 Changed 4 years ago by
 Description modified (diff)
 Work issues set to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits
comment:33 Changed 4 years ago by
 Status changed from new to needs_review
comment:34 Changed 4 years ago by
 Description modified (diff)
comment:35 Changed 4 years ago by
 Description modified (diff)
comment:36 followup: ↓ 38 Changed 4 years ago by
I was reviewing gauss_valuation.py and tried reducing a polynomial using the Gauss valuation induced by the 2adic valuation, and got an unexpected error message. I thought it would tell me that the polynomial wasn't integral, and instead it gave me a coercion error.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: h 1/2*y^2 sage: v.reduce(h)  TypeError Traceback (most recent call last) <ipythoninput1084d78566b468b> in <module>() > 1 v.reduce(h) /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in reduce(self, f, check, degree_bound, coefficients, valuations) 360 361 """ > 362 f = self.domain().coerce(f) 363 364 if degree_bound is not None: /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11229)() 1166 return False 1167 > 1168 cpdef coerce(self, x): 1169 """ 1170 Return x as an element of self, if and only if there is a canonical /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11158)() 1193 except Exception: 1194 _record_exception() > 1195 raise TypeError("no canonical coercion from %s to %s" % (parent(x), self)) 1196 else: 1197 return (<map.Map>mor)._call_(x) TypeError: no canonical coercion from Univariate Polynomial Ring in y over Rational Field to Univariate Polynomial Ring in y over Integer Ring
comment:37 followup: ↓ 39 Changed 4 years ago by
equivalence_unit from gauss_valuation.py isn't outputting the results shown in the example input 2 as shown in the file.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: v.equivalence_unit(2) 4 sage: v.equivalence_unit(2)  ValueError Traceback (most recent call last) <ipythoninput12871aadb857663> in <module>() > 1 v.equivalence_unit(Integer(2)) /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller.__call__ (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc.c:1079 2)() 2036 return cache[k] 2037 except KeyError: > 2038 w = self._instance_call(*args, **kwds) 2039 cache[k] = w 2040 return w /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller._instance_call (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc. c:10238)() 1912 True 1913 """ > 1914 return self.f(self._instance, *args, **kwds) 1915 1916 cdef fix_args_kwds(self, tuple args, dict kwds): /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in equivalence_unit(self, s, reciprocal) 474 return self.equivalence_reciprocal(self.equivalence_unit(s)) 475 > 476 ret = self._base_valuation.element_with_valuation(s) 477 return self.domain()(ret) 478 /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/valuation_space.py in element_with_valuation(self, s) 465 s = QQ.coerce(s) 466 if s not in self.value_semigroup(): > 467 raise ValueError("s must be in the value semigroup of this valuation but %r is not in %r"%(s, self.value_semigroup())) 468 if s == 0: 469 return self.domain().one() ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
comment:38 in reply to: ↑ 36 Changed 4 years ago by
Thanks for reporting this. I think this is ok. The problem here is not that the polynomial is not integral but that the polynomial is not in the domain.
This works:
sage: R.<x> = QQ[] sage: v = valuations.GaussValuation(R, QQ.valuation(2)) sage: v.reduce(x + 1/2) ValueError: reduction not defined for nonintegral elements and x + 1/2 is not integral over Gauss valuation induced by 2adic valuation
This does not:
sage: R.<x> = ZZ[] sage: v = valuations.GaussValuation(R, ZZ.valuation(2)) sage: v.reduce(x + 1/2) TypeError: no canonical coercion from Univariate Polynomial Ring in x over Rational Field to Univariate Polynomial Ring in x over Integer Ring
Replying to padma_sk:
I was reviewing gauss_valuation.py and tried reducing a polynomial using the Gauss valuation induced by the 2adic valuation, and got an unexpected error message. I thought it would tell me that the polynomial wasn't integral, and instead it gave me a coercion error.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: h 1/2*y^2 sage: v.reduce(h)  TypeError Traceback (most recent call last) <ipythoninput1084d78566b468b> in <module>() > 1 v.reduce(h) /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in reduce(self, f, check, degree_bound, coefficients, valuations) 360 361 """ > 362 f = self.domain().coerce(f) 363 364 if degree_bound is not None: /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11229)() 1166 return False 1167 > 1168 cpdef coerce(self, x): 1169 """ 1170 Return x as an element of self, if and only if there is a canonical /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11158)() 1193 except Exception: 1194 _record_exception() > 1195 raise TypeError("no canonical coercion from %s to %s" % (parent(x), self)) 1196 else: 1197 return (<map.Map>mor)._call_(x) TypeError: no canonical coercion from Univariate Polynomial Ring in y over Rational Field to Univariate Polynomial Ring in y over Integer Ring
comment:39 in reply to: ↑ 37 Changed 4 years ago by
You are in the wrong domain in this example I think:
This is the error you are seeing because there is no element of valuation 2 in ZZ[x]
.
sage: R.<x> = ZZ[] sage: v = valuations.GaussValuation(R, ZZ.valuation(2)) sage: v.element_with_valuation(2) ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
However, this works in QQ[x]
.
sage: sage: R.<x> = QQ[] sage: v = valuations.GaussValuation(R, QQ.valuation(2)) sage: v.element_with_valuation(2) 1/4
Does that make sense? (Should it be documented more explicitly?)
Replying to padma_sk:
equivalence_unit from gauss_valuation.py isn't outputting the results shown in the example input 2 as shown in the file.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: v.equivalence_unit(2) 4 sage: v.equivalence_unit(2)  ValueError Traceback (most recent call last) <ipythoninput12871aadb857663> in <module>() > 1 v.equivalence_unit(Integer(2)) /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller.__call__ (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc.c:1079 2)() 2036 return cache[k] 2037 except KeyError: > 2038 w = self._instance_call(*args, **kwds) 2039 cache[k] = w 2040 return w /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller._instance_call (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc. c:10238)() 1912 True 1913 """ > 1914 return self.f(self._instance, *args, **kwds) 1915 1916 cdef fix_args_kwds(self, tuple args, dict kwds): /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in equivalence_unit(self, s, reciprocal) 474 return self.equivalence_reciprocal(self.equivalence_unit(s)) 475 > 476 ret = self._base_valuation.element_with_valuation(s) 477 return self.domain()(ret) 478 /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/valuation_space.py in element_with_valuation(self, s) 465 s = QQ.coerce(s) 466 if s not in self.value_semigroup(): > 467 raise ValueError("s must be in the value semigroup of this valuation but %r is not in %r"%(s, self.value_semigroup())) 468 if s == 0: 469 return self.domain().one() ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
comment:40 Changed 4 years ago by
 Description modified (diff)
comment:41 Changed 4 years ago by
 Dependencies set to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996
comment:42 Changed 4 years ago by
 Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190
comment:43 Changed 4 years ago by
 Description modified (diff)
comment:44 Changed 4 years ago by
 Description modified (diff)
comment:45 followup: ↓ 48 Changed 4 years ago by
 Reviewers set to GaYee Park
 Status changed from needs_review to needs_work
Ran the test and found the error:
sage t src/sage/rings/function_field/function_field.py # 7 doctests failed
comment:46 Changed 4 years ago by
 Description modified (diff)
comment:47 Changed 4 years ago by
 Description modified (diff)
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics
comment:48 in reply to: ↑ 45 Changed 4 years ago by
Replying to gpark:
Ran the test and found the error:
sage t src/sage/rings/function_field/function_field.py # 7 doctests failed
Did you run the tests with all the dependencies applied? About 50 tests fail for me. That's expected (since the dependencies are not in yet.)
comment:49 Changed 4 years ago by
 Description modified (diff)
 Reviewers changed from GaYee Park to GaYee Park, Stefan Wewers
comment:50 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:51 Changed 4 years ago by
 Description modified (diff)
comment:52 Changed 4 years ago by
 Description modified (diff)
comment:53 Changed 4 years ago by
The following errors are expected. I am working on them.
 sage t warnlong 39.1 src/sage/rings/valuation/limit_valuation.py # 52 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/gauss_valuation.py # 1 doctest failed sage t warnlong 39.1 src/sage/rings/valuation/valuation_space.py # 2 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/mapped_valuation.py # 42 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/valuation.py # 9 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/inductive_valuation.py # 13 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/augmented_valuation.py # 16 doctests failed 
comment:54 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests
comment:55 Changed 4 years ago by
 Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495
 Description modified (diff)
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics
comment:56 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests
comment:57 Changed 4 years ago by
 Description modified (diff)
Sorry, I somehow reverted some changes to the ticket description. Not sure how this happened.
comment:58 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests
comment:59 Changed 4 years ago by
 Description modified (diff)
comment:60 Changed 4 years ago by
 Description modified (diff)
comment:61 Changed 4 years ago by
 Description modified (diff)
I have had a look at function_field_valuation
. I have already worked with the code a lot, and it is working fine, and the documentation is extensive and clear. But I have only tested the latest standalone version.
comment:62 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests
comment:63 Changed 4 years ago by
 Reviewers changed from GaYee Park, Stefan Wewers to GaYee Park, Stefan Wewers, David Roe
comment:64 Changed 4 years ago by
 Commit changed from c0a81c8285b47f6fc89aa34bc125ac474c75f2e9 to 9fd87332c734899d860972d836d479283b5ab62f
Branch pushed to git repo; I updated commit sha1. New commits:
9fd8733  fix import

comment:65 Changed 4 years ago by
 Commit changed from 9fd87332c734899d860972d836d479283b5ab62f to e1e65a5d7514ebe51365bdf1da402d2054f02654
Branch pushed to git repo; I updated commit sha1. New commits:
e1e65a5  fixed typo

comment:66 Changed 4 years ago by
 Commit changed from e1e65a5d7514ebe51365bdf1da402d2054f02654 to 9c16a1bc642498daaa1c17f61a874cbd42f4063b
Branch pushed to git repo; I updated commit sha1. New commits:
9c16a1b  undo .valuation() shortcut

comment:67 Changed 4 years ago by
 Commit changed from 9c16a1bc642498daaa1c17f61a874cbd42f4063b to 119f2454cb4100c62300121a7df024a8b4dead9e
Branch pushed to git repo; I updated commit sha1. New commits:
119f245  It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space

comment:68 Changed 4 years ago by
 Commit changed from 119f2454cb4100c62300121a7df024a8b4dead9e to 7ea987498d844fb5aa28c4023cc8f4350d48a20a
Branch pushed to git repo; I updated commit sha1. New commits:
7ea9874  fix doctests

comment:69 Changed 4 years ago by
 Description modified (diff)
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests
comment:70 Changed 4 years ago by
 Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483
comment:71 Changed 4 years ago by
 Commit changed from 7ea987498d844fb5aa28c4023cc8f4350d48a20a to 0c60cb7006afcd336963fdcc7af5cab510cd796b
comment:72 Changed 4 years ago by
 Commit changed from 0c60cb7006afcd336963fdcc7af5cab510cd796b to 20100145cbdac34f8f3f021f597f750541c60d11
Branch pushed to git repo; I updated commit sha1. New commits:
2010014  restricting to ZZ, we need to know the prime

comment:73 Changed 4 years ago by
 Description modified (diff)
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests
comment:74 Changed 4 years ago by
 Commit changed from 20100145cbdac34f8f3f021f597f750541c60d11 to efe24904ec35606462a941a47fee496ebf463491
comment:75 Changed 4 years ago by
 Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495
 Description modified (diff)
 Reviewers changed from GaYee Park, Stefan Wewers, David Roe to GaYee Park, Stefan Wewers
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests
New commits:
e5ef4d8  do not catch everything

9fd8733  fix import

e1e65a5  fixed typo

9c16a1b  undo .valuation() shortcut

119f245  It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space

7ea9874  fix doctests

3fd4140  add doctest output

0c60cb7  fix valuation parameters

2010014  restricting to ZZ, we need to know the prime

efe2490  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:76 Changed 4 years ago by
 Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483
 Description modified (diff)
 Reviewers changed from GaYee Park, Stefan Wewers to GaYee Park, Stefan Wewers, David Roe
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests
Oops. Reverting.
comment:77 Changed 4 years ago by
 Description modified (diff)
comment:78 Changed 4 years ago by
 Commit changed from efe24904ec35606462a941a47fee496ebf463491 to 0fd986f1773f30ea1f89b01198892fd32c122882
Branch pushed to git repo; I updated commit sha1. New commits:
1eace28  Update valuation_space.py

21b0f68  Update valuation_space.py

38f3815  Update valuation_space.py

7c57f68  Update valuation_space.py

d90afa8  Update valuation_space.py

1cb8178  Update valuation_space.py

39cb55b  Update valuation_space.py

a474ed5  Update valuation_space.py

ca2089f  Update valuation_space.py

0fd986f  Merge remotetracking branch 'remotes/github/sage' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:79 Changed 4 years ago by
 Description modified (diff)
comment:80 Changed 4 years ago by
 Description modified (diff)
comment:81 Changed 4 years ago by
 Description modified (diff)
comment:82 Changed 4 years ago by
 Description modified (diff)
comment:83 Changed 4 years ago by
 Description modified (diff)
comment:84 Changed 4 years ago by
 Description modified (diff)
comment:85 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?
comment:86 Changed 4 years ago by
 Description modified (diff)
comment:87 Changed 4 years ago by
 Description modified (diff)
comment:88 Changed 4 years ago by
 Description modified (diff)
comment:89 Changed 4 years ago by
 Description modified (diff)
comment:90 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, make sure there are no more optional:integrateds
comment:91 Changed 4 years ago by
 Reviewers changed from GaYee Park, Stefan Wewers, David Roe to GaYee Park, Stefan Wewers, David Roe, Padmavathi Srinivasan, Shiva Chidambaram
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, make sure there are no more optional:integrateds to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?
comment:92 Changed 4 years ago by
 Commit changed from 0fd986f1773f30ea1f89b01198892fd32c122882 to 33aa99f1aa6c8e4478cd73c1808b3e7918a29402
Branch pushed to git repo; I updated commit sha1. New commits:
bcb78f3  Update scaled_valuation.py

be4daab  Update valuation.py

7a95a9d  Update augmented_valuation.py

dbf7791  Update augmented_valuation.py

58bb2bc  Update developing_valuation.py

e1c8bd5  Update limit_valuation.py

a0f6bd3  Update mapped_valuation.py

33aa99f  Update padic_valuation.py

comment:93 Changed 4 years ago by
 Commit changed from 33aa99f1aa6c8e4478cd73c1808b3e7918a29402 to 37d718725faa28404b3db194cc81b9eede19c01e
comment:94 Changed 4 years ago by
 Description modified (diff)
 Type changed from task to enhancement
comment:95 Changed 4 years ago by
 Description modified (diff)
comment:96 Changed 4 years ago by
 Commit changed from 37d718725faa28404b3db194cc81b9eede19c01e to 8da1ceb17a7bbcfbf174cdb754365d3ddca05cc0
Branch pushed to git repo; I updated commit sha1. New commits:
8da1ceb  Clarify semigroup construction

comment:97 Changed 4 years ago by
 Commit changed from 8da1ceb17a7bbcfbf174cdb754365d3ddca05cc0 to 07e40b964b4ab3a9f7cdf448bcd5956065fd787f
Branch pushed to git repo; I updated commit sha1. New commits:
07e40b9  add shifting doctest

comment:98 Changed 4 years ago by
 Description modified (diff)
New commits:
07e40b9  add shifting doctest

comment:99 Changed 4 years ago by
 Commit changed from 07e40b964b4ab3a9f7cdf448bcd5956065fd787f to 021b188797aa024ae6f17f4954f679eabcaed5c3
Branch pushed to git repo; I updated commit sha1. New commits:
021b188  improve error message

comment:100 Changed 4 years ago by
 Commit changed from 021b188797aa024ae6f17f4954f679eabcaed5c3 to a6a798f9e713f7237e81eea92cdaca9bc455eda3
Branch pushed to git repo; I updated commit sha1. New commits:
a6a798f  Clarified the notion of minimality

comment:101 Changed 4 years ago by
 Commit changed from a6a798f9e713f7237e81eea92cdaca9bc455eda3 to ee0db3141cb365e8e7cdf89ec568b3b493a179e9
Branch pushed to git repo; I updated commit sha1. New commits:
ee0db31  clarify meaning of effective_degree

comment:102 Changed 4 years ago by
 Commit changed from ee0db3141cb365e8e7cdf89ec568b3b493a179e9 to e9243b8ea32bdaba2694bc77071b3ee41b7355ce
Branch pushed to git repo; I updated commit sha1. New commits:
e9243b8  bring residue into the right residue ring

comment:103 Changed 4 years ago by
 Commit changed from e9243b8ea32bdaba2694bc77071b3ee41b7355ce to 24e68ecc6536c18d63d77d7f56ae4cb27a98ae10
Branch pushed to git repo; I updated commit sha1. New commits:
24e68ec  add to/from residue ring tests

comment:104 Changed 4 years ago by
 Commit changed from 24e68ecc6536c18d63d77d7f56ae4cb27a98ae10 to 2bed311a203da9a773b4cefe0bc3c6b5c038394b
comment:105 Changed 4 years ago by
 Commit changed from 2bed311a203da9a773b4cefe0bc3c6b5c038394b to 544977a3161e2f86d1e924b7403fd9709c77620a
comment:106 Changed 4 years ago by
 Commit changed from 544977a3161e2f86d1e924b7403fd9709c77620a to a0880bd55bb78b4c738917211adf2d0892a33038
Branch pushed to git repo; I updated commit sha1. New commits:
a0880bd  Fix bug in padic shift

comment:107 Changed 4 years ago by
 Commit changed from a0880bd55bb78b4c738917211adf2d0892a33038 to e9eddbd7dc92017f1113612dace917d562c55eaf
Branch pushed to git repo; I updated commit sha1. New commits:
e9eddbd  better size estimate for large primes

comment:108 Changed 4 years ago by
 Commit changed from e9eddbd7dc92017f1113612dace917d562c55eaf to d0ebc9bc5ba1f1f76476c9cc2c69f39f26a9e1d0
comment:109 Changed 4 years ago by
 Commit changed from d0ebc9bc5ba1f1f76476c9cc2c69f39f26a9e1d0 to 7c1bf020ef92e91440d97a3cc5a7354483ef36c0
Branch pushed to git repo; I updated commit sha1. New commits:
7c1bf02  Key has changed

comment:110 Changed 4 years ago by
 Description modified (diff)
comment:111 Changed 4 years ago by
 Commit changed from 7c1bf020ef92e91440d97a3cc5a7354483ef36c0 to a93ce9ae2b875091b6e3d3b2079835b69026525f
Branch pushed to git repo; I updated commit sha1. New commits:
a93ce9a  Some examples that came up at Sage Days 87

comment:112 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation
New commits:
a93ce9a  Some examples that came up at Sage Days 87

comment:113 Changed 4 years ago by
 Commit changed from a93ce9ae2b875091b6e3d3b2079835b69026525f to 7bc7f170e970245c65c39e379a84d099234e8c83
Branch pushed to git repo; I updated commit sha1. New commits:
709e7f6  GaussValuation is available on the global scope

a86ed5e  added introductory examples for developing valuations

f305a7f  Update inductive_valuation.py

b86ddd7  Merge branch 'sage' of github.com:saraedum/mac_lane into t/21869/a_framework_for_discrete_valuations_in_sage

7bc7f17  Improved intro sections of valuation files

comment:114 Changed 4 years ago by
 Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation to move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods
New commits:
709e7f6  GaussValuation is available on the global scope

a86ed5e  added introductory examples for developing valuations

f305a7f  Update inductive_valuation.py

b86ddd7  Merge branch 'sage' of github.com:saraedum/mac_lane into t/21869/a_framework_for_discrete_valuations_in_sage

7bc7f17  Improved intro sections of valuation files

comment:115 Changed 4 years ago by
 Commit changed from 7bc7f170e970245c65c39e379a84d099234e8c83 to 62134d89bd5b2b3f6064e6d9cf48133558bbe91f
Branch pushed to git repo; I updated commit sha1. New commits:
62134d8  move README to the reference manual

comment:116 Changed 4 years ago by
 Work issues changed from move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods to make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods
New commits:
62134d8  move README to the reference manual

comment:117 Changed 4 years ago by
 Commit changed from 62134d89bd5b2b3f6064e6d9cf48133558bbe91f to 39ee4e92895e44d022ecc9aebdf7a4aed2eabbfd
Branch pushed to git repo; I updated commit sha1. New commits:
39ee4e9  Move padic valuation factory documentation

comment:118 Changed 4 years ago by
 Work issues changed from make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods to remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods
comment:119 Changed 4 years ago by
 Work issues changed from remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods to check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods
comment:120 Changed 4 years ago by
 Work issues changed from check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods to 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods
comment:121 Changed 4 years ago by
 Work issues changed from 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods to 33 failing doctests, check generated documentation, add references to method
comment:122 Changed 4 years ago by
 Commit changed from 39ee4e92895e44d022ecc9aebdf7a4aed2eabbfd to d893c55a222ef01c0c281c7fc9032118003e8dcc
Branch pushed to git repo; I updated commit sha1. New commits:
d893c55  remove completed TODO

comment:123 Changed 4 years ago by
 Description modified (diff)
 Work issues changed from 33 failing doctests, check generated documentation, add references to method to 33 failing doctests, check generated documentation, add references to method, comments on github
New commits:
d893c55  remove completed TODO

comment:124 Changed 4 years ago by
 Description modified (diff)
Last 10 new commits:
fix typo in comment
Added a tutorial in the README
move to subdirectory for merging with sage tree
removing gitignore for merge with sage tree
Merge mac_lane infrastructure for discrete valuations into sage
remove mac_lane LICENSE
remove obsolete TODOs
remove monkey patches
move valuation code to valuation/
remove specific valuation code out of valuation/