#21869 closed enhancement (fixed)
A framework for discrete valuations in Sage
Reported by:  Julian Rüth  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  commutative algebra  Keywords:  discrete valuations, valuations, padics, function fields, number fields, smooth projective curves, Mac Lane algorithm, Montes algorithm, sd87 
Cc:  Merged in:  
Authors:  Julian Rüth  Reviewers:  GaYee Park, Stefan Wewers, David Roe, Padmavathi Srinivasan, Shiva Chidambaram 
Report Upstream:  N/A  Work issues:  
Branch:  24807e3 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642, #23965, #23966  Stopgaps: 
Description (last modified by )
Based on the sage package https://github.com/mclf/mac_lane.
Change History (309)
comment:1 Changed 6 years ago by
Description:  modified (diff) 

comment:2 Changed 6 years ago by
Description:  modified (diff) 

comment:3 Changed 6 years ago by
Description:  modified (diff) 

comment:4 Changed 6 years ago by
Description:  modified (diff) 

comment:5 Changed 6 years ago by
Description:  modified (diff) 

comment:6 Changed 6 years ago by
Description:  modified (diff) 

comment:7 Changed 6 years ago by
Description:  modified (diff) 

comment:8 Changed 6 years ago by
Description:  modified (diff) 

comment:9 Changed 6 years ago by
Description:  modified (diff) 

comment:10 Changed 6 years ago by
Description:  modified (diff) 

comment:11 Changed 5 years ago by
Description:  modified (diff) 

comment:12 Changed 5 years ago by
Description:  modified (diff) 

comment:13 Changed 5 years ago by
Description:  modified (diff) 

comment:14 Changed 5 years ago by
Description:  modified (diff) 

comment:15 Changed 5 years ago by
Description:  modified (diff) 

comment:16 Changed 5 years ago by
Description:  modified (diff) 

comment:17 Changed 5 years ago by
Description:  modified (diff) 

comment:18 Changed 5 years ago by
Description:  modified (diff) 

comment:19 Changed 5 years ago by
Description:  modified (diff) 

comment:20 Changed 5 years ago by
Description:  modified (diff) 

comment:21 Changed 5 years ago by
Description:  modified (diff) 

comment:22 Changed 5 years ago by
Description:  modified (diff) 

comment:23 Changed 5 years ago by
Description:  modified (diff) 

comment:24 Changed 5 years ago by
Description:  modified (diff) 

comment:25 Changed 5 years ago by
Description:  modified (diff) 

comment:26 Changed 5 years ago by
Description:  modified (diff) 

comment:27 Changed 5 years ago by
Branch:  → u/saraedum/a_framework_for_discrete_valuations_in_sage 

comment:28 Changed 5 years ago by
Commit:  → 0f615c771cac39a2cce4d54b4fd190f1c84992de 

Keywords:  sd87 added 
comment:29 Changed 5 years ago by
Commit:  0f615c771cac39a2cce4d54b4fd190f1c84992de → 4153ef9b3a920d079437825960d904205fc2ae53 

comment:30 Changed 5 years ago by
Commit:  4153ef9b3a920d079437825960d904205fc2ae53 → c0a81c8285b47f6fc89aa34bc125ac474c75f2e9 

Branch pushed to git repo; I updated commit sha1. New commits:
c0a81c8  fix function lookup

comment:31 Changed 5 years ago by
Description:  modified (diff) 

New commits:
c0a81c8  fix function lookup

comment:32 Changed 5 years ago by
Authors:  → Julian Rüth 

Description:  modified (diff) 
Work issues:  → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits 
comment:33 Changed 5 years ago by
Status:  new → needs_review 

comment:34 Changed 5 years ago by
Description:  modified (diff) 

comment:35 Changed 5 years ago by
Description:  modified (diff) 

comment:36 followup: 38 Changed 5 years ago by
I was reviewing gauss_valuation.py and tried reducing a polynomial using the Gauss valuation induced by the 2adic valuation, and got an unexpected error message. I thought it would tell me that the polynomial wasn't integral, and instead it gave me a coercion error.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: h 1/2*y^2 sage: v.reduce(h)  TypeError Traceback (most recent call last) <ipythoninput1084d78566b468b> in <module>() > 1 v.reduce(h) /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in reduce(self, f, check, degree_bound, coefficients, valuations) 360 361 """ > 362 f = self.domain().coerce(f) 363 364 if degree_bound is not None: /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11229)() 1166 return False 1167 > 1168 cpdef coerce(self, x): 1169 """ 1170 Return x as an element of self, if and only if there is a canonical /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11158)() 1193 except Exception: 1194 _record_exception() > 1195 raise TypeError("no canonical coercion from %s to %s" % (parent(x), self)) 1196 else: 1197 return (<map.Map>mor)._call_(x) TypeError: no canonical coercion from Univariate Polynomial Ring in y over Rational Field to Univariate Polynomial Ring in y over Integer Ring
comment:37 followup: 39 Changed 5 years ago by
equivalence_unit from gauss_valuation.py isn't outputting the results shown in the example input 2 as shown in the file.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: v.equivalence_unit(2) 4 sage: v.equivalence_unit(2)  ValueError Traceback (most recent call last) <ipythoninput12871aadb857663> in <module>() > 1 v.equivalence_unit(Integer(2)) /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller.__call__ (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc.c:1079 2)() 2036 return cache[k] 2037 except KeyError: > 2038 w = self._instance_call(*args, **kwds) 2039 cache[k] = w 2040 return w /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller._instance_call (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc. c:10238)() 1912 True 1913 """ > 1914 return self.f(self._instance, *args, **kwds) 1915 1916 cdef fix_args_kwds(self, tuple args, dict kwds): /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in equivalence_unit(self, s, reciprocal) 474 return self.equivalence_reciprocal(self.equivalence_unit(s)) 475 > 476 ret = self._base_valuation.element_with_valuation(s) 477 return self.domain()(ret) 478 /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/valuation_space.py in element_with_valuation(self, s) 465 s = QQ.coerce(s) 466 if s not in self.value_semigroup(): > 467 raise ValueError("s must be in the value semigroup of this valuation but %r is not in %r"%(s, self.value_semigroup())) 468 if s == 0: 469 return self.domain().one() ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
comment:38 Changed 5 years ago by
Thanks for reporting this. I think this is ok. The problem here is not that the polynomial is not integral but that the polynomial is not in the domain.
This works:
sage: R.<x> = QQ[] sage: v = valuations.GaussValuation(R, QQ.valuation(2)) sage: v.reduce(x + 1/2) ValueError: reduction not defined for nonintegral elements and x + 1/2 is not integral over Gauss valuation induced by 2adic valuation
This does not:
sage: R.<x> = ZZ[] sage: v = valuations.GaussValuation(R, ZZ.valuation(2)) sage: v.reduce(x + 1/2) TypeError: no canonical coercion from Univariate Polynomial Ring in x over Rational Field to Univariate Polynomial Ring in x over Integer Ring
Replying to padma_sk:
I was reviewing gauss_valuation.py and tried reducing a polynomial using the Gauss valuation induced by the 2adic valuation, and got an unexpected error message. I thought it would tell me that the polynomial wasn't integral, and instead it gave me a coercion error.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: h 1/2*y^2 sage: v.reduce(h)  TypeError Traceback (most recent call last) <ipythoninput1084d78566b468b> in <module>() > 1 v.reduce(h) /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in reduce(self, f, check, degree_bound, coefficients, valuations) 360 361 """ > 362 f = self.domain().coerce(f) 363 364 if degree_bound is not None: /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11229)() 1166 return False 1167 > 1168 cpdef coerce(self, x): 1169 """ 1170 Return x as an element of self, if and only if there is a canonical /usr/local/sage/src/sage/structure/parent.pyx in sage.structure.parent.Parent.coerce (/usr/local/sage/src/build/cythonized/sage/structure/parent.c:11158)() 1193 except Exception: 1194 _record_exception() > 1195 raise TypeError("no canonical coercion from %s to %s" % (parent(x), self)) 1196 else: 1197 return (<map.Map>mor)._call_(x) TypeError: no canonical coercion from Univariate Polynomial Ring in y over Rational Field to Univariate Polynomial Ring in y over Integer Ring
comment:39 Changed 5 years ago by
You are in the wrong domain in this example I think:
This is the error you are seeing because there is no element of valuation 2 in ZZ[x]
.
sage: R.<x> = ZZ[] sage: v = valuations.GaussValuation(R, ZZ.valuation(2)) sage: v.element_with_valuation(2) ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
However, this works in QQ[x]
.
sage: sage: R.<x> = QQ[] sage: v = valuations.GaussValuation(R, QQ.valuation(2)) sage: v.element_with_valuation(2) 1/4
Does that make sense? (Should it be documented more explicitly?)
Replying to padma_sk:
equivalence_unit from gauss_valuation.py isn't outputting the results shown in the example input 2 as shown in the file.
sage: v Gauss valuation induced by 2adic valuation sage: v.domain() Univariate Polynomial Ring in y over Integer Ring sage: v.equivalence_unit(2) 4 sage: v.equivalence_unit(2)  ValueError Traceback (most recent call last) <ipythoninput12871aadb857663> in <module>() > 1 v.equivalence_unit(Integer(2)) /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller.__call__ (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc.c:1079 2)() 2036 return cache[k] 2037 except KeyError: > 2038 w = self._instance_call(*args, **kwds) 2039 cache[k] = w 2040 return w /usr/local/sage/src/sage/misc/cachefunc.pyx in sage.misc.cachefunc.CachedMethodCaller._instance_call (/usr/local/sage/src/build/cythonized/sage/misc/cachefunc. c:10238)() 1912 True 1913 """ > 1914 return self.f(self._instance, *args, **kwds) 1915 1916 cdef fix_args_kwds(self, tuple args, dict kwds): /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/gauss_valuation.py in equivalence_unit(self, s, reciprocal) 474 return self.equivalence_reciprocal(self.equivalence_unit(s)) 475 > 476 ret = self._base_valuation.element_with_valuation(s) 477 return self.domain()(ret) 478 /projects/da1818ed996d4de6acc6361415b7725d/user/padma_sk/mac_lane/valuation_space.py in element_with_valuation(self, s) 465 s = QQ.coerce(s) 466 if s not in self.value_semigroup(): > 467 raise ValueError("s must be in the value semigroup of this valuation but %r is not in %r"%(s, self.value_semigroup())) 468 if s == 0: 469 return self.domain().one() ValueError: s must be in the value semigroup of this valuation but 2 is not in Additive Abelian Semigroup generated by 1
comment:40 Changed 5 years ago by
Description:  modified (diff) 

comment:41 Changed 5 years ago by
Dependencies:  → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996 

comment:42 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190 

comment:43 Changed 5 years ago by
Description:  modified (diff) 

comment:44 Changed 5 years ago by
Description:  modified (diff) 

comment:45 followup: 48 Changed 5 years ago by
Reviewers:  → GaYee Park 

Status:  needs_review → needs_work 
Ran the test and found the error:
sage t src/sage/rings/function_field/function_field.py # 7 doctests failed
comment:46 Changed 5 years ago by
Description:  modified (diff) 

comment:47 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics 
comment:48 Changed 5 years ago by
Replying to gpark:
Ran the test and found the error:
sage t src/sage/rings/function_field/function_field.py # 7 doctests failed
Did you run the tests with all the dependencies applied? About 50 tests fail for me. That's expected (since the dependencies are not in yet.)
comment:49 Changed 5 years ago by
Description:  modified (diff) 

Reviewers:  GaYee Park → GaYee Park, Stefan Wewers 
comment:50 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:51 Changed 5 years ago by
Description:  modified (diff) 

comment:52 Changed 5 years ago by
Description:  modified (diff) 

comment:53 Changed 5 years ago by
The following errors are expected. I am working on them.
 sage t warnlong 39.1 src/sage/rings/valuation/limit_valuation.py # 52 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/gauss_valuation.py # 1 doctest failed sage t warnlong 39.1 src/sage/rings/valuation/valuation_space.py # 2 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/mapped_valuation.py # 42 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/valuation.py # 9 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/inductive_valuation.py # 13 doctests failed sage t warnlong 39.1 src/sage/rings/valuation/augmented_valuation.py # 16 doctests failed 
comment:54 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests 

comment:55 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 

Description:  modified (diff) 
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics 
comment:56 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests 

comment:57 Changed 5 years ago by
Description:  modified (diff) 

Sorry, I somehow reverted some changes to the ticket description. Not sure how this happened.
comment:58 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 135 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests 

comment:59 Changed 5 years ago by
Description:  modified (diff) 

comment:60 Changed 5 years ago by
Description:  modified (diff) 

comment:61 Changed 5 years ago by
Description:  modified (diff) 

I have had a look at function_field_valuation
. I have already worked with the code a lot, and it is working fine, and the documentation is extensive and clear. But I have only tested the latest standalone version.
comment:62 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests 

comment:63 Changed 5 years ago by
Reviewers:  GaYee Park, Stefan Wewers → GaYee Park, Stefan Wewers, David Roe 

comment:64 Changed 5 years ago by
Commit:  c0a81c8285b47f6fc89aa34bc125ac474c75f2e9 → 9fd87332c734899d860972d836d479283b5ab62f 

Branch pushed to git repo; I updated commit sha1. New commits:
9fd8733  fix import

comment:65 Changed 5 years ago by
Commit:  9fd87332c734899d860972d836d479283b5ab62f → e1e65a5d7514ebe51365bdf1da402d2054f02654 

Branch pushed to git repo; I updated commit sha1. New commits:
e1e65a5  fixed typo

comment:66 Changed 5 years ago by
Commit:  e1e65a5d7514ebe51365bdf1da402d2054f02654 → 9c16a1bc642498daaa1c17f61a874cbd42f4063b 

Branch pushed to git repo; I updated commit sha1. New commits:
9c16a1b  undo .valuation() shortcut

comment:67 Changed 5 years ago by
Commit:  9c16a1bc642498daaa1c17f61a874cbd42f4063b → 119f2454cb4100c62300121a7df024a8b4dead9e 

Branch pushed to git repo; I updated commit sha1. New commits:
119f245  It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space

comment:68 Changed 5 years ago by
Commit:  119f2454cb4100c62300121a7df024a8b4dead9e → 7ea987498d844fb5aa28c4023cc8f4350d48a20a 

Branch pushed to git repo; I updated commit sha1. New commits:
7ea9874  fix doctests

comment:69 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 288 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests 
comment:70 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 

comment:71 Changed 5 years ago by
Commit:  7ea987498d844fb5aa28c4023cc8f4350d48a20a → 0c60cb7006afcd336963fdcc7af5cab510cd796b 

comment:72 Changed 5 years ago by
Commit:  0c60cb7006afcd336963fdcc7af5cab510cd796b → 20100145cbdac34f8f3f021f597f750541c60d11 

Branch pushed to git repo; I updated commit sha1. New commits:
2010014  restricting to ZZ, we need to know the prime

comment:73 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 36 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests 
comment:74 Changed 5 years ago by
Commit:  20100145cbdac34f8f3f021f597f750541c60d11 → efe24904ec35606462a941a47fee496ebf463491 

comment:75 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 

Description:  modified (diff) 
Reviewers:  GaYee Park, Stefan Wewers, David Roe → GaYee Park, Stefan Wewers 
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests 
New commits:
e5ef4d8  do not catch everything

9fd8733  fix import

e1e65a5  fixed typo

9c16a1b  undo .valuation() shortcut

119f245  It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space

7ea9874  fix doctests

3fd4140  add doctest output

0c60cb7  fix valuation parameters

2010014  restricting to ZZ, we need to know the prime

efe2490  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:76 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 

Description:  modified (diff) 
Reviewers:  GaYee Park, Stefan Wewers → GaYee Park, Stefan Wewers, David Roe 
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests 
Oops. Reverting.
comment:77 Changed 5 years ago by
Description:  modified (diff) 

comment:78 Changed 5 years ago by
Commit:  efe24904ec35606462a941a47fee496ebf463491 → 0fd986f1773f30ea1f89b01198892fd32c122882 

Branch pushed to git repo; I updated commit sha1. New commits:
1eace28  Update valuation_space.py

21b0f68  Update valuation_space.py

38f3815  Update valuation_space.py

7c57f68  Update valuation_space.py

d90afa8  Update valuation_space.py

1cb8178  Update valuation_space.py

39cb55b  Update valuation_space.py

a474ed5  Update valuation_space.py

ca2089f  Update valuation_space.py

0fd986f  Merge remotetracking branch 'remotes/github/sage' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:79 Changed 5 years ago by
Description:  modified (diff) 

comment:80 Changed 5 years ago by
Description:  modified (diff) 

comment:81 Changed 5 years ago by
Description:  modified (diff) 

comment:82 Changed 5 years ago by
Description:  modified (diff) 

comment:83 Changed 5 years ago by
Description:  modified (diff) 

comment:84 Changed 5 years ago by
Description:  modified (diff) 

comment:85 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? 

comment:86 Changed 5 years ago by
Description:  modified (diff) 

comment:87 Changed 5 years ago by
Description:  modified (diff) 

comment:88 Changed 5 years ago by
Description:  modified (diff) 

comment:89 Changed 5 years ago by
Description:  modified (diff) 

comment:90 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, make sure there are no more optional:integrateds 

comment:91 Changed 5 years ago by
Reviewers:  GaYee Park, Stefan Wewers, David Roe → GaYee Park, Stefan Wewers, David Roe, Padmavathi Srinivasan, Shiva Chidambaram 

Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, make sure there are no more optional:integrateds → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? 
comment:92 Changed 5 years ago by
Commit:  0fd986f1773f30ea1f89b01198892fd32c122882 → 33aa99f1aa6c8e4478cd73c1808b3e7918a29402 

Branch pushed to git repo; I updated commit sha1. New commits:
bcb78f3  Update scaled_valuation.py

be4daab  Update valuation.py

7a95a9d  Update augmented_valuation.py

dbf7791  Update augmented_valuation.py

58bb2bc  Update developing_valuation.py

e1c8bd5  Update limit_valuation.py

a0f6bd3  Update mapped_valuation.py

33aa99f  Update padic_valuation.py

comment:93 Changed 5 years ago by
Commit:  33aa99f1aa6c8e4478cd73c1808b3e7918a29402 → 37d718725faa28404b3db194cc81b9eede19c01e 

comment:94 Changed 5 years ago by
Description:  modified (diff) 

Type:  task → enhancement 
comment:95 Changed 5 years ago by
Description:  modified (diff) 

comment:96 Changed 5 years ago by
Commit:  37d718725faa28404b3db194cc81b9eede19c01e → 8da1ceb17a7bbcfbf174cdb754365d3ddca05cc0 

Branch pushed to git repo; I updated commit sha1. New commits:
8da1ceb  Clarify semigroup construction

comment:97 Changed 5 years ago by
Commit:  8da1ceb17a7bbcfbf174cdb754365d3ddca05cc0 → 07e40b964b4ab3a9f7cdf448bcd5956065fd787f 

Branch pushed to git repo; I updated commit sha1. New commits:
07e40b9  add shifting doctest

comment:98 Changed 5 years ago by
Description:  modified (diff) 

New commits:
07e40b9  add shifting doctest

comment:99 Changed 5 years ago by
Commit:  07e40b964b4ab3a9f7cdf448bcd5956065fd787f → 021b188797aa024ae6f17f4954f679eabcaed5c3 

Branch pushed to git repo; I updated commit sha1. New commits:
021b188  improve error message

comment:100 Changed 5 years ago by
Commit:  021b188797aa024ae6f17f4954f679eabcaed5c3 → a6a798f9e713f7237e81eea92cdaca9bc455eda3 

Branch pushed to git repo; I updated commit sha1. New commits:
a6a798f  Clarified the notion of minimality

comment:101 Changed 5 years ago by
Commit:  a6a798f9e713f7237e81eea92cdaca9bc455eda3 → ee0db3141cb365e8e7cdf89ec568b3b493a179e9 

Branch pushed to git repo; I updated commit sha1. New commits:
ee0db31  clarify meaning of effective_degree

comment:102 Changed 5 years ago by
Commit:  ee0db3141cb365e8e7cdf89ec568b3b493a179e9 → e9243b8ea32bdaba2694bc77071b3ee41b7355ce 

Branch pushed to git repo; I updated commit sha1. New commits:
e9243b8  bring residue into the right residue ring

comment:103 Changed 5 years ago by
Commit:  e9243b8ea32bdaba2694bc77071b3ee41b7355ce → 24e68ecc6536c18d63d77d7f56ae4cb27a98ae10 

Branch pushed to git repo; I updated commit sha1. New commits:
24e68ec  add to/from residue ring tests

comment:104 Changed 5 years ago by
Commit:  24e68ecc6536c18d63d77d7f56ae4cb27a98ae10 → 2bed311a203da9a773b4cefe0bc3c6b5c038394b 

comment:105 Changed 5 years ago by
Commit:  2bed311a203da9a773b4cefe0bc3c6b5c038394b → 544977a3161e2f86d1e924b7403fd9709c77620a 

comment:106 Changed 5 years ago by
Commit:  544977a3161e2f86d1e924b7403fd9709c77620a → a0880bd55bb78b4c738917211adf2d0892a33038 

Branch pushed to git repo; I updated commit sha1. New commits:
a0880bd  Fix bug in padic shift

comment:107 Changed 5 years ago by
Commit:  a0880bd55bb78b4c738917211adf2d0892a33038 → e9eddbd7dc92017f1113612dace917d562c55eaf 

Branch pushed to git repo; I updated commit sha1. New commits:
e9eddbd  better size estimate for large primes

comment:108 Changed 5 years ago by
Commit:  e9eddbd7dc92017f1113612dace917d562c55eaf → d0ebc9bc5ba1f1f76476c9cc2c69f39f26a9e1d0 

comment:109 Changed 5 years ago by
Commit:  d0ebc9bc5ba1f1f76476c9cc2c69f39f26a9e1d0 → 7c1bf020ef92e91440d97a3cc5a7354483ef36c0 

Branch pushed to git repo; I updated commit sha1. New commits:
7c1bf02  Key has changed

comment:110 Changed 5 years ago by
Description:  modified (diff) 

comment:111 Changed 5 years ago by
Commit:  7c1bf020ef92e91440d97a3cc5a7354483ef36c0 → a93ce9ae2b875091b6e3d3b2079835b69026525f 

Branch pushed to git repo; I updated commit sha1. New commits:
a93ce9a  Some examples that came up at Sage Days 87

comment:112 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism? → move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation 

New commits:
a93ce9a  Some examples that came up at Sage Days 87

comment:113 Changed 5 years ago by
Commit:  a93ce9ae2b875091b6e3d3b2079835b69026525f → 7bc7f170e970245c65c39e379a84d099234e8c83 

Branch pushed to git repo; I updated commit sha1. New commits:
709e7f6  GaussValuation is available on the global scope

a86ed5e  added introductory examples for developing valuations

f305a7f  Update inductive_valuation.py

b86ddd7  Merge branch 'sage' of github.com:saraedum/mac_lane into t/21869/a_framework_for_discrete_valuations_in_sage

7bc7f17  Improved intro sections of valuation files

comment:114 Changed 5 years ago by
Work issues:  move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation → move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods 

New commits:
709e7f6  GaussValuation is available on the global scope

a86ed5e  added introductory examples for developing valuations

f305a7f  Update inductive_valuation.py

b86ddd7  Merge branch 'sage' of github.com:saraedum/mac_lane into t/21869/a_framework_for_discrete_valuations_in_sage

7bc7f17  Improved intro sections of valuation files

comment:115 Changed 5 years ago by
Commit:  7bc7f170e970245c65c39e379a84d099234e8c83 → 62134d89bd5b2b3f6064e6d9cf48133558bbe91f 

Branch pushed to git repo; I updated commit sha1. New commits:
62134d8  move README to the reference manual

comment:116 Changed 5 years ago by
Work issues:  move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods → make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods 

New commits:
62134d8  move README to the reference manual

comment:117 Changed 5 years ago by
Commit:  62134d89bd5b2b3f6064e6d9cf48133558bbe91f → 39ee4e92895e44d022ecc9aebdf7a4aed2eabbfd 

Branch pushed to git repo; I updated commit sha1. New commits:
39ee4e9  Move padic valuation factory documentation

comment:118 Changed 5 years ago by
Work issues:  make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods → remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods 

comment:119 Changed 5 years ago by
Work issues:  remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods → check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods 

comment:120 Changed 5 years ago by
Work issues:  check that discrete_value_group is still available the same way it was under padics, 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods → 33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods 

comment:121 Changed 5 years ago by
Work issues:  33 failing doctests, is anything inheriting from Map/DefaultConvertMap instead of Morphism?, check generated documentation, add references to methods → 33 failing doctests, check generated documentation, add references to method 

comment:122 Changed 5 years ago by
Commit:  39ee4e92895e44d022ecc9aebdf7a4aed2eabbfd → d893c55a222ef01c0c281c7fc9032118003e8dcc 

Branch pushed to git repo; I updated commit sha1. New commits:
d893c55  remove completed TODO

comment:123 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  33 failing doctests, check generated documentation, add references to method → 33 failing doctests, check generated documentation, add references to method, comments on github 
New commits:
d893c55  remove completed TODO

comment:124 Changed 5 years ago by
Description:  modified (diff) 

comment:125 Changed 5 years ago by
Description:  modified (diff) 

comment:126 Changed 5 years ago by
Commit:  d893c55a222ef01c0c281c7fc9032118003e8dcc → e318075c0420a9225010a4b57c66e68d9c052567 

Branch pushed to git repo; I updated commit sha1. New commits:
e318075  value_group has moved

comment:127 Changed 5 years ago by
Commit:  e318075c0420a9225010a4b57c66e68d9c052567 → a2d10913245fc598684fe178f3eaf74bac5e5b2e 

Branch pushed to git repo; I updated commit sha1. New commits:
a2d1091  fix toctree formatting

comment:128 Changed 5 years ago by
Commit:  a2d10913245fc598684fe178f3eaf74bac5e5b2e → 9b0280042e3e1266bce9c4dee0e92ec207d0205f 

Branch pushed to git repo; I updated commit sha1. New commits:
9b02800  fix docbuild

comment:129 Changed 5 years ago by
Commit:  9b0280042e3e1266bce9c4dee0e92ec207d0205f → 735cd8d901ea93cf7e7d2613e16f9f0514967ec4 

Branch pushed to git repo; I updated commit sha1. New commits:
735cd8d  fix typo

comment:130 Changed 5 years ago by
Commit:  735cd8d901ea93cf7e7d2613e16f9f0514967ec4 → 04dd3954fc4969dab2049e689453ddb606a5419e 

Branch pushed to git repo; I updated commit sha1. New commits:
04dd395  fix reference link

comment:131 Changed 5 years ago by
Commit:  04dd3954fc4969dab2049e689453ddb606a5419e → 36f33e6cbd3d8535f8c1da12af0e9f549df8f602 

comment:132 Changed 5 years ago by
Commit:  36f33e6cbd3d8535f8c1da12af0e9f549df8f602 → 4630b93916bf0c5277c63eef537019e6ce3c28fe 

comment:133 Changed 5 years ago by
Commit:  4630b93916bf0c5277c63eef537019e6ce3c28fe → cc9607fbf5d5e836a20f97117991886d3d27aab1 

Branch pushed to git repo; I updated commit sha1. New commits:
cc9607f  fix docbuild

comment:134 Changed 5 years ago by
Commit:  cc9607fbf5d5e836a20f97117991886d3d27aab1 → 2b767b709f4cf5e11e4d1bdf946e726a0e5865df 

Branch pushed to git repo; I updated commit sha1. New commits:
2b767b7  fix reference key

comment:135 Changed 5 years ago by
Commit:  2b767b709f4cf5e11e4d1bdf946e726a0e5865df → cdf89aef1bf3a1b6f7c98a650ce8669dd6c1becb 

Branch pushed to git repo; I updated commit sha1. New commits:
cdf89ae  renamed reference manual section

comment:136 Changed 5 years ago by
Description:  modified (diff) 

comment:137 Changed 5 years ago by
Commit:  cdf89aef1bf3a1b6f7c98a650ce8669dd6c1becb → c011093d3b22d3826a51c28f48bf81cef79063fd 

Branch pushed to git repo; I updated commit sha1. New commits:
c011093  reformat headers for reference manual

comment:138 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  33 failing doctests, check generated documentation, add references to method, comments on github → 121 failing doctests, check generated documentation, add references to method, comments on github 
New commits:
c011093  reformat headers for reference manual

comment:139 Changed 5 years ago by
Commit:  c011093d3b22d3826a51c28f48bf81cef79063fd → 8022ed196995b2e7b1bc93c9dcd5f0d93fd3bfd4 

Branch pushed to git repo; I updated commit sha1. New commits:
8022ed1  fix docbuild

comment:140 Changed 5 years ago by
Commit:  8022ed196995b2e7b1bc93c9dcd5f0d93fd3bfd4 → 14e034e46f0834f42f0ddd84f74a8b2814dbe809 

Branch pushed to git repo; I updated commit sha1. New commits:
14e034e  fix value_group documentation

comment:141 Changed 5 years ago by
Commit:  14e034e46f0834f42f0ddd84f74a8b2814dbe809 → 3bff1b961ca0104b5cb70415b2100bd4c83d1ae8 

Branch pushed to git repo; I updated commit sha1. New commits:
3bff1b9  fix documentation in valuation

comment:142 Changed 5 years ago by
Commit:  3bff1b961ca0104b5cb70415b2100bd4c83d1ae8 → 7db0f057258c627ac6e648cebd67536569500cd6 

comment:143 Changed 5 years ago by
Commit:  7db0f057258c627ac6e648cebd67536569500cd6 → 2f6dd581cc8768f4cfa467629df2fe50773758b2 

Branch pushed to git repo; I updated commit sha1. New commits:
2f6dd58  fix MacLane references

comment:144 Changed 5 years ago by
Commit:  2f6dd581cc8768f4cfa467629df2fe50773758b2 → 007499ebc0532f8c9fb63767d359b9dcbf582cac 

comment:145 Changed 5 years ago by
Commit:  007499ebc0532f8c9fb63767d359b9dcbf582cac → a105a8f43dc3bce318bb373d9fccf0a0ec34948b 

Branch pushed to git repo; I updated commit sha1. New commits:
a105a8f  fixed links in documentation

comment:146 Changed 5 years ago by
Commit:  a105a8f43dc3bce318bb373d9fccf0a0ec34948b → 3b91735e9718a4b000a627a451ddc6aedef61ac2 

Branch pushed to git repo; I updated commit sha1. New commits:
3b91735  fixing links in developing valuation

comment:147 Changed 5 years ago by
Commit:  3b91735e9718a4b000a627a451ddc6aedef61ac2 → ee5abb213abfaa78d2ebe82f839c5fe312b54146 

Branch pushed to git repo; I updated commit sha1. New commits:
ee5abb2  Fix links in developing valuation

comment:148 Changed 5 years ago by
Commit:  ee5abb213abfaa78d2ebe82f839c5fe312b54146 → 548e879415fb1a128531f4961f51cc9e88a3e313 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
51e89db  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

0f66745  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

984cc75  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

35b62e6  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

c50f6ec  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

93757ef  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

5c62063  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

f173caf  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

013292f  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

548e879  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:149 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  121 failing doctests, check generated documentation, add references to method, comments on github → 121 failing doctests, check generated documentation, add references to method, comments on github, check docbuild output for broken links 
comment:150 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  121 failing doctests, check generated documentation, add references to method, comments on github, check docbuild output for broken links → 121 failing doctests, comments on github, check docbuild output for broken links 
comment:151 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  121 failing doctests, comments on github, check docbuild output for broken links → 120 failing doctests, comments on github, check docbuild output for broken links 
comment:152 Changed 5 years ago by
Commit:  548e879415fb1a128531f4961f51cc9e88a3e313 → 2ca7a7c934463219690fd31d5ff4f4c3ee341c31 

Branch pushed to git repo; I updated commit sha1. New commits:
6da7536  fix broken documentation links

6aa9f65  Fixed documentation

d27262a  Fix _richcmp_

6509f94  Merge remotetracking branch 'trac/u/saraedum/23190' into t/21869/a_framework_for_discrete_valuations_in_sage

fb66f9f  Fix richcmp

e3fb631  Merge branch 'u/saraedum/a_polynomial_ring_embeds_into_its_fraction_field' of git://trac.sagemath.org/sage into t/23185/a_polynomial_ring_embeds_into_its_fraction_field

f3ecd0e  added missing doctest

5093894  Merge remotetracking branch 'trac/u/saraedum/a_polynomial_ring_embeds_into_its_fraction_field' into t/21869/a_framework_for_discrete_valuations_in_sage

2ca7a7c  fix pickling of valuations

comment:153 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  120 failing doctests, comments on github, check docbuild output for broken links → 67 failing doctests, comments on github, check docbuild output for broken links 
New commits:
6da7536  fix broken documentation links

6aa9f65  Fixed documentation

d27262a  Fix _richcmp_

6509f94  Merge remotetracking branch 'trac/u/saraedum/23190' into t/21869/a_framework_for_discrete_valuations_in_sage

fb66f9f  Fix richcmp

e3fb631  Merge branch 'u/saraedum/a_polynomial_ring_embeds_into_its_fraction_field' of git://trac.sagemath.org/sage into t/23185/a_polynomial_ring_embeds_into_its_fraction_field

f3ecd0e  added missing doctest

5093894  Merge remotetracking branch 'trac/u/saraedum/a_polynomial_ring_embeds_into_its_fraction_field' into t/21869/a_framework_for_discrete_valuations_in_sage

2ca7a7c  fix pickling of valuations

comment:154 Changed 5 years ago by
Commit:  2ca7a7c934463219690fd31d5ff4f4c3ee341c31 → 45e0e8f7cb9b0b6b8aaa1d3af8e4c4a761fb0cca 

comment:155 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  67 failing doctests, comments on github, check docbuild output for broken links → 53 failing doctests, comments on github, check docbuild output for broken links 
comment:156 Changed 5 years ago by
Commit:  45e0e8f7cb9b0b6b8aaa1d3af8e4c4a761fb0cca → 6de28680e68ec96f826efca092dc39b8e032158c 

comment:157 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  53 failing doctests, comments on github, check docbuild output for broken links → 46 failing doctests, comments on github, check docbuild output for broken links 
comment:158 Changed 5 years ago by
Commit:  6de28680e68ec96f826efca092dc39b8e032158c → 249bdc0743c0c79ffd6cec510db0d9c7bbec49e2 

comment:159 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  46 failing doctests, comments on github, check docbuild output for broken links → 36 failing doctests, comments on github, check docbuild output for broken links 
comment:160 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510 

comment:161 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525 

comment:162 Changed 5 years ago by
Commit:  249bdc0743c0c79ffd6cec510db0d9c7bbec49e2 → 005e7ab0f7740c533e13de1c5f9555cf1575fb72 

Branch pushed to git repo; I updated commit sha1. New commits:
a92f47f  make sure that arguments to add_bigoh are correctly normalized

aa1709d  comment on stagnating degrees

005e7ab  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:163 Changed 5 years ago by
Commit:  005e7ab0f7740c533e13de1c5f9555cf1575fb72 → 2d1cb90b3deffd9210a9d6366cdf8666c38acbdc 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
bd15d71  add exact keyword

99dccf6  Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision

ef4ed33  Fix SEEALSO:

1754b44  Fix exact=True errors in the right branch

7926b41  Moving code for fraction_field and integer_ring, and enabling fraction fields for fixedmod

7712a86  Merge remotetracking branch 'trac/u/roed/fixed_mod_frac_field' into t/21869/a_framework_for_discrete_valuations_in_sage

276e4f7  fix and fill in doctest output

9b03cf8  compute fraction field only when necessary

a886c42  fix pickling of nodes

2d1cb90  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:164 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  36 failing doctests, comments on github, check docbuild output for broken links → 7 failing doctests, check docbuild output for broken links 
Last 10 new commits:
1754b44  Fix exact=True errors in the right branch

7926b41  Moving code for fraction_field and integer_ring, and enabling fraction fields for fixedmod

7712a86  Merge remotetracking branch 'trac/u/roed/fixed_mod_frac_field' into t/21869/a_framework_for_discrete_valuations_in_sage

276e4f7  fix and fill in doctest output

9b03cf8  compute fraction field only when necessary

a886c42  fix pickling of nodes

a92f47f  make sure that arguments to add_bigoh are correctly normalized

aa1709d  comment on stagnating degrees

005e7ab  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

2d1cb90  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:165 Changed 5 years ago by
Commit:  2d1cb90b3deffd9210a9d6366cdf8666c38acbdc → 282c95ea845009b91e5db57e9b6f76de562f64ab 

Branch pushed to git repo; I updated commit sha1. New commits:
282c95e  Remove "not slopes"

comment:166 Changed 5 years ago by
Work issues:  7 failing doctests, check docbuild output for broken links → 7 failing doctests, check docbuild output for broken links, check _richcmp_ implementations 

comment:168 Changed 5 years ago by
Commit:  282c95ea845009b91e5db57e9b6f76de562f64ab → ad9adb1ab69e0bec23ce6a87a4f6f106e85b78f1 

comment:169 Changed 5 years ago by
Commit:  ad9adb1ab69e0bec23ce6a87a4f6f106e85b78f1 → 7660eab0134f488f18572d2b4a2a856d43641f33 

Branch pushed to git repo; I updated commit sha1. New commits:
28fbf35  Check that extensions are computed correctly in towers of number fields

101502e  Merge branch 'develop' into t/21869/a_framework_for_discrete_valuations_in_sage

1221125  remove TABs

7660eab  Mapped valuations should know whether they are discrete

comment:170 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620 

comment:171 Changed 5 years ago by
Commit:  7660eab0134f488f18572d2b4a2a856d43641f33 → 51f7ed09ea118b0d05c6bc124c159b321c89a90c 

comment:172 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642 

comment:173 Changed 5 years ago by
Commit:  51f7ed09ea118b0d05c6bc124c159b321c89a90c → 7c915f1213eb08f9b5bb487b2d21b1755ff2fff4 

Branch pushed to git repo; I updated commit sha1. New commits:
7c915f1  Merge branch 'develop' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:174 Changed 5 years ago by
Status:  needs_review → needs_work 

comment:175 Changed 5 years ago by
Commit:  7c915f1213eb08f9b5bb487b2d21b1755ff2fff4 → 29feccb3d72a85cd739d09faa621d4690798ad7d 

Branch pushed to git repo; I updated commit sha1. New commits:
82338dc  Fix factorization over fraction fields that are isomorphic to function fields

64e6546  Merge branch 'develop' into t/23642/factorization_over_some_quotient_rings_incorrect

f6dd0cd  Better isomorphisms between fraction fields and function fields

38f18b8  minor docstring change

8bfe326  Merge branch 'develop' into t/23660/better_isomorphisms_between_function_fields_and_fraction_fields

746eac0  fix docstring

4bddab1  Merge branch 't/23660/better_isomorphisms_between_function_fields_and_fraction_fields' into t/23642/factorization_over_some_quotient_rings_incorrect

29feccb  Merge branch 't/23642/factorization_over_some_quotient_rings_incorrect' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:176 Changed 5 years ago by
Commit:  29feccb3d72a85cd739d09faa621d4690798ad7d → b3c8ac3730edd5b5977fbaa93c1cca1096df6dda 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7e62f70  Fixing errors in the coercion to the fraction field for fixedmod padics

1a4333a  Merge branch 't/13591/add_bigoh' into t/23510/fixed_mod_frac_field

cdeb376  Merge branch 't/13591/add_bigoh' into t/23510/fixed_mod_frac_field

cb882fd  Update add_bigoh to account for fixedmod having a fraction field

a826978  Fix _tester_add_bigoh

883e6b5  Fix doctest in local_generic_element.pyx

52cbd2a  Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field

bc59ffa  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field

3292259  Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field

b3c8ac3  Merge branch 't/23510/fixed_mod_frac_field' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:177 Changed 5 years ago by
Commit:  b3c8ac3730edd5b5977fbaa93c1cca1096df6dda → 608c5c3dda3ae4560bc0e88eeb440233ab5aa4bc 

Branch pushed to git repo; I updated commit sha1. New commits:
608c5c3  Use names for richcmp operators

comment:178 Changed 5 years ago by
Work issues:  7 failing doctests, check docbuild output for broken links, check _richcmp_ implementations → 7 failing doctests, check docbuild output for broken links 

David: I made a trivial change. I don't think it needs review.
comment:180 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  7 failing doctests, check docbuild output for broken links → 25 failing doctests, check docbuild output for broken links 
comment:181 Changed 5 years ago by
Commit:  608c5c3dda3ae4560bc0e88eeb440233ab5aa4bc → a63c1ffa21e57a3db4866793fee42740e01f0fbf 

Branch pushed to git repo; I updated commit sha1. New commits:
b81b722  Remove use of depraceted list()

2904b76  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/21869/a_framework_for_discrete_valuations_in_sage

5739955  Base change factorization to the right parent

c17adf7  Merge branch 'u/saraedum/factorization_over_some_quotient_rings_incorrect' of git://trac.sagemath.org/sage into t/23642/factorization_over_some_quotient_rings_incorrect

a63c1ff  Merge branch 't/23642/factorization_over_some_quotient_rings_incorrect' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:182 Changed 5 years ago by
Commit:  a63c1ffa21e57a3db4866793fee42740e01f0fbf → 226518c0b8e1b01e9f047cb42d5420556d01f7e6 

Branch pushed to git repo; I updated commit sha1. New commits:
28b36f8  Fix ScaleAction

b6c62d0  Fix doctests

99b3ab2  Merge branch 't/23642/factorization_over_some_quotient_rings_incorrect' into t/21869/a_framework_for_discrete_valuations_in_sage

dad02c7  Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field

189ac2b  Add _test_fraction_field to the coercion tutorial

9ecff79  Merge branch 't/23510/fixed_mod_frac_field' into t/21869/a_framework_for_discrete_valuations_in_sage

226518c  Merge remotetracking branch 'trac/develop' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:183 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  25 failing doctests, check docbuild output for broken links → 17 failing doctests, check docbuild output for broken links 
comment:184 Changed 5 years ago by
Commit:  226518c0b8e1b01e9f047cb42d5420556d01f7e6 → 271f6ec79d1dd5e700816a0a43dd3ed3751ecf92 

Branch pushed to git repo; I updated commit sha1. New commits:
271f6ec  Use a more specialized class for nonclassical discrete valuations on function fields

comment:185 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  17 failing doctests, check docbuild output for broken links → 16 failing doctests, check docbuild output for broken links 
New commits:
271f6ec  Use a more specialized class for nonclassical discrete valuations on function fields

comment:186 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  16 failing doctests, check docbuild output for broken links → 10 failing doctests, check docbuild output for broken links 
comment:187 Changed 5 years ago by
Commit:  271f6ec79d1dd5e700816a0a43dd3ed3751ecf92 → 20868e9de4fbaa180a0581f1552c02e199ee4b49 

comment:188 Changed 5 years ago by
Work issues:  10 failing doctests, check docbuild output for broken links → 9 failing doctests, check docbuild output for broken links 

comment:189 Changed 5 years ago by
Description:  modified (diff) 

comment:190 Changed 5 years ago by
Commit:  20868e9de4fbaa180a0581f1552c02e199ee4b49 → 27351d9440667c18e64c5baa7e26c26e24e07918 

Branch pushed to git repo; I updated commit sha1. New commits:
27351d9  Bring back equivalence_decompositions into local rings

comment:191 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  9 failing doctests, check docbuild output for broken links → 8 failing doctests, check docbuild output for broken links 
New commits:
27351d9  Bring back equivalence_decompositions into local rings

comment:192 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642, #23965 

comment:193 Changed 5 years ago by
Commit:  27351d9440667c18e64c5baa7e26c26e24e07918 → 76df6901142e9484c6969d3b4d5afeed81482982 

comment:194 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  8 failing doctests, check docbuild output for broken links → 7 failing doctests, check docbuild output for broken links 
New commits:
55b33e4  Coercions to the fraction field are injective

ac081b0  Merge branch 't/23965/coercion_to_fraction_field_is_injective' into t/21869/a_framework_for_discrete_valuations_in_sage

76df690  Fill in doctest output

New commits:
55b33e4  Coercions to the fraction field are injective

ac081b0  Merge branch 't/23965/coercion_to_fraction_field_is_injective' into t/21869/a_framework_for_discrete_valuations_in_sage

76df690  Fill in doctest output

comment:195 Changed 5 years ago by
Dependencies:  #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642, #23965 → #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525, #23620, #23642, #23965, #23966 

comment:196 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  7 failing doctests, check docbuild output for broken links → 6 failing doctests, check docbuild output for broken links 
comment:197 Changed 5 years ago by
Commit:  76df6901142e9484c6969d3b4d5afeed81482982 → c7ac63228cc88d0e03b4cc87ed89bb5db8a16344 

comment:198 Changed 5 years ago by
Commit:  c7ac63228cc88d0e03b4cc87ed89bb5db8a16344 → d9b94870dad0e5079a6eef07533af6514cdc0ca4 

comment:199 Changed 5 years ago by
Commit:  d9b94870dad0e5079a6eef07533af6514cdc0ca4 → 6c5c12b4e18253522eb6ea52f106f7601de27b0e 

Branch pushed to git repo; I updated commit sha1. New commits:
6c5c12b  fill in doctest output

comment:200 Changed 5 years ago by
Commit:  6c5c12b4e18253522eb6ea52f106f7601de27b0e → 41277b3f9070fe51be20cdc05f15f4c852e12205 

Branch pushed to git repo; I updated commit sha1. New commits:
41277b3  Fix factorization doctests

comment:201 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  6 failing doctests, check docbuild output for broken links → 1 failing doctest, check docbuild output for broken links 
comment:202 Changed 5 years ago by
Commit:  41277b3f9070fe51be20cdc05f15f4c852e12205 → 09b64022a765aa6116f10aaf846f410a074d4821 

Branch pushed to git repo; I updated commit sha1. New commits:
09b6402  stable factorization output

comment:203 Changed 5 years ago by
Commit:  09b64022a765aa6116f10aaf846f410a074d4821 → dfad6f47d2e8edf2e7cb694f29cc0c4316a4dc1c 

Branch pushed to git repo; I updated commit sha1. New commits:
dfad6f4  Fix valuation.lift(report_coefficients=True)

comment:204 Changed 5 years ago by
Description:  modified (diff) 

Status:  needs_work → needs_review 
Work issues:  1 failing doctest, check docbuild output for broken links → check docbuild output for broken links 
comment:205 Changed 5 years ago by
Commit:  dfad6f47d2e8edf2e7cb694f29cc0c4316a4dc1c → 8767fdc5d81f83172e6daac6fd1aa143fa7cb41c 

Branch pushed to git repo; I updated commit sha1. New commits:
8767fdc  fix docbuild

comment:206 Changed 5 years ago by
Commit:  8767fdc5d81f83172e6daac6fd1aa143fa7cb41c → ecfe1bc9d6b021d0066269a9c21d7022e9e28e97 

Branch pushed to git repo; I updated commit sha1. New commits:
ecfe1bc  fix doc references

comment:207 Changed 5 years ago by
Work issues:  check docbuild output for broken links 

comment:208 Changed 5 years ago by
Commit:  ecfe1bc9d6b021d0066269a9c21d7022e9e28e97 → 775e093eb3076c1ebf44bd2867340605700c2a35 

Branch pushed to git repo; I updated commit sha1. New commits:
775e093  Remove Python2 code from valuations

comment:209 Changed 5 years ago by
Description:  modified (diff) 

Status:  needs_review → needs_work 
Work issues:  → 55 failing long doctests 
New commits:
775e093  Remove Python2 code from valuations

comment:210 Changed 5 years ago by
Description:  modified (diff) 

comment:211 Changed 5 years ago by
Commit:  775e093eb3076c1ebf44bd2867340605700c2a35 → 5a555ada7232c5a9ea28f073b8f6d0f26024de83 

comment:212 Changed 5 years ago by
Commit:  5a555ada7232c5a9ea28f073b8f6d0f26024de83 → 46b8c2ea13cf0e0d1288076b2d6345c71d812ab4 

Branch pushed to git repo; I updated commit sha1. New commits:
46b8c2e  Fix _test_inverse handling of NotImplementedError

comment:213 Changed 5 years ago by
Description:  modified (diff) 

Work issues:  55 failing long doctests → 8 failing long doctests 
comment:214 Changed 5 years ago by
Commit:  46b8c2ea13cf0e0d1288076b2d6345c71d812ab4 → 716d66bd30adab7b25fb85a5dfa3e78014b243b2 

comment:215 Changed 5 years ago by
Status:  needs_work → needs_review 

Work issues:  8 failing long doctests 
comment:216 Changed 5 years ago by
Commit:  716d66bd30adab7b25fb85a5dfa3e78014b243b2 → 5578cae3051b2637aa31b06a28958b8a5d739a14 

comment:217 Changed 5 years ago by
Description:  modified (diff) 

comment:218 followup: 227 Changed 5 years ago by
In _test_shift
in valuation_space.py
, you're not actually doing tests, just having lines with boolean statements.
comment:219 followup: 228 Changed 5 years ago by
In index.rst
there are some \QQ
s that should probably be \Q
s. Have you tried building the documentation recently? I'm surprised this didn't cause problems....
Is there a place I can look at the generated documentation online? It might be easier to catch some kinds of problems there.
comment:220 followup: 229 Changed 5 years ago by
In function_field.py
there's a typo in We create a valuation that correspond
(should be plural).
comment:221 followup: 231 Changed 5 years ago by
In padic_valuation.py
you have self.domain()(~ZpFM(self.p(), ZZ(precision).ceil())(x))
. This is probably better done with the inverse_mod
method in integers, since then you don't have to construct a new parent. Also, if precision isn't integral, won't ZZ(precision)
fail before you can call ceil()
on it?
comment:222 followup: 232 Changed 5 years ago by
There are a few really long lines. I don't really mind them, but they might be worth thinking about breaking up. For example,
return self.domain().change_ring(self.domain())([0 if valuations[i] > error else self._base_valuation.simplify(c, error=errori*self._mu, force=force, phiadic=True) for (i,c) in enumerate(coefficients)])(self.phi())
comment:223 followup: 233 Changed 5 years ago by
In the montes_factorization
tests, why do you specify required precision be 0? Runtime? Feasibility of printing the result?
comment:224 followup: 234 Changed 5 years ago by
You should probably not delete 'reference/tensor_free_modules'
from sage_setup/docbuild/__init__.py
.
comment:225 followup: 235 Changed 5 years ago by
In index.rst
, where you do say random output (order may vary)
, why not just use sorted
?
comment:227 Changed 5 years ago by
Replying to roed:
In
_test_shift
invaluation_space.py
, you're not actually doing tests, just having lines with boolean statements.
Yes, fixed.
comment:228 Changed 5 years ago by
Replying to roed:
In
index.rst
there are some\Q
s. Have you tried building the documentation recently? I'm surprised this didn't cause problems....
It did not seem to cause problems. But I changed it anyway.
Is there a place I can look at the generated documentation online? It might be easier to catch some kinds of problems there.
https://drugtestbots.info.tm/reference/valuations/index.html (still uploading)
comment:229 Changed 5 years ago by
Replying to roed:
In
function_field.py
there's a typo inWe create a valuation that correspond
(should be plural).
Ok. Fixed
comment:230 Changed 5 years ago by
Commit:  5578cae3051b2637aa31b06a28958b8a5d739a14 → 159491957d15df472d93f9b4505d237fbb2d43c7 

comment:231 Changed 5 years ago by
Replying to roed:
In
padic_valuation.py
you haveself.domain()(~ZpFM(self.p(), ZZ(precision).ceil())(x))
. This is probably better done with theinverse_mod
method in integers, since then you don't have to construct a new parent. Also, if precision isn't integral, won'tZZ(precision)
fail before you can callceil()
on it?
Thanks, all fixed.
New commits:
175d9e1  fix LaTeX errors in reference manual

0e9fa0c  fix grammar in docstring

3afa634  Fix handling of rationals in inverse()

b457126  comment on required_precision=0

6b1f708  assert something in _test_shift

1594919  Fix _test_shift()

New commits:
175d9e1  fix LaTeX errors in reference manual

0e9fa0c  fix grammar in docstring

3afa634  Fix handling of rationals in inverse()

b457126  comment on required_precision=0

6b1f708  assert something in _test_shift

1594919  Fix _test_shift()

comment:232 Changed 5 years ago by
Replying to roed:
There are a few really long lines. I don't really mind them, but they might be worth thinking about breaking up. For example,
return self.domain().change_ring(self.domain())([0 if valuations[i] > error else self._base_valuation.simplify(c, error=errori*self._mu, force=force, phiadic=True) for (i,c) in enumerate(coefficients)])(self.phi())
I tried to fix some of these.
comment:233 Changed 5 years ago by
Replying to roed:
In the
montes_factorization
tests, why do you specify required precision be 0? Runtime? Feasibility of printing the result?
Because of speed. It finds an exact factorization without which takes forever (I did not wait for it to terminate) as it is very slowly improving the quality of the approximation. I added a comment.
comment:234 followup: 238 Changed 5 years ago by
Replying to roed:
You should probably not delete
'reference/tensor_free_modules'
fromsage_setup/docbuild/__init__.py
.
Why not? It used to be the last item in this list, now valuations has taken its spot.
comment:235 Changed 5 years ago by
Replying to roed:
In
index.rst
, where you do sayrandom output (order may vary)
, why not just usesorted
?
Because I want this to be a readable introduction. I think that sorting would make it much more cryptic to people who are not so fluent in python.
comment:237 Changed 5 years ago by
Commit:  159491957d15df472d93f9b4505d237fbb2d43c7 → 20d3ad9f62502bb77b54d3b468128ba1f2ff8269 

Branch pushed to git repo; I updated commit sha1. New commits:
20d3ad9  broke some long lines

comment:238 Changed 5 years ago by
comment:239 Changed 5 years ago by
Branch:  u/saraedum/a_framework_for_discrete_valuations_in_sage → u/roed/a_framework_for_discrete_valuations_in_sage 

comment:240 Changed 5 years ago by
Commit:  20d3ad9f62502bb77b54d3b468128ba1f2ff8269 → 3c0dd8ff18284135983926f7c73db688a6dd4c1d 

Status:  needs_review → positive_review 
I just merged in the last few dependencies and changed some whitespace in valuation_space.py
. Looks good to me!
New commits:
3447e80  Changing whitespace

a323641  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/discval

df62c48  Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23965/fracfield_coercion_injective

a4d9ad6  Catch exceptions raised by attempting to find fraction field

bd7d54e  Merge branch 't/23965/fracfield_coercion_injective' into t/21869/discval

98d8256  Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into develop

b8de189  Different fix for 23966, add doctest

3c0dd8f  Merge branch 't/23966/ZpFM_to_fracfield' into t/21869/discval

comment:241 Changed 5 years ago by
Do not implement both _cmp_
and _richcmp_
. The second one only please.
comment:242 Changed 5 years ago by
Branch:  u/roed/a_framework_for_discrete_valuations_in_sage → u/saraedum/a_framework_for_discrete_valuations_in_sage 

comment:243 Changed 5 years ago by
Commit:  3c0dd8ff18284135983926f7c73db688a6dd4c1d → bb86ca0fd179a17464c240ff703827355b1b2d27 

comment:245 Changed 5 years ago by
Work issues:  → PDF documentation does not build 

I can not build PDF docs locally (not sure why but it's not related to this ticket.) Can someone else try to fix this?
comment:247 Changed 5 years ago by
Branch:  u/saraedum/a_framework_for_discrete_valuations_in_sage → u/roed/a_framework_for_discrete_valuations_in_sage 

comment:248 Changed 5 years ago by
Commit:  bb86ca0fd179a17464c240ff703827355b1b2d27 → 8ed55a6baf4f9bf1f5d250b27ccffd216c46d634 

I fixed some problems, but I'm not sure that I got them all since make docclean && sage docbuild reference pdf
doesn't seem to see my changes (and still complains about the unicode <= symbol). I'm not sure why....
New commits:
3447e80  Changing whitespace

a323641  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/discval

bd7d54e  Merge branch 't/23965/fracfield_coercion_injective' into t/21869/discval

3c0dd8f  Merge branch 't/23966/ZpFM_to_fracfield' into t/21869/discval

8ed55a6  Fixing some pdf docbuild issues.

comment:249 Changed 5 years ago by
Commit:  8ed55a6baf4f9bf1f5d250b27ccffd216c46d634 → e8cfff08cdad8d07b38da97e995dd32dc4f4c284 

Branch pushed to git repo; I updated commit sha1. New commits:
bb2f7c2  Merge commit '7c915f1213' into t/21869/a_framework_for_discrete_valuations_in_sage

4b468bc  Fix errors that caused trouble for docbuild

e8cfff0  Merge branch 'u/roed/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:250 Changed 5 years ago by
Status:  needs_work → needs_review 

Okay, documentation builds. Julian, can you take a look at my changes?
comment:251 Changed 5 years ago by
Status:  needs_review → positive_review 

Work issues:  PDF documentation does not build 
comment:253 Changed 5 years ago by
Branch:  u/roed/a_framework_for_discrete_valuations_in_sage → u/saraedum/a_framework_for_discrete_valuations_in_sage 

comment:254 Changed 5 years ago by
Commit:  e8cfff08cdad8d07b38da97e995dd32dc4f4c284 → 6f0f9e26ae8dddd256b536c41b71c6e8ad45a2cf 

Status:  needs_work → positive_review 
comment:255 Changed 5 years ago by
Status:  positive_review → needs_work 

[docpdf] ! Undefined control sequence. [docpdf] l.309 induced Gauss valuation on \(\Q [docpdf] [x]\), i.e., the valuation that assigns...
comment:256 Changed 5 years ago by
Branch:  u/saraedum/a_framework_for_discrete_valuations_in_sage → u/roed/a_framework_for_discrete_valuations_in_sage 

comment:257 Changed 5 years ago by
Commit:  6f0f9e26ae8dddd256b536c41b71c6e8ad45a2cf → 25e48096e0237f2d00ed288689b4c2d0652d587e 

Oops, I thought I had fixed that but it looks like it didn't get pushed.
New commits:
bb2f7c2  Merge commit '7c915f1213' into t/21869/a_framework_for_discrete_valuations_in_sage

4b468bc  Fix errors that caused trouble for docbuild

3447e80  Changing whitespace

a323641  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/discval

bd7d54e  Merge branch 't/23965/fracfield_coercion_injective' into t/21869/discval

3c0dd8f  Merge branch 't/23966/ZpFM_to_fracfield' into t/21869/discval

8ed55a6  Fixing some pdf docbuild issues.

e8cfff0  Merge branch 'u/roed/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

25e4809  Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

comment:258 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:259 Changed 5 years ago by
Julian, let me know if you're happy with these fixes. I'm currently building and running sage docbuild reference pdf
.
comment:261 Changed 5 years ago by
Status:  needs_review → positive_review 

Yep, pdf documentation builds.
comment:262 Changed 5 years ago by
Status:  positive_review → needs_work 

On some 32bit buildbots I get
********************************************************************** File "src/doc/en/reference/valuations/index.rst", line 36, in doc.en.reference.valuations.index Failed example: w(a + 3), ww(a + 3) Expected: (1, 0) Got: (0, 1) ********************************************************************** File "src/doc/en/reference/valuations/index.rst", line 38, in doc.en.reference.valuations.index Failed example: w(a + 5), ww(a + 5) Expected: (0, 1) Got: (1, 0) ********************************************************************** 1 item had failures: 2 of 54 in doc.en.reference.valuations.index [53 tests, 2 failures, 0.92 s]
comment:263 Changed 5 years ago by
Branch:  u/roed/a_framework_for_discrete_valuations_in_sage → u/saraedum/a_framework_for_discrete_valuations_in_sage 

comment:264 Changed 5 years ago by
Commit:  25e48096e0237f2d00ed288689b4c2d0652d587e → b4756f5a04be2b56735972078238283b1372c322 

comment:265 Changed 5 years ago by
Two comments on
try: ret = sorted(leafs, key=lambda v: str(v)) except: # if for some reason the valuation can not be printed, we leave them unsorted ret = list(leafs)
You can just use key=str
, and you shouldn't have a bare except
(except Exception
is probably fine).
comment:266 Changed 5 years ago by
Work issues:  → fix bare except 

Yes, you are right. I should actually know about both ;) This is not ready for review. I can't get sage to build from develop locally at all at the moment, so I wanted to see how bad such a change is (by having it be tested by the patchbots).
New commits:
b4756f5  Make mac_lane_approximants output more stable

comment:267 Changed 5 years ago by
If you want, there's a copy in Src/sageroed
in the sd88
project on k8s
; I've added you to the project so that you can access it. I'm running doctests there now.
comment:268 Changed 5 years ago by
Work issues:  fix bare except 

comment:269 Changed 5 years ago by
Commit:  b4756f5a04be2b56735972078238283b1372c322 → c4a9900c04eeffeb083ec59e6556a354981acaa1 

comment:270 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:271 Changed 5 years ago by
Status:  needs_review → needs_work 

Work issues:  → doctest output order 
There's a doctest failure because of output ordering. I'll try to fix it, but may not have time to do it today....
comment:272 Changed 5 years ago by
Status:  needs_work → needs_review 

Work issues:  doctest output order 
comment:273 Changed 5 years ago by
Commit:  c4a9900c04eeffeb083ec59e6556a354981acaa1 → 4583f6557566fea5c01f62fab6e8d05a993da832 

Branch pushed to git repo; I updated commit sha1. New commits:
4583f65  fix output order

comment:274 Changed 5 years ago by
There seems to be a nondeterministic failure (it occurred on one of the three patchbot runs for this commit):
sage t long src/sage/rings/valuation/mapped_valuation.py ********************************************************************** File "src/sage/rings/valuation/mapped_valuation.py", line 507, in sage.rings.valuation.mapped_valuation.FiniteExtensionFromInfiniteValuation.upper_bound Failed example: u.upper_bound(t + 2) Expected: 3 Got: 2 ********************************************************************** 1 item had failures: 1 of 8 in sage.rings.valuation.mapped_valuation.FiniteExtensionFromInfiniteValuation.upper_bound
Any ideas?
comment:275 Changed 5 years ago by
The upper bound is not nondeterministic itself. I don't remember really but I don't think that there is anything nondeterministic in my code.
comment:276 Changed 5 years ago by
The upper_bound depends on the precision of the underlying approximation, so the upper_bound can change between calls. As long as the doctests run in a deterministic order, I don't see why this should happen.
comment:277 followup: 280 Changed 5 years ago by
We now have 13 good patchbot runs and one that failed. Would it be acceptable to ignore this?
comment:278 Changed 5 years ago by
I started some patchbots on my own and kick
ed the old results to get some more data here.
comment:279 Changed 5 years ago by
Commit:  4583f6557566fea5c01f62fab6e8d05a993da832 → 7b19f8a8bd683ecdaf7055577753c8e3e31d2b3d 

Branch pushed to git repo; I updated commit sha1. New commits:
7b19f8a  Merge remotetracking branch 'origin/develop' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:280 Changed 5 years ago by
Status:  needs_review → positive_review 

Replying to saraedum:
We now have 13 good patchbot runs and one that failed. Would it be acceptable to ignore this?
I think that's reasonable. I'm happy with this ticket, and there are lots of patchbot runs where all tests pass. Positive review from me.
comment:281 Changed 5 years ago by
Status:  positive_review → needs_work 

I'm getting a bunch of failures of the form
File "src/sage/rings/valuation/valuation_space.py", line 506, in sage.rings.valuation.valuation_space.DiscretePseudoValuationSpace.ElementMethods.residue_ring Failed example: GaussValuation(ZZ['x'], ZZ.valuation(2)).residue_ring() Expected: Univariate Polynomial Ring in x over Finite Field of size 2 (using NTL) Got: Univariate Polynomial Ring in x over Finite Field of size 2 (using GF2X) ********************************************************************** 1 item had failures: 1 of 6 in sage.rings.valuation.valuation_space.DiscretePseudoValuationSpace.ElementMethods.residue_ring [201 tests, 1 failure, 0.56 s]
comment:282 Changed 5 years ago by
Ok. I'll try to reproduce this locally…but I have to rebuild Sage of course…
comment:283 Changed 5 years ago by
Status:  needs_work → positive_review 

I don't see this problem with the latest develop merged in. Could you tell us more about the machines and base revision where this is failing?
comment:285 Changed 5 years ago by
Commit:  7b19f8a8bd683ecdaf7055577753c8e3e31d2b3d → c53f45c7fe243ba5ef2e53dd54b428d3d8218ee7 

Branch pushed to git repo; I updated commit sha1. New commits:
613a524  Merge remotetracking branch 'origin/develop' into t/21869/a_framework_for_discrete_valuations_in_sage

e05c325  Merge remotetracking branch 'trac/develop' into t/21869/a_framework_for_discrete_valuations_in_sage

c53f45c  Fix doctests

comment:286 Changed 5 years ago by
I fixed the trivial doctest errors.
There are also a bunch of doctest errors in the patchbots that do not seem to be related to what we are doing here. I am rebuilding sage locally and report back once I have checked locally.
comment:287 Changed 5 years ago by
Status:  needs_work → positive_review 

comment:288 Changed 5 years ago by
Commit:  c53f45c7fe243ba5ef2e53dd54b428d3d8218ee7 → 6892bdda7b4df40403dea51a1ff31f47dba0fc0d 

Status:  positive_review → needs_review 
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
6892bdd  Workaround a noisy doctest

comment:290 Changed 5 years ago by
Status:  positive_review → needs_work 

[docpdf] ! Missing $ inserted. [docpdf] <inserted text> [docpdf] $ [docpdf] l.1203 relation \sphinxcode{P.v ≤ V.v} [docpdf] (pointwise on the polynomial ring K...
comment:291 Changed 5 years ago by
Commit:  6892bdda7b4df40403dea51a1ff31f47dba0fc0d → e78174232093e0931514f6fc6038be22a2bc4e0c 

Branch pushed to git repo; I updated commit sha1. New commits:
e781742  Fix documentation build issues

comment:292 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:293 Changed 5 years ago by
Commit:  e78174232093e0931514f6fc6038be22a2bc4e0c → e01a3ab0fbd7f40532395063e2cc7e9defd579a0 

Branch pushed to git repo; I updated commit sha1. New commits:
e01a3ab  Require incomparability

comment:294 Changed 5 years ago by
The changes could make some outputs gain precision. Let's see what the patchbots think…
comment:296 Changed 5 years ago by
Commit:  e01a3ab0fbd7f40532395063e2cc7e9defd579a0 → 21428911816e42073feb06eaa3867b55bfd2e31a 

Branch pushed to git repo; I updated commit sha1. New commits:
2142891  fix copy & paste mistake

comment:297 Changed 5 years ago by
I'm trying to build the documentation now to check the previous change.
New commits:
2142891  fix copy & paste mistake

comment:298 Changed 5 years ago by
Status:  needs_review → needs_work 

File "src/sage/rings/padics/padic_valuation.py", line 726, in sage.rings.padics.padic_valuation.pAdicValuation_base.extensions Failed example: QQ.valuation(2).extensions(L) Expected: Traceback (most recent call last): ... ValueError: The valuation [ Gauss valuation induced by 2adic valuation, v(x) = 1/2 ] does not approximate a unique extension of 2adic valuation with respect to x^4 + 2*x^3 + 2*x^2 + 8 Got: [[ 2adic valuation, v(x + 2) = 3/2 ]adic valuation, [ 2adic valuation, v(x) = 1/2 ]adic valuation]
comment:299 Changed 5 years ago by
Commit:  21428911816e42073feb06eaa3867b55bfd2e31a → 4900f56945720dba8eeaff3be5d5d4c18e443b0f 

comment:300 Changed 5 years ago by
Status:  needs_work → needs_review 

comment:301 Changed 5 years ago by
Commit:  4900f56945720dba8eeaff3be5d5d4c18e443b0f → 24807e364bb0ac04e998465ad7c25ee28d16fbf8 

Branch pushed to git repo; I updated commit sha1. New commits:
24807e3  Merge remotetracking branch 'trac/develop' into t/21869/a_framework_for_discrete_valuations_in_sage

comment:302 Changed 5 years ago by
Description:  modified (diff) 

comment:303 Changed 5 years ago by
Status:  needs_review → positive_review 

The failing builds look to be due to some unrelated giac issue, and I don't know what the failed apply is. I'm happy with the changes and the documentation builds when I test it. Let's set this back to positive review.
comment:304 Changed 5 years ago by
Branch:  u/saraedum/a_framework_for_discrete_valuations_in_sage → 24807e364bb0ac04e998465ad7c25ee28d16fbf8 

Resolution:  → fixed 
Status:  positive_review → closed 
comment:305 Changed 5 years ago by
Commit:  24807e364bb0ac04e998465ad7c25ee28d16fbf8 

Description:  modified (diff) 
comment:306 Changed 4 years ago by
What's the point of these doctests?
Note that this does not affect comparison of valuations which do not coerce into a common parent. This is by design in Sage, see :meth:`sage.structure.element.Element.__richcmp__`. When the valuations do not coerce into a common parent, a rather random comparison of ``id`` happens:: sage: w = valuations.TrivialValuation(GF(2)) sage: w <= v # random output True sage: v <= w # random output False
I plan to remove them in #26934
comment:307 followup: 308 Changed 4 years ago by
I thought that the docstring is quite technical, so the doctest illustrates what I mean. They don't "test" anything, they are really part of the documentation.
comment:308 Changed 4 years ago by
comment:309 Changed 4 years ago by
It's a detail of the coercion model but here the point is just that it does not work the way you would expect it to. Comparisons are important in this context and it's therefore important to document the limitations. If it raises an error, all the better.
Last 10 new commits:
fix typo in comment
Added a tutorial in the README
move to subdirectory for merging with sage tree
removing gitignore for merge with sage tree
Merge mac_lane infrastructure for discrete valuations into sage
remove mac_lane LICENSE
remove obsolete TODOs
remove monkey patches
move valuation code to valuation/
remove specific valuation code out of valuation/