Changes between Version 217 and Version 302 of Ticket #21869


Ignore:
Timestamp:
01/19/18 14:38:57 (23 months ago)
Author:
saraedum
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21869

    • Property Commit changed from 5578cae3051b2637aa31b06a28958b8a5d739a14 to 24807e364bb0ac04e998465ad7c25ee28d16fbf8
  • Ticket #21869 – Description

    v217 v302  
    11Based on the sage package https://github.com/saraedum/mac_lane.
    2 
    3 = Review =
    4 
    5 Please check off `[x]` the following when you think that a file is in good shape (modulo the comments that you made.) Or put a `[-]` if it needs substantial work. You can put your name next to file to tell others that you are already having a look at it.
    6 
    7 {{{
    8 [x] function_field/function_field_valuation.py (Stefan Wewers)
    9 [x] padics/discrete_value_group.py
    10 [x] padics/padic_valuation.py (David)
    11 [x] valuation/README.md
    12 [x] valuation/__init__.py
    13 [x] valuation/all.py (David)
    14 [x] valuation/augmented_valuation.py (David)
    15 [x] valuation/developing_valuation.py (Shiva)
    16 [x] valuation/gauss_valuation.py (Padmavathi)
    17 [x] valuation/inductive_valuation.py (David)
    18 [x] valuation/limit_valuation.py (David)
    19 [x] valuation/mapped_valuation.py (David)
    20 [x] valuation/scaled_valuation.py (David)
    21 [x] valuation/trivial_valuation.py (David)
    22 [x] valuation/valuation.py (David)
    23 [x] valuation/valuation_space.py (David)
    24 [x] valuation/valuations_catalog.py (David)
    25 [x] valuation/value_group.py (Padmavathi)
    26 [x] rings/function_field/function_field.py
    27 [x] rings/integer_ring.pyx
    28 [x] rings/number_field/number_field.py
    29 [x] rings/number_field/order.py
    30 [x] rings/padics/padic_generic.py
    31 [x] rings/rational_field.py
    32 }}}
    33 
    34 = Necessary changes =
    35 
    36 == Fix bugs in Sage ==
    37 There are a number of trivial bugs that get fixed by monkey-patches in https://github.com/saraedum/mac_lane/blob/master/__init__.py
    38 
    39 1. Conversion from a Function Field to its Constant Field #21872
    40 1. Conversion from a Function Field to its underlying Polynomial Ring #23166
    41 1. Coercions between Function Fields #23167
    42 1. Coercions are injective if the underlying map is #21879
    43 1. Ring homomorphisms from Fields are injective #21879
    44 1. Polynomial rings embed into their fraction fields #23185
    45 1. The embedding of a ring into a polynomial ring over that ring is injective #23203, #23204, #23211
    46 1. p-adic rings embed into their fraction fields #23188
    47 1. Morphisms of number fields are injective #21879
    48 1. ZZ into QQ is injective #21879
    49 1. quotients of polynomial rings are injective/surjective #23190
    50 1. ZZ into a Number Field is injective #21879
    51 1. ZZ into an order of a Number Field is injective #21879
    52 1. ZZ does not map onto QQ #23186
    53 1. ~~ZpCA shifts are broken~~
    54 1. add default implementation of inverse_of_unit()  #23191
    55 1. R[x]→S[x] is injective/surjective if R→S is #23495
    56 
    57 == Add new features to Sage ==
    58 New features that the code needs to work
    59 
    60 1. Factorization over iterated extensions of finite fields. #21996
    61 1. ~~principal_part() and sides() of a Newton Polygon~~ (patch this in the calling code instead.)
    62 1. (cached_in_argument_method #22034)
    63 
    64 == Make tests non-trivial ==
    65 
    66 1. (some_elements() should be non-trivial for number fields/orders) #23192
    67 1. (some_elements() should be non-trivial/deterministic for rational function fields and their extensions) #23193
    68 1. (some_elements() should be non-trivial for fraction_fields of polynomial rings) #23194