Changes between Version 159 and Version 164 of Ticket #21869


Ignore:
Timestamp:
07/24/17 13:55:34 (5 years ago)
Author:
saraedum
Comment:

Last 10 new commits:

​1754b44Fix exact=True errors in the right branch
​7926b41Moving code for fraction_field and integer_ring, and enabling fraction fields for fixed-mod
​7712a86Merge remote-tracking branch 'trac/u/roed/fixed_mod_frac_field' into t/21869/a_framework_for_discrete_valuations_in_sage
​276e4f7fix and fill in doctest output
​9b03cf8compute fraction field only when necessary
​a886c42fix pickling of nodes
​a92f47fmake sure that arguments to add_bigoh are correctly normalized
​aa1709dcomment on stagnating degrees
​005e7abMerge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage
​2d1cb90Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21869

    • Property Work issues changed from 36 failing doctests, comments on github, check docbuild output for broken links to 7 failing doctests, check docbuild output for broken links
    • Property Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483, #23510, #23525
    • Property Commit changed from 249bdc0743c0c79ffd6cec510db0d9c7bbec49e2 to 2d1cb90b3deffd9210a9d6366cdf8666c38acbdc

  • Ticket #21869 – Description

    v159 v164  
    11= Review =
    2 
    3 For your convenience you can review this ticket at https://github.com/saraedum/mac_lane/pull/4 (and leave inline comments.)
    42
    53Please check off `[x]` the following when you think that a file is in good shape (modulo the comments that you made.) Or put a `[-]` if it needs substantial work. You can put your name next to file to tell others that you are already having a look at it.
    … …  
    4947Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:
    5048{{{
    51 src/sage/rings/padics/padic_valuation.py  # 10 doctests failed
    52 src/sage/rings/valuation/valuation.py  # 26 doctests failed
     49src/sage/rings/padics/padic_valuation.py  # 2 doctests failed
     50src/sage/rings/valuation/valuation.py  # 5 doctests failed
    5351}}}
    5452