Changes between Version 73 and Version 75 of Ticket #21869


Ignore:
Timestamp:
07/21/17 02:08:19 (22 months ago)
Author:
roed
Comment:

New commits:

e5ef4d8do not catch everything
9fd8733fix import
e1e65a5fixed typo
9c16a1bundo .valuation() shortcut
119f245It is not relevant whether a valuation converts into the valuation space but whether it is already in the valuation space
7ea9874fix doctests
3fd4140add doctest output
0c60cb7fix valuation parameters
2010014restricting to ZZ, we need to know the prime
efe2490Merge branch 'u/saraedum/a_framework_for_discrete_valuations_in_sage' of git://trac.sagemath.org/sage into t/21869/a_framework_for_discrete_valuations_in_sage

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21869

    • Property Dependencies changed from #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495, #23483 to #21782, #23166, #23167, #21879, #23185, #23203, #23204, #23211, #23188, #21879, #23186, #23191, #21996, #23190, #23495
    • Property Commit changed from 20100145cbdac34f8f3f021f597f750541c60d11 to efe24904ec35606462a941a47fee496ebf463491
    • Property Reviewers changed from GaYee Park, Stefan Wewers, David Roe to GaYee Park, Stefan Wewers
    • Property Work issues changed from move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 33 failing doctests to move references to references file, move README to sage documentation, make sure that valuation() has a lot of the documentation and the factory just references it, remove optional: integrated bits, check that discrete_value_group is still available the same way it was under padics, 252 failing doctests
  • Ticket #21869 – Description

    v73 v75  
    88
    99{{{
    10 [x] function_field/function_field_valuation.py (Stefan Wewers)
     10[ ] function_field/function_field_valuation.py (Stefan Wewers)
    1111[x] padics/discrete_value_group.py
    1212[ ] padics/padic_valuation.py
     
    2323[ ] valuation/trivial_valuation.py
    2424[ ] valuation/valuation.py
    25 [ ] valuation/valuation_space.py (David)
     25[x] valuation/valuation_space.py (David)
    2626[ ] valuation/valuations_catalog.py
    2727[ ] valuation/value_group.py (Padmavathi)
     
    3535Some tests fail because some of the paths broke when moving the code from github into sage. The following are known problems – Julian aka saraedum is working on these:
    3636{{{
    37 sage -t --warn-long 61.0 src/sage/rings/polynomial/polynomial_quotient_ring.py  # 2 doctests failed
    38 sage -t --warn-long 61.0 src/sage/rings/valuation/augmented_valuation.py  # 6 doctests failed
    39 sage -t --warn-long 61.0 src/sage/rings/number_field/order.py  # 1 doctest failed
    40 sage -t --warn-long 61.0 src/sage/rings/valuation/valuation.py  # 7 doctests failed
    41 sage -t --warn-long 61.0 src/sage/rings/valuation/inductive_valuation.py  # 7 doctests failed
    42 sage -t --warn-long 61.0 src/sage/rings/morphism.pyx  # 2 doctests failed
    43 sage -t --warn-long 61.0 src/sage/rings/polynomial/skew_polynomial_element.pyx  # 8 doctests failed
     37sage -t --warn-long 39.1 src/sage/rings/function_field/function_field_valuation.py  # 126 doctests failed
     38sage -t --warn-long 39.1 src/sage/rings/valuation/valuation.py  # 9 doctests failed
     39sage -t --warn-long 39.1 src/sage/rings/valuation/limit_valuation.py  # 52 doctests failed
     40sage -t --warn-long 39.1 src/sage/rings/valuation/mapped_valuation.py  # 42 doctests failed
     41sage -t --warn-long 39.1 src/sage/rings/valuation/inductive_valuation.py  # 13 doctests failed
     42sage -t --warn-long 39.1 src/sage/rings/valuation/augmented_valuation.py  # 10 doctests failed
    4443}}}
    4544