#21864 closed enhancement (fixed)
Use pip install for more packages
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | build | Keywords: | pip |
Cc: | jdemeyer, embray, slelievre | Merged in: | sage-7.5.rc0 |
Authors: | Matthias Koeppe | Reviewers: | Jeroen Demeyer |
Report Upstream: | Reported upstream. No feedback yet. | Work issues: | |
Branch: | 3810b42 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
From jdemeyer in #9536:
it would make sense to use $PIP_INSTALL for a few more packages where no extra options are needed: fpylll, gambit, sagenb, sagetex.
This ticket makes Sage use $PIP_INSTALL
for
- fpylll
- sagenb
- sagetex
Because of an upstream issue with gambit, we exclude gambit for now.
Change History (13)
comment:1 Changed 6 years ago by
Component: | PLEASE CHANGE → build |
---|
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
Branch: | → u/mkoeppe/use_pip_install_for_more_packages |
---|
comment:4 Changed 6 years ago by
Commit: | → 3810b426e00a32513062701fdf6e011d6023c865 |
---|
comment:5 Changed 6 years ago by
- fpylll, sagenb, sagetex - pip install seems to work.
- Gambit: pip install fails because of an upstream problem. The installed header file
libgambit.h
uses#include <config.h>
but that is not an installed header file.
comment:6 Changed 6 years ago by
Report Upstream: | N/A → Reported upstream. No feedback yet. |
---|
I've reported the Gambit issue upstream at: https://github.com/gambitproject/gambit/issues/207
comment:7 Changed 6 years ago by
Authors: | → Matthias Koeppe |
---|---|
Reviewers: | → Jeroen Demeyer |
comment:8 Changed 6 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_review |
comment:9 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:10 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:11 Changed 6 years ago by
Status: | needs_review → positive_review |
---|
comment:12 Changed 6 years ago by
Branch: | u/mkoeppe/use_pip_install_for_more_packages → 3810b426e00a32513062701fdf6e011d6023c865 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:13 Changed 5 years ago by
Cc: | slelievre added |
---|---|
Commit: | 3810b426e00a32513062701fdf6e011d6023c865 |
Description: | modified (diff) |
Keywords: | pip added |
Merged in: | → sage-7.5.rc0 |
Note: See
TracTickets for help on using
tickets.
I think I originally explicitly excluded those packages because it wasn't clear exactly what the impact would be and I didn't take the time to test it. There should definitely be a ticket for this though.