Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#21864 closed enhancement (fixed)

Use pip install for more packages

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.5
Component: build Keywords: pip
Cc: jdemeyer, embray, slelievre Merged in: sage-7.5.rc0
Authors: Matthias Koeppe Reviewers: Jeroen Demeyer
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: 3810b42 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

From jdemeyer in #9536:

it would make sense to use $PIP_INSTALL for a few more packages where no extra options are needed: fpylll, gambit, sagenb, sagetex.

This ticket makes Sage use $PIP_INSTALL for

  • fpylll
  • sagenb
  • sagetex

Because of an upstream issue with gambit, we exclude gambit for now.

Change History (13)

comment:1 Changed 6 years ago by mkoeppe

Component: PLEASE CHANGEbuild

comment:2 Changed 6 years ago by embray

I think I originally explicitly excluded those packages because it wasn't clear exactly what the impact would be and I didn't take the time to test it. There should definitely be a ticket for this though.

comment:3 Changed 6 years ago by mkoeppe

Branch: u/mkoeppe/use_pip_install_for_more_packages

comment:4 Changed 6 years ago by git

Commit: 3810b426e00a32513062701fdf6e011d6023c865

Branch pushed to git repo; I updated commit sha1. New commits:

7491b91sagenb: Use PIP_INSTALL
3810b42sagetex: Use PIP_INSTALL

comment:5 Changed 6 years ago by mkoeppe

  • fpylll, sagenb, sagetex - pip install seems to work.

  • Gambit: pip install fails because of an upstream problem. The installed header filelibgambit.h uses #include <config.h> but that is not an installed header file.

comment:6 Changed 6 years ago by mkoeppe

Report Upstream: N/AReported upstream. No feedback yet.

I've reported the Gambit issue upstream at: https://github.com/gambitproject/gambit/issues/207

comment:7 Changed 6 years ago by jdemeyer

Authors: Matthias Koeppe
Reviewers: Jeroen Demeyer

comment:8 Changed 6 years ago by jdemeyer

Description: modified (diff)
Status: newneeds_review

comment:9 Changed 6 years ago by jdemeyer

Description: modified (diff)

comment:10 Changed 6 years ago by jdemeyer

Description: modified (diff)

comment:11 Changed 6 years ago by jdemeyer

Status: needs_reviewpositive_review

comment:12 Changed 6 years ago by vbraun

Branch: u/mkoeppe/use_pip_install_for_more_packages3810b426e00a32513062701fdf6e011d6023c865
Resolution: fixed
Status: positive_reviewclosed

comment:13 Changed 5 years ago by slelievre

Cc: slelievre added
Commit: 3810b426e00a32513062701fdf6e011d6023c865
Description: modified (diff)
Keywords: pip added
Merged in: sage-7.5.rc0
Note: See TracTickets for help on using tickets.