Opened 6 years ago

Closed 5 years ago

#21843 closed enhancement (fixed)

Update the .cython_version format to include all cythonize options

Reported by: Erik Bray Owned by: Erik Bray
Priority: minor Milestone: sage-8.0
Component: build Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: b56b4be (Commits, GitHub, GitLab) Commit: b56b4bef156cd4abf1718fa0deae3e42420f02bd
Dependencies: Stopgaps:

Status badges

Description

As discussed beginning here, the current .cython_version stamp does not always accurately reflect all Cython build options which, if changed, should trigger a rebuild of Cython sources.

It would be good to have a more detailed .cython_version that includes all arguments to cythonize() and perhaps all Cython.Compiler.Options.

Although the values of these options are generally simple types, the compiler_directives dict alone makes this data structure complicated enough that an ad hoc format like the one currently used is not justified--instead a json-formatted file should work.

Change History (7)

comment:1 Changed 6 years ago by Erik Bray

Owner: set to Erik Bray

comment:2 Changed 5 years ago by Jeroen Demeyer

Branch: u/jdemeyer/update_the__cython_version_format_to_include_all_cythonize_options

comment:3 Changed 5 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Commit: b56b4bef156cd4abf1718fa0deae3e42420f02bd
Status: newneeds_review

New commits:

b56b4beInclude Cython directives in .cython_version file

comment:4 Changed 5 years ago by Erik Bray

Status: needs_reviewpositive_review

Thanks--straightforward enough.

comment:5 Changed 5 years ago by Erik Bray

Milestone: sage-7.5sage-8.0

comment:6 Changed 5 years ago by Travis Scrimshaw

Reviewers: Erik Bray

*cough cough*

comment:7 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/update_the__cython_version_format_to_include_all_cythonize_optionsb56b4bef156cd4abf1718fa0deae3e42420f02bd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.