#21827 closed enhancement (fixed)
Upgrade to pynac-0.7.0
Reported by: | rws | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | packages: standard | Keywords: | |
Cc: | cmafra | Merged in: | |
Authors: | Ralf Stephan, Carlos R. Mafra | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 01455b2 (Commits) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
Included:
- Pynac now depends on Flint
- fast univariate series expansion using Flint (#14878)
- fix gamma(QQbar(1/2)) problem
- gegenbauer(n,a,x) fixes and enhancements (#21639)
- fix hermite derivative wrt index
https://github.com/pynac/pynac/releases/download/pynac-0.7.0/pynac-0.7.0.tar.bz2
Change History (11)
comment:1 Changed 4 years ago by
- Branch set to u/rws/upgrade_to_pynac_0_7_0
comment:2 Changed 4 years ago by
- Cc cmafra added
- Commit set to a0907b130a95edd23fa4beae7c07587bd10e3697
- Status changed from new to needs_review
comment:3 Changed 4 years ago by
- Commit changed from a0907b130a95edd23fa4beae7c07587bd10e3697 to 18a7256b7f8eb9cee63c6a8b225419614ea9a27f
Branch pushed to git repo; I updated commit sha1. New commits:
18a7256 | 21827: cosmetics
|
comment:4 Changed 4 years ago by
Two minor things:
- Use
.. MATH::
as we are trying to be consistent with the dev guide. - I think "QQbar" should either be
``QQbar``
or the corresponding latex version.
Once fixed, you can set a positive review on my behalf.
comment:5 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
comment:6 Changed 4 years ago by
- Commit changed from 18a7256b7f8eb9cee63c6a8b225419614ea9a27f to 01455b2b936e064eefe569efcc6a5b76616bbf91
Branch pushed to git repo; I updated commit sha1. New commits:
01455b2 | 21827: more cosmetics
|
comment:7 Changed 4 years ago by
- Status changed from needs_review to positive_review
Thanks for the review.
comment:8 Changed 4 years ago by
I just noticed that you neither do detection of flint
in configure
or link to the flint
library. Meaning that libpynac.so
is actually underlinked. This may prove a problem for people using --as-needed
in their LDFLAGS
and the gold linker. See #20646 for a discussion of a similar situation.
The ticket is good to go for now but I will consider making a PR to solve these issues in 0.7.1.
comment:9 Changed 4 years ago by
Thanks for the fix.
comment:10 Changed 4 years ago by
- Branch changed from u/rws/upgrade_to_pynac_0_7_0 to 01455b2b936e064eefe569efcc6a5b76616bbf91
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 4 years ago by
- Commit 01455b2b936e064eefe569efcc6a5b76616bbf91 deleted
- Description modified (diff)
New commits:
version/chksum/dependency
orthogonal poly improvements
misc doctests
series changes