Opened 3 years ago

Closed 3 years ago

#21819 closed enhancement (fixed)

Rewrite error functions and documentation

Reported by: rws Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1eac4d8 (Commits) Commit: 1eac4d808b9b56df1130afd3f6842d13cdea6ca4
Dependencies: Stopgaps:

Description (last modified by rws)

This ticket should accomplish:

http://dlmf.nist.gov/7

Change History (23)

comment:1 Changed 3 years ago by rws

  • Dependencies set to #11349
  • Description modified (diff)
  • Summary changed from Symbolical erfc() implementation to Rewrite error functions and documentation

comment:2 Changed 3 years ago by rws

  • Branch set to u/rws/rewrite_error_functions_and_documentation

comment:3 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to fbb77c0cdfd52c5c915471a0bc6bffb8bde0c429
  • Dependencies #11349 deleted
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

fbb77c021819: erf() reorg

comment:4 Changed 3 years ago by rws

  • Description modified (diff)

comment:5 Changed 3 years ago by paulmasson

The name error_fcn is nonstandard. I think it should be deprecated with an appropriate warning.

A couple minor things in the documentation in error.py:

1) One LaTeX instance of \text should be \operatorname

2) Five instances of code markdown in the AUTHORS section need double back ticks instead of single.

comment:6 Changed 3 years ago by git

  • Commit changed from fbb77c0cdfd52c5c915471a0bc6bffb8bde0c429 to 3c5739efb4f19c1484d4816d682e65539258d01d

Branch pushed to git repo; I updated commit sha1. New commits:

801c42aMerge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
3c5739e21819: address reviewer's comments; maxima erfc bindings

comment:7 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

failing doctests

comment:8 Changed 3 years ago by git

  • Commit changed from 3c5739efb4f19c1484d4816d682e65539258d01d to be39e50af76bf04591db321759b9de57a58d846e

Branch pushed to git repo; I updated commit sha1. New commits:

2fb1d2dMerge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
be39e5021819: fixes

comment:9 Changed 3 years ago by rws

  • Status changed from needs_work to needs_review

comment:10 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

does not apply

comment:11 Changed 3 years ago by git

  • Commit changed from be39e50af76bf04591db321759b9de57a58d846e to 7fade55e7200d959cb38aea6f717ee7473937430

Branch pushed to git repo; I updated commit sha1. New commits:

7fade55Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation

comment:12 Changed 3 years ago by rws

  • Milestone changed from sage-7.5 to sage-7.6
  • Status changed from needs_work to needs_review

New commits:

7fade55Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation

comment:13 Changed 3 years ago by rws

  • Branch changed from u/rws/rewrite_error_functions_and_documentation to u/rws/21819-1

comment:14 Changed 3 years ago by rws

  • Commit changed from 7fade55e7200d959cb38aea6f717ee7473937430 to b56829c66f00d9c4e5132eb5c77ffbda417ce01a

Squashed and lazy import added.


New commits:

b56829c21819: Rewrite error functions and documentation

comment:15 follow-up: Changed 3 years ago by tscrim

In error.py, there is no reason to deprecate error_fcn there. I would do that in the original location. You should also have lazy_imports deprecations that redirect to the new location.

comment:16 Changed 3 years ago by rws

Do you have an idea why the patchbot's startup_modules plugin still triggers?

comment:17 Changed 3 years ago by git

  • Commit changed from b56829c66f00d9c4e5132eb5c77ffbda417ce01a to e96e7e14cca7e9062bb3e8d8becb52b43790e3f8

Branch pushed to git repo; I updated commit sha1. New commits:

e96e7e121819: move error_fcn back to functions.other

comment:18 in reply to: ↑ 15 Changed 3 years ago by rws

Replying to tscrim:

... You should also have lazy_imports deprecations that redirect to the new location.

I tried but I don't think lazy_import's deprecation arg does what I think you're trying to do.

comment:19 Changed 3 years ago by rws

  • Milestone changed from sage-7.6 to sage-8.0

comment:20 Changed 3 years ago by tscrim

  • Branch changed from u/rws/21819-1 to public/symbolics/rewrite_error_functions-21819
  • Commit changed from e96e7e14cca7e9062bb3e8d8becb52b43790e3f8 to 1eac4d808b9b56df1130afd3f6842d13cdea6ca4
  • Reviewers set to Travis Scrimshaw

I was going to try, but then I felt lazy and the current version works just fine. I made a few documentation tweaks. If my changes are good with you, then you can set a positive review.


New commits:

df32cc6Merge branch 'u/rws/21819-1' of git://trac.sagemath.org/sage into public/symbolics/rewrite_error_functions-21819
1eac4d8Some small tweaks to the doc.

comment:21 Changed 3 years ago by rws

  • Status changed from needs_review to positive_review

Looks good and tests in functions are fine. Thanks for the help with this.

comment:22 Changed 3 years ago by tscrim

Sorry I let this drop off my radar.

comment:23 Changed 3 years ago by vbraun

  • Branch changed from public/symbolics/rewrite_error_functions-21819 to 1eac4d808b9b56df1130afd3f6842d13cdea6ca4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.