Opened 6 years ago
Closed 6 years ago
#21809 closed enhancement (fixed)
Pythonize deprecation warnings in PARI interface
Reported by: | Jeroen Demeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | interfaces | Keywords: | atelierpari2017 |
Cc: | Luca De Feo | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Luca De Feo |
Report Upstream: | N/A | Work issues: | |
Branch: | 6022cab (Commits, GitHub, GitLab) | Commit: | 6022cab1880d6f3820e0f028671ddd2983eae42b |
Dependencies: | #21756 | Stopgaps: |
Description (last modified by )
The Sage deprecation warnings in src/sage/libs/cypari2/...
should be either removed or replaced by pure Python warnings.
We use the new Obsolete
keyword in pari.desc
to automatically generate deprecation warnings.
For simplicity, some deprecated code from #20216, #20217, #20219, #20205 is simply removed (even if the 12-month deprecation period ends only 15 May 2017).
Change History (20)
comment:1 Changed 6 years ago by
Dependencies: | → #21820 |
---|
comment:2 Changed 6 years ago by
Authors: | → Jeroen Demeyer |
---|---|
Cc: | Luca De Feo added |
Dependencies: | #21820 |
comment:3 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:5 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 6 years ago by
Dependencies: | → #21756 |
---|
comment:8 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:9 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:10 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:11 Changed 6 years ago by
Branch: | → u/jdemeyer/pythonize_deprecation_warnings_in_pari_interface |
---|
comment:12 Changed 6 years ago by
Commit: | → 47670cc0d1f881afab16c4e7dd66c5bd0f452203 |
---|
comment:13 Changed 6 years ago by
Status: | new → needs_review |
---|
comment:14 Changed 6 years ago by
Keywords: | atelierpari2017 added |
---|
comment:15 Changed 6 years ago by
Branch: | u/jdemeyer/pythonize_deprecation_warnings_in_pari_interface → u/defeo/pythonize_deprecation_warnings_in_pari_interface |
---|
comment:16 Changed 6 years ago by
Commit: | 47670cc0d1f881afab16c4e7dd66c5bd0f452203 → 6022cab1880d6f3820e0f028671ddd2983eae42b |
---|---|
Reviewers: | → Luca De Feo |
comment:17 Changed 6 years ago by
To be honest, I don't really understand the purpose of your latest change. You are achieving exactly the same thing with more complicated code...
I'm not strictly against your change, I just don't see which problem it solves.
comment:18 Changed 6 years ago by
My code can be cleanly split between PariInstance
and the (supposed) SagePariInstance
subclass. Yours couldn't.
comment:19 Changed 6 years ago by
Status: | needs_review → positive_review |
---|
comment:20 Changed 6 years ago by
Branch: | u/defeo/pythonize_deprecation_warnings_in_pari_interface → 6022cab1880d6f3820e0f028671ddd2983eae42b |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Give DeprecationWarning for obsolete PARI/GP functions