Opened 6 years ago
Closed 6 years ago
#21807 closed enhancement (fixed)
Move gentoobj and rename it to gen_to_sage
Reported by:  Jeroen Demeyer  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  interfaces  Keywords:  atelierpari2017 
Cc:  Luca De Feo, JeanPierre Flori, Peter Bruin  Merged in:  
Authors:  Vincent Delecroix  Reviewers:  Luca De Feo 
Report Upstream:  N/A  Work issues:  
Branch:  8828867 (Commits, GitHub, GitLab)  Commit:  88288670d22328ea0ff386c826c65d729504cb58 
Dependencies:  Stopgaps: 
Description (last modified by )
The function sage.libs.cypari2.gen.gentoobj
returning Sage objects is moved to sage.libs.pari.sage_convert.gen_to_sage
.
Change History (35)
comment:1 Changed 6 years ago by
Description:  modified (diff) 

Summary:  Create a SagePariInstance class → Move gentoobj and rename it to gentosage 
comment:2 Changed 6 years ago by
Description:  modified (diff) 

comment:3 Changed 6 years ago by
Dependencies:  → #21820 

comment:4 Changed 6 years ago by
Authors:  → Vincent Delecroix 

Branch:  → u/vdelecroix/21807 
Dependencies:  #21820 
comment:5 Changed 6 years ago by
Commit:  → 44b7558b77b734b6d962a4a9bf9156e603c8ca2c 

comment:6 Changed 6 years ago by
Description:  modified (diff) 

Status:  new → needs_review 
comment:7 Changed 6 years ago by
Commit:  44b7558b77b734b6d962a4a9bf9156e603c8ca2c → 8b67f803631ea8398ce58223ac8433873904a6e6 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
8b67f80  21807: gentoobj > gentosage

comment:8 Changed 6 years ago by
Cc:  JeanPierre Flori Peter Bruin added 

Keywords:  atelierpari2017 added 
comment:9 Changed 6 years ago by
We hav gen_to_integer
versus gentoobj
. What convention should we use? I am in favor of Sage's one: gen_to_sage
. What do you think?
comment:10 followups: 12 25 Changed 6 years ago by
gen_py.py
has been deprecated 12 months ago. We might as well drop it.
comment:11 followup: 15 Changed 6 years ago by
as for gentosage
vs gen_to_sage
, it's all the same to me.
comment:12 Changed 6 years ago by
Status:  needs_review → needs_work 

Replying to defeo:
gen_py.py
has been deprecated 12 months ago. We might as well drop it.
I will do it here.
comment:13 Changed 6 years ago by
Commit:  8b67f803631ea8398ce58223ac8433873904a6e6 → 29f83ed52ef6f12489e6343acb1700fa707aa02a 

comment:14 Changed 6 years ago by
Status:  needs_work → needs_review 

comment:15 Changed 6 years ago by
Replying to defeo:
as for
gentosage
vsgen_to_sage
, it's all the same to me.
I changed it to gen_to_sage
in my last commit.
comment:16 Changed 6 years ago by
Description:  modified (diff) 

comment:18 Changed 6 years ago by
Commit:  29f83ed52ef6f12489e6343acb1700fa707aa02a → a3624b10df697c3ec46391b376ca3357b06d016b 

Branch pushed to git repo; I updated commit sha1. New commits:
a3624b1  21807: copyright notice

comment:20 Changed 6 years ago by
Summary:  Move gentoobj and rename it to gentosage → Move gentoobj and rename it to gen_to_sage 

comment:21 Changed 6 years ago by
Reviewers:  → Luca De Feo 

Status:  needs_review → positive_review 
Good to go
comment:23 Changed 6 years ago by
Commit:  a3624b10df697c3ec46391b376ca3357b06d016b → d173a7b1c4451652406babaa75403d951bf67f61 

Status:  positive_review → needs_review 
comment:25 followup: 26 Changed 6 years ago by
Replying to defeo:
gen_py.py
has been deprecated 12 months ago. We might as well drop it.
This might break the pickle jar. Be sure to run doctests...
comment:26 Changed 6 years ago by
Status:  needs_review → needs_work 

comment:27 Changed 6 years ago by
Commit:  d173a7b1c4451652406babaa75403d951bf67f61 → c0ac7927d3c22cf3befde978b60ddac8f397c5f5 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
c0ac792  21807: gentoobj > gentosage

comment:28 Changed 6 years ago by
Status:  needs_work → needs_review 

comment:29 Changed 6 years ago by
Status:  needs_review → needs_work 

Don't deprecate sage.libs.cypari2.gentoobj
, just remove it. We don't want Sage deprecations in cypari2
.
comment:30 Changed 6 years ago by
Commit:  c0ac7927d3c22cf3befde978b60ddac8f397c5f5 → 375658cf89c3e065ec538e53f42c60eef544fa34 

Branch pushed to git repo; I updated commit sha1. New commits:
375658c  21807: remove gentoobj (that was just a deprecated alias)

comment:32 Changed 6 years ago by
Branch:  u/vdelecroix/21807 → u/defeo/21807 

comment:33 Changed 6 years ago by
Commit:  375658cf89c3e065ec538e53f42c60eef544fa34 → 88288670d22328ea0ff386c826c65d729504cb58 

New commits:
8828867  Python 3 compatibility in doctests

comment:34 Changed 6 years ago by
Status:  needs_review → positive_review 

I'm happy, Patchbot's happy, everyone's happy!
comment:35 Changed 6 years ago by
Branch:  u/defeo/21807 → 88288670d22328ea0ff386c826c65d729504cb58 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. New commits:
21807: gentoobj > gentosage