Opened 6 years ago

Closed 6 years ago

#21807 closed enhancement (fixed)

Move gentoobj and rename it to gen_to_sage

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.5
Component: interfaces Keywords: atelierpari2017
Cc: Luca De Feo, Jean-Pierre Flori, Peter Bruin Merged in:
Authors: Vincent Delecroix Reviewers: Luca De Feo
Report Upstream: N/A Work issues:
Branch: 8828867 (Commits, GitHub, GitLab) Commit: 88288670d22328ea0ff386c826c65d729504cb58
Dependencies: Stopgaps:

Status badges

Description (last modified by Vincent Delecroix)

The function sage.libs.cypari2.gen.gentoobj returning Sage objects is moved to sage.libs.pari.sage_convert.gen_to_sage.

Change History (35)

comment:1 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Create a SagePariInstance classMove gentoobj and rename it to gentosage

comment:2 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 6 years ago by Jeroen Demeyer

Dependencies: #21820

comment:4 Changed 6 years ago by Vincent Delecroix

Authors: Vincent Delecroix
Branch: u/vdelecroix/21807
Dependencies: #21820

comment:5 Changed 6 years ago by git

Commit: 44b7558b77b734b6d962a4a9bf9156e603c8ca2c

Branch pushed to git repo; I updated commit sha1. New commits:

44b755821807: gentoobj -> gentosage

comment:6 Changed 6 years ago by Vincent Delecroix

Description: modified (diff)
Status: newneeds_review

comment:7 Changed 6 years ago by git

Commit: 44b7558b77b734b6d962a4a9bf9156e603c8ca2c8b67f803631ea8398ce58223ac8433873904a6e6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8b67f8021807: gentoobj -> gentosage

comment:8 Changed 6 years ago by Vincent Delecroix

Cc: Jean-Pierre Flori Peter Bruin added
Keywords: atelierpari2017 added

comment:9 Changed 6 years ago by Vincent Delecroix

We hav gen_to_integer versus gentoobj. What convention should we use? I am in favor of Sage's one: gen_to_sage. What do you think?

comment:10 Changed 6 years ago by Luca De Feo

gen_py.py has been deprecated 12 months ago. We might as well drop it.

comment:11 Changed 6 years ago by Luca De Feo

as for gentosage vs gen_to_sage, it's all the same to me.

comment:12 in reply to:  10 Changed 6 years ago by Vincent Delecroix

Status: needs_reviewneeds_work

Replying to defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

I will do it here.

comment:13 Changed 6 years ago by git

Commit: 8b67f803631ea8398ce58223ac8433873904a6e629f83ed52ef6f12489e6343acb1700fa707aa02a

Branch pushed to git repo; I updated commit sha1. New commits:

791c1c221807: t_RAT does not exist (documentation issue)
706b3be21807: remove gen_py.py
29f83ed21807: gentosage -> gen_to_sage

comment:14 Changed 6 years ago by Vincent Delecroix

Status: needs_workneeds_review

comment:15 in reply to:  11 Changed 6 years ago by Vincent Delecroix

Replying to defeo:

as for gentosage vs gen_to_sage, it's all the same to me.

I changed it to gen_to_sage in my last commit.

comment:16 Changed 6 years ago by Vincent Delecroix

Description: modified (diff)

comment:17 Changed 6 years ago by Vincent Delecroix

I forgot the copyright notice...

comment:18 Changed 6 years ago by git

Commit: 29f83ed52ef6f12489e6343acb1700fa707aa02aa3624b10df697c3ec46391b376ca3357b06d016b

Branch pushed to git repo; I updated commit sha1. New commits:

a3624b121807: copyright notice

comment:19 Changed 6 years ago by Vincent Delecroix

... done

comment:20 Changed 6 years ago by Vincent Delecroix

Summary: Move gentoobj and rename it to gentosageMove gentoobj and rename it to gen_to_sage

comment:21 Changed 6 years ago by Luca De Feo

Reviewers: Luca De Feo
Status: needs_reviewpositive_review

Good to go

comment:22 Changed 6 years ago by Vincent Delecroix

Thank you!

comment:23 Changed 6 years ago by git

Commit: a3624b10df697c3ec46391b376ca3357b06d016bd173a7b1c4451652406babaa75403d951bf67f61
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

c0ac11b21807: gentosage -> gen_to_sage
d173a7b21807: copyright notice

comment:24 Changed 6 years ago by Vincent Delecroix

No more compilation troubles... sorry

comment:25 in reply to:  10 ; Changed 6 years ago by Jeroen Demeyer

Replying to defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

This might break the pickle jar. Be sure to run doctests...

comment:26 in reply to:  25 Changed 6 years ago by Vincent Delecroix

Status: needs_reviewneeds_work

Replying to jdemeyer:

Replying to defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

This might break the pickle jar. Be sure to run doctests...

Indeed. I propose to get rid of gen_py.py in another ticket.

comment:27 Changed 6 years ago by git

Commit: d173a7b1c4451652406babaa75403d951bf67f61c0ac7927d3c22cf3befde978b60ddac8f397c5f5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c0ac79221807: gentoobj -> gentosage

comment:28 Changed 6 years ago by Vincent Delecroix

Status: needs_workneeds_review

comment:29 Changed 6 years ago by Jeroen Demeyer

Status: needs_reviewneeds_work

Don't deprecate sage.libs.cypari2.gentoobj, just remove it. We don't want Sage deprecations in cypari2.

comment:30 Changed 6 years ago by git

Commit: c0ac7927d3c22cf3befde978b60ddac8f397c5f5375658cf89c3e065ec538e53f42c60eef544fa34

Branch pushed to git repo; I updated commit sha1. New commits:

375658c21807: remove gentoobj (that was just a deprecated alias)

comment:31 Changed 6 years ago by Vincent Delecroix

Status: needs_workneeds_review

done

comment:32 Changed 6 years ago by Luca De Feo

Branch: u/vdelecroix/21807u/defeo/21807

comment:33 Changed 6 years ago by Jeroen Demeyer

Commit: 375658cf89c3e065ec538e53f42c60eef544fa3488288670d22328ea0ff386c826c65d729504cb58

New commits:

8828867Python 3 compatibility in doctests

comment:34 Changed 6 years ago by Luca De Feo

Status: needs_reviewpositive_review

I'm happy, Patchbot's happy, everyone's happy!

comment:35 Changed 6 years ago by Volker Braun

Branch: u/defeo/2180788288670d22328ea0ff386c826c65d729504cb58
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.