Opened 2 years ago
Closed 2 years ago
#21803 closed enhancement (fixed)
Clean up unnecessary flint include directories
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | cython | Keywords: | |
Cc: | jdemeyer | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Marc Mezzarobba, Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 5306746 (Commits) | Commit: | 530674620953909c2143aa15ff423a9525ba4c9c |
Dependencies: | Stopgaps: |
Description (last modified by )
There is no reason to add $SAGE_LOCAL/include/flint
as include directory.
Change History (7)
comment:1 Changed 2 years ago by
- Component changed from doctest coverage to cython
- Description modified (diff)
- Milestone changed from sage-7.6 to sage-7.5
- Summary changed from env.py, misc/cython.py: Define and use FLINT_INCLUDE_DIR to Clean up unnecessary flint include directories
comment:2 Changed 2 years ago by
- Branch set to u/jdemeyer/clean_up_unnecessary_flint_include_directories
comment:3 Changed 2 years ago by
- Commit set to 530674620953909c2143aa15ff423a9525ba4c9c
- Status changed from new to needs_review
comment:4 Changed 2 years ago by
- Reviewers set to Marc Mezzarobba
- Status changed from needs_review to positive_review
comment:5 Changed 2 years ago by
- Status changed from positive_review to needs_review
Reverting to needs_review
because I may be missing something, cf. my question on #21797.
comment:6 Changed 2 years ago by
- Reviewers changed from Marc Mezzarobba to Marc Mezzarobba, Matthias Koeppe
- Status changed from needs_review to positive_review
Actually I had missed something in #21797. It's all good.
comment:7 Changed 2 years ago by
- Branch changed from u/jdemeyer/clean_up_unnecessary_flint_include_directories to 530674620953909c2143aa15ff423a9525ba4c9c
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Clean up unnecessary flint include directories