Opened 4 years ago
Closed 4 years ago
#21802 closed enhancement (fixed)
py3 cmp in some cython files (morphism.pyx, etc)
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  python3  Keywords:  
Cc:  jdemeyer, jmantysalo, embray, tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  d74a374 (Commits, GitHub, GitLab)  Commit:  d74a374970936ba680ebcee22ba1da3cf1110593 
Dependencies:  #21779  Stopgaps: 
Description
as another tiny step in the huge cmp problem on the way to py3
Change History (16)
comment:1 Changed 4 years ago by
 Branch set to u/chapoton/21802
 Commit set to 056c995ee8efaa90c97a2afb818f09bc7d622b7b
 Dependencies set to #21779
comment:2 Changed 4 years ago by
Why the dependency on #21779?
comment:3 Changed 4 years ago by
because I am using the brand new richcmp_not_equal
comment:4 Changed 4 years ago by
In that case, the branch should actually be based on top of #21779.
comment:5 Changed 4 years ago by
 Commit changed from 056c995ee8efaa90c97a2afb818f09bc7d622b7b to 19ae3c90f950e2682a49d6c7e926499e50fc6173
comment:6 Changed 4 years ago by
 Commit changed from 19ae3c90f950e2682a49d6c7e926499e50fc6173 to 1c0619885bb378166353d3a79cfb8bef621e8e3e
Branch pushed to git repo; I updated commit sha1. New commits:
1c06198  trac 21802 fixing cmp (to richcmp) in elliptic curve isogenies

comment:7 Changed 4 years ago by
there remains some problems with toric morphisms
comment:8 Changed 4 years ago by
As in the other ticket, you should use
left = <FastDoubleFunc?>self right = <FastDoubleFunc?>other
instead of
left, right = self, other
to check that the type is correct.
comment:9 Changed 4 years ago by
 Commit changed from 1c0619885bb378166353d3a79cfb8bef621e8e3e to a0d7e02ba9b36966d28900b9d3dfdb61c2d94120
Branch pushed to git repo; I updated commit sha1. New commits:
a0d7e02  trac 21802 fixing toric morphisms cmp

comment:10 Changed 4 years ago by
 Commit changed from a0d7e02ba9b36966d28900b9d3dfdb61c2d94120 to d74a374970936ba680ebcee22ba1da3cf1110593
Branch pushed to git repo; I updated commit sha1. New commits:
d74a374  trac 21802 reviewer's comment

comment:11 Changed 4 years ago by
done, thanks
comment:12 Changed 4 years ago by
 Status changed from new to needs_review
bot is green, please review
comment:13 Changed 4 years ago by
 Cc jdemeyer jmantysalo embray tscrim added
bot is green, please review
comment:14 Changed 4 years ago by
*please*, could somebody review this simple ticket ?
comment:15 Changed 4 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
In lieu of any additional comments by Jeroen, I give a positive review.
comment:16 Changed 4 years ago by
 Branch changed from u/chapoton/21802 to d74a374970936ba680ebcee22ba1da3cf1110593
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
more work on cmp() in cython files