Opened 4 years ago

Closed 4 years ago

#21800 closed defect (fixed)

Better error handling in sage-cleaner

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.5
Component: scripts Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 7940870 (Commits, GitHub, GitLab) Commit: 79408707c6c9a3fe34149e8fe4ac2ea5cf0783e7
Dependencies: Stopgaps:

Status badges

Description

My sage-cleaner instance is randomly killing jobs. Reason:

Checking PIDs [18654]
Process 18654 is no longer running, so we clean up
Killing 18654's spawned jobs
--> Killing 'gp' with PID 18743 and parent PID 18654
--> Killing 'gp' with PID 18759 and parent PID 18654
--> Killing 'gp' with PID 18841 and parent PID 18654
--> Killing 'gp' with PID 18851 and parent PID 18654
--> Killing 'gp' with PID 18868 and parent PID 18654
--> Killing 'gp' with PID 18878 and parent PID 18654
--> Killing 'gp' with PID 18982 and parent PID 18654
--> Killing 'gp' with PID 19333 and parent PID 18654
Exception while cleaning up PID 18654:
Traceback (most recent call last):
  File "/usr/local/src/sage-config/src/bin/sage-cleaner", line 94, in cleanup
    or kill_spawned_jobs(spawned_processes, parent_pid):
  File "/usr/local/src/sage-config/src/bin/sage-cleaner", line 106, in kill_spawned_jobs
    pid, cmd = job.strip().split(' ', 1)
ValueError: need more than 1 value to unpack

Probably the jobfile got corrupted somehow and we need to handle this gracefully.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/better_error_handling_in_sage_cleaner

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 79408707c6c9a3fe34149e8fe4ac2ea5cf0783e7
  • Status changed from new to needs_review

New commits:

7940870Better error handling in sage-cleaner

comment:3 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/better_error_handling_in_sage_cleaner to 79408707c6c9a3fe34149e8fe4ac2ea5cf0783e7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.