Opened 4 years ago

Closed 3 months ago

#21784 closed enhancement (invalid)

hardwired paths in src/sage - follow-up

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: felixs, fbissey, embray, jdemeyer, gh-timokau, jhpalmieri, chapoton Merged in:
Authors: Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/hardwired_paths_in_src_sage___follow_up (Commits) Commit: 1c9cfe73e40dbb9c2c5f4fbf5d373c7a001603a1
Dependencies: Stopgaps:

Description

This is a follow-up on #15105.

This tickets collects commits from #15105 that are difficult to appreciate outside of their historical context.

Change History (11)

comment:1 Changed 4 years ago by mkoeppe

  • Branch set to u/mkoeppe/hardwired_paths_in_src_sage___follow_up

comment:2 Changed 4 years ago by mkoeppe

  • Cc felixs fbissey embray jdemeyer added
  • Commit set to 1c9cfe73e40dbb9c2c5f4fbf5d373c7a001603a1

New commits:

​a86590adon't rely on $SAGE_LOCAL/bin/python.
​8cbaa8dcython.py: don't rely in $SAGE_LOCAL
​1c9cfe7python-sage: remove sage-location check

comment:3 Changed 4 years ago by jdemeyer

Please remove the commit to ext/pselect.pyx, I deal with that on #21653.

Last edited 4 years ago by jdemeyer (previous) (diff)

comment:4 Changed 4 years ago by jdemeyer

And for sage-location, we have #15146.

comment:5 Changed 3 years ago by jdemeyer

Is there anything left to be fixed here?

comment:6 Changed 3 years ago by embray

All of these changes make sense to me.

comment:7 Changed 2 years ago by gh-timokau

  • Cc gh-timokau added

comment:8 Changed 3 months ago by mkoeppe

  • Cc jhpalmieri added
  • Milestone changed from sage-7.5 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Outdated, should be closed.

comment:9 Changed 3 months ago by mkoeppe

  • Cc chapoton added

comment:10 Changed 3 months ago by gh-mwageringel

  • Reviewers set to Markus Wageringel
  • Status changed from needs_review to positive_review

comment:11 Changed 3 months ago by chapoton

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.