Opened 5 years ago

Closed 5 months ago

#21783 closed enhancement (fixed)

QEPCAD: get rid of qepcad bits in src/bin/sage-location

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.3
Component: packages: optional Keywords:
Cc: fbissey, embray, felixs, jdemeyer, chapoton, jhpalmieri, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 3e40ee8 (Commits, GitHub, GitLab) Commit: 3e40ee84cc8414061a6921b48bbaa9e7b33de29d
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

We move writing of the default.qepcadrc file from sage-location (where it is the last productive bit) to the installation file.

Change History (15)

comment:1 Changed 5 years ago by mkoeppe

  • Branch set to u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files

comment:2 Changed 5 years ago by git

  • Commit set to b090a6d34497e73b697b68fe258f6831c48f3c48

Branch pushed to git repo; I updated commit sha1. New commits:

​b090a6dinitialize SAGE_ETC (from environ) in sage-location before use

comment:3 Changed 5 years ago by fbissey

Remind me, why are you pulling SAGE_ETC from sage.misc.misc rather than sage.env? In fact I would like to know if this file is needed at all.

It just write one useful line for qepcadrc 

SINGULAR $expanded_path_to_SAGE_LOCAL/bin

If this is the path to singular, unless it is hardcoded to a location by default, it is in the path and therefore not very useful.

comment:4 Changed 11 months ago by mkoeppe

  • Branch u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files deleted
  • Commit b090a6d34497e73b697b68fe258f6831c48f3c48 deleted

comment:5 Changed 11 months ago by mkoeppe

  • Cc jhpalmieri added
  • Description modified (diff)
  • Milestone changed from sage-wishlist to sage-9.2
  • Summary changed from QEPCAD: Location of default.qepcadrc and other files to QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location

comment:6 Changed 11 months ago by mkoeppe

  • Description modified (diff)

comment:7 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:8 Changed 8 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location to QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location, add spkg-configure

comment:9 Changed 5 months ago by mkoeppe

  • Branch set to u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files__get_rid_of_qepcad_bits_in_src_bin_sage_location__add_spkg_configure

comment:10 Changed 5 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc dimpase added
  • Commit set to 3e40ee84cc8414061a6921b48bbaa9e7b33de29d
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from QEPCAD: Location of default.qepcadrc and other files, get rid of qepcad bits in src/bin/sage-location, add spkg-configure to QEPCAD: get rid of qepcad bits in src/bin/sage-location

New commits:

​3e40ee8build/pkgs/qepcad/spkg-install.in: Generate default.qepcadrc instead of doing this in src/bin/sage-location

comment:11 Changed 5 months ago by jhpalmieri

Let me see if I understand: this was in sage-location because it needed to hardcode the value of SAGE_LOCAL in default.qepcadrc, so if that location changed, default.qepcadrc needed to be rewritten. Is that right? If so, it makes sense to move it to the spkg-install.in script.

comment:12 Changed 5 months ago by mkoeppe

Yes, that's right.

comment:13 Changed 5 months ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

And to clarify, you're not changing the odd locations mentioned in the description. Is it worth modifying the description? The changes look good to me.

comment:14 Changed 5 months ago by mkoeppe

  • Description modified (diff)

Thanks. I've pushed this to #31275

comment:15 Changed 5 months ago by vbraun

  • Branch changed from u/mkoeppe/qepcad__location_of_default_qepcadrc_and_other_files__get_rid_of_qepcad_bits_in_src_bin_sage_location__add_spkg_configure to 3e40ee84cc8414061a6921b48bbaa9e7b33de29d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.