Opened 3 years ago

Last modified 2 years ago

#21775 new enhancement

make distclean: Don't delete $SAGE_ROOT/local

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.5
Component: build Keywords:
Cc: jdemeyer Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

#21501, #21479 turn SAGE_LOCAL into a configurable install hierarchy. Consequently, $SAGE_ROOT/local should not be deleted by make distclean.

Change History (4)

comment:1 Changed 3 years ago by jdemeyer

I would argue that $SAGE_LOCAL should not be deleted by make distclean but that $SAGE_ROOT/local should be deleted by make distclean.

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from make distclean: Don't delete the install hierarchy (SAGE_LOCAL) to make distclean: Don't delete $SAGE_ROOT/local

comment:3 Changed 3 years ago by mkoeppe

That's certainly a defendable position.

What if the user explicitly used --prefix=$SAGE_ROOT/local or to another subdirectory of $SAGE_ROOT?

comment:4 Changed 2 years ago by embray

I would lean toward make distclean removes any $SAGE_LOCAL that's a subdirectory of $SAGE_ROOT. That's the point of make distclean. There's not much use for a custom --prefix outside installing Sage outside of $SAGE_ROOT.

Note: See TracTickets for help on using tickets.