Opened 6 years ago
Last modified 4 months ago
#21775 new enhancement
make distclean: Don't delete $SAGE_ROOT/local
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.7 |
Component: | build | Keywords: | |
Cc: | jdemeyer, dimpase, vbraun, jhpalmieri | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (11)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
- Description modified (diff)
- Summary changed from make distclean: Don't delete the install hierarchy (SAGE_LOCAL) to make distclean: Don't delete $SAGE_ROOT/local
comment:3 Changed 6 years ago by
That's certainly a defendable position.
What if the user explicitly used --prefix=$SAGE_ROOT/local
or to another subdirectory of $SAGE_ROOT
?
comment:4 Changed 4 years ago by
I would lean toward make distclean
removes any $SAGE_LOCAL
that's a subdirectory of $SAGE_ROOT
. That's the point of make distclean
. There's not much use for a custom --prefix
outside installing Sage outside of $SAGE_ROOT
.
comment:5 Changed 2 years ago by
- Milestone changed from sage-7.5 to sage-9.2
Moving some tickets to 9.2. This is not a promise that I will be working on them.
comment:6 Changed 2 years ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:7 Changed 22 months ago by
- Cc dimpase vbraun jhpalmieri added
I think it's time to clean up the various -clean
targets in the top-level Makefile so that they match autotools behavior
comment:8 Changed 18 months ago by
- Milestone changed from sage-9.3 to sage-9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:9 Changed 13 months ago by
- Milestone changed from sage-9.4 to sage-9.5
comment:10 Changed 7 months ago by
- Milestone changed from sage-9.5 to sage-9.6
comment:11 Changed 4 months ago by
- Milestone changed from sage-9.6 to sage-9.7
I would argue that
$SAGE_LOCAL
should not be deleted bymake distclean
but that$SAGE_ROOT/local
should be deleted bymake distclean
.