Opened 3 years ago

Closed 3 years ago

#21774 closed enhancement (fixed)

Upgrade to planarity 3.0

Reported by: thansen Owned by:
Priority: major Milestone: sage-7.6
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Isuru Fernando Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 3a60460 (Commits) Commit: 3a60460e5aad031e1f6c312ecdf86cd85535afc2
Dependencies: Stopgaps:

Description (last modified by isuruf)

Planarity 3.0.0.5 was released 2016-05-03.

Release announcement: https://github.com/graph-algorithms/edge-addition-planarity-suite/releases

This update would help the efforts to package sagemath in Debian & Conda, because we have planarity 3 in Debian & conda and should use that.

https://www.dropbox.com/s/eirngmwelsturzm/planarity-3.0.0.5.tar.gz

Change History (10)

comment:1 Changed 3 years ago by infinity0

Patch updated, the tests should be fixed now.

comment:2 Changed 3 years ago by thansen

  • Description modified (diff)
  • Milestone changed from sage-7.5 to sage-7.6

comment:3 Changed 3 years ago by isuruf

  • Description modified (diff)

Fixed the broken patch url

comment:4 Changed 3 years ago by isuruf

  • Description modified (diff)

comment:5 Changed 3 years ago by isuruf

  • Branch set to u/isuruf/planarity

comment:6 Changed 3 years ago by infinity0

  • Commit set to 95d4ae4915a2a03b1348d13ad97f0117cd1829b4

isuruf, are your commits ready to go in? If so, I think you need to set the ticket status from new -> needs_review


New commits:

0fa3076planarity patch
95d4ae4Update planarity to 3.0.0.5

comment:7 Changed 3 years ago by git

  • Commit changed from 95d4ae4915a2a03b1348d13ad97f0117cd1829b4 to 3a60460e5aad031e1f6c312ecdf86cd85535afc2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4fb7bf4planarity patch
3a60460Update planarity to 3.0.0.5

comment:8 Changed 3 years ago by isuruf

  • Description modified (diff)
  • Status changed from new to needs_review

comment:9 Changed 3 years ago by vdelecroix

  • Authors set to Isuru Fernando
  • Component changed from graph theory to packages: standard
  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review
  1. If the ticket is about updating a package please choose the appropriate Component, here packages: standard.
  1. You should always fill the Authors field with your full name

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/isuruf/planarity to 3a60460e5aad031e1f6c312ecdf86cd85535afc2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.