Opened 4 years ago
Closed 4 years ago
#21753 closed enhancement (fixed)
Minimize cimports from flint
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  cython  Keywords:  
Cc:  fbissey  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  François Bissey 
Report Upstream:  N/A  Work issues:  
Branch:  2cba7ad (Commits)  Commit:  2cba7ade6be66f270b213f412ba89dc9577f896e 
Dependencies:  Stopgaps: 
Description
In .pxd
files, it is better to cimport
minimally to avoid introducing spurious dependencies. Some extensions are forced to compile against flint
but don't actually use FLINT.
Change History (8)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
No, I'm using a simple grep
. But you can review it using that list :)
comment:3 Changed 4 years ago by
Will do.
comment:4 Changed 4 years ago by
 Branch set to u/jdemeyer/minimize_cimports_from_flint
comment:5 Changed 4 years ago by
 Commit set to 2cba7ade6be66f270b213f412ba89dc9577f896e
 Status changed from new to needs_review
New commits:
2cba7ad  Minimize cimports from flint

comment:6 Changed 4 years ago by
list of libraries using libflint
readelf d `find /usr/lib64/python2.7/sitepackages/sage name \*.so`  grep C 6 libflint  grep sitepackages File: /usr/lib64/python2.7/sitepackages/sage/lfunctions/zero_sums.so File: /usr/lib64/python2.7/sitepackages/sage/sets/disjoint_set.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_matrices.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/automorphism_group_canonical_label.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_sets.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/double_coset.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_binary.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_graphs.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_python.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/canonical_augmentation.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref/refinement_lists.so File: /usr/lib64/python2.7/sitepackages/sage/groups/perm_gps/partn_ref2/refinement_generic.so File: /usr/lib64/python2.7/sitepackages/sage/modular/modsym/apply.so File: /usr/lib64/python2.7/sitepackages/sage/modular/modsym/heilbronn.so File: /usr/lib64/python2.7/sitepackages/sage/modular/modform/eis_series_cython.so File: /usr/lib64/python2.7/sitepackages/sage/rings/complex_interval.so File: /usr/lib64/python2.7/sitepackages/sage/rings/fraction_field_FpT.so File: /usr/lib64/python2.7/sitepackages/sage/rings/padics/qadic_flint_CR.so File: /usr/lib64/python2.7/sitepackages/sage/rings/padics/qadic_flint_CA.so File: /usr/lib64/python2.7/sitepackages/sage/rings/padics/qadic_flint_FM.so File: /usr/lib64/python2.7/sitepackages/sage/rings/padics/pow_computer_flint.so File: /usr/lib64/python2.7/sitepackages/sage/rings/integer.so File: /usr/lib64/python2.7/sitepackages/sage/rings/real_arb.so File: /usr/lib64/python2.7/sitepackages/sage/rings/polynomial/polynomial_zmod_flint.so File: /usr/lib64/python2.7/sitepackages/sage/rings/polynomial/polynomial_rational_flint.so File: /usr/lib64/python2.7/sitepackages/sage/rings/polynomial/evaluation.so File: /usr/lib64/python2.7/sitepackages/sage/rings/polynomial/polynomial_integer_dense_flint.so File: /usr/lib64/python2.7/sitepackages/sage/rings/complex_arb.so File: /usr/lib64/python2.7/sitepackages/sage/libs/flint/fmpz_poly.so File: /usr/lib64/python2.7/sitepackages/sage/libs/flint/arith.so File: /usr/lib64/python2.7/sitepackages/sage/libs/flint/flint.so File: /usr/lib64/python2.7/sitepackages/sage/libs/arb/arith.so File: /usr/lib64/python2.7/sitepackages/sage/coding/codecan/codecan.so File: /usr/lib64/python2.7/sitepackages/sage/algebras/quatalg/quaternion_algebra_element.so File: /usr/lib64/python2.7/sitepackages/sage/graphs/matchpoly.so File: /usr/lib64/python2.7/sitepackages/sage/matrix/matrix_integer_dense.so File: /usr/lib64/python2.7/sitepackages/sage/matrix/matrix_rational_dense.so File: /usr/lib64/python2.7/sitepackages/sage/schemes/elliptic_curves/descent_two_isogeny.so
so it is right that nothing sage/modular/pollack_stevens/
is there. The rest seems to be moving declaration around and make them more defined. I will do a build of that.
comment:7 Changed 4 years ago by
 Reviewers set to François Bissey
 Status changed from needs_review to positive_review
comment:8 Changed 4 years ago by
 Branch changed from u/jdemeyer/minimize_cimports_from_flint to 2cba7ade6be66f270b213f412ba89dc9577f896e
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Want a list for that?