Opened 4 years ago

Closed 4 years ago

#21752 closed enhancement (invalid)

From "colour" to "color"; i.e. to US english

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: documentation Keywords:
Cc: ​jdemeyer, tscrim, chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Peter Bruin, Frédéric Chapoton, Peleg Michaeli
Report Upstream: N/A Work issues:
Branch: u/jmantysalo/color-colour (Commits, GitHub, GitLab) Commit: c346d2cf82c6436d09efc87c2592f58ddb74ec07
Dependencies: Stopgaps:

Status badges

Description

This patch will change some colours to colors.

The real question is larger: shall we add "Use US english" to the developer manual? I think that we should. (I have no prefence, but US english is currently more used.)

Change History (10)

comment:1 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/color-colour

comment:2 Changed 4 years ago by jmantysalo

  • Commit set to c346d2cf82c6436d09efc87c2592f58ddb74ec07
  • Status changed from new to needs_info

New commits:

c346d2cChange colours to colors.

comment:3 Changed 4 years ago by jmantysalo

  • Status changed from needs_info to needs_review

Got no interest about US/GB -issue.

So I just mark this colour->color as needs_review. Please review, either to milestone sage-7.5 or to milestone wontfix.

comment:4 follow-up: Changed 4 years ago by pbruin

I disagree with enforcing a particular spelling. Both are perfectly acceptable, and permitting both has absolutely no effect on readability. I just expect people who use one variant to get annoyed by others "correcting" their spelling to the others' preferred variant.

comment:5 in reply to: ↑ 4 Changed 4 years ago by chapoton

Replying to pbruin:

I disagree with enforcing a particular spelling. Both are perfectly acceptable, and permitting both has absolutely no effect on readability. I just expect people who use one variant to get annoyed by others "correcting" their spelling to the others' preferred variant.

Same opinion. I vote for duplicate/invalid.

comment:6 Changed 4 years ago by jmantysalo

OK, but what you think about

class Color(object):
     def __int__(self):
         """
         Return the integer representation of this colour.

or like? Fortunately we have only one form used as keyword or function name. I suppose that you wouldn't like them to have different spelling.

(You can be sure that I have no personal preference of which one to use. My native language is quite far from english.)

comment:7 Changed 4 years ago by pelegm

I vote for invalid.

I think that code (methods, functions, classes) should all follow US English (this is just far too common in CASs so far; and it should be consistent), so for example g.find_colors together with g.colourful should definitely be unacceptable, but docstrings with GB spelling, even if the function name is in US spelling, is fine with me.

(It is perhaps not super-aesthetic; but I guess we can live with it)

comment:8 Changed 4 years ago by jmantysalo

  • Milestone changed from sage-7.5 to sage-duplicate/invalid/wontfix

OK.

comment:9 Changed 4 years ago by pbruin

  • Reviewers set to Peter Bruin, Frédéric Chapoton, Peleg Michaeli
  • Status changed from needs_review to positive_review

comment:10 Changed 4 years ago by vbraun

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.