Opened 4 years ago

Closed 4 years ago

#21751 closed enhancement (fixed)

py3 get rid of xrange in polynomials

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.5
Component: python3 Keywords:
Cc: jdemeyer, tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 45687fc (Commits, GitHub, GitLab) Commit: 45687fc551dd031750ee5bd5ebda8e994bdfb46b
Dependencies: Stopgaps:

Status badges

Description

using from six.moves import range

only in .py files

as a step towards py3

Change History (10)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/21751
  • Cc jdemeyer tscrim jmantysalo added
  • Commit set to 54c8d8cd1de5beeb79251e9794abc609819b3635
  • Status changed from new to needs_review

New commits:

54c8d8cget rid of xrange in rings folder (py files only)

comment:2 follow-up: Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM.

comment:3 in reply to: ↑ 2 Changed 4 years ago by jmantysalo

Replying to tscrim:

LGTM.

To confirm, was this supposed to be a positive review? You did not set the status of this ticket.

comment:4 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by chapoton

  • Status changed from positive_review to needs_work

some doctests do not pass..

comment:6 Changed 4 years ago by git

  • Commit changed from 54c8d8cd1de5beeb79251e9794abc609819b3635 to ead8affa871a07857161bcac4036779420c00bc0

Branch pushed to git repo; I updated commit sha1. New commits:

ead8afftrac 21571 wrapping 2 range with list

comment:7 Changed 4 years ago by git

  • Commit changed from ead8affa871a07857161bcac4036779420c00bc0 to 45687fc551dd031750ee5bd5ebda8e994bdfb46b

Branch pushed to git repo; I updated commit sha1. New commits:

45687fctrac 21751 fixing one last failing doctest

comment:8 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

ok, doctests now pass, back to needs review

comment:9 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/21751 to 45687fc551dd031750ee5bd5ebda8e994bdfb46b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.