Opened 6 years ago

Closed 5 years ago

#21744 closed enhancement (fixed)

make xz a standard package

Reported by: charpent Owned by:
Priority: major Milestone: sage-7.6
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Emmanuel Charpentier Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: b4da321 (Commits, GitHub, GitLab) Commit: b4da3219e9369394213b9a382073e412c83f530a
Dependencies: Stopgaps:

Status badges

Description

Rationale :

  • R is a standard package.
  • It now depends on liblzma (see #20523).
  • liblzma is available through xz.
  • Therefore R depends on xz.
  • A standard package cannot depend on an optional package

Therefore xz has to become standard. QED.

Trivial patch to follow shortly (Real_World(TM) adjuvante)...

Change History (8)

comment:1 follow-up: Changed 6 years ago by mkoeppe

  • Component changed from PLEASE CHANGE to packages: optional
  • Summary changed from make zx a standard package to make xz a standard package

comment:2 Changed 6 years ago by charpent

  • Branch set to u/charpent/make_zx_a_standard_package

comment:3 Changed 6 years ago by charpent

  • Authors set to Emmanuel Charpentier
  • Commit set to b4da3219e9369394213b9a382073e412c83f530a
  • Status changed from new to needs_review

Passes ptestlong with two transient errors, as usual :

----------------------------------------------------------------------
sage -t --long --warn-long 99.8 src/sage/homology/simplicial_complex.py  # 1 doctest failed
sage -t --long --warn-long 99.8 src/sage/categories/sets_cat.py  # Bad exit: 2
----------------------------------------------------------------------

which both pâss standalone with no error.

==> needs_review


New commits:

b4da321One-word patch.

comment:4 in reply to: ↑ 1 Changed 6 years ago by charpent

Replying to mkoeppe:

Thanks ! I'm a bit of a distracted man...

comment:5 follow-up: Changed 6 years ago by tscrim

A notice about this should be posted to sage-devel, but I am in favor of this change.

comment:6 in reply to: ↑ 5 Changed 6 years ago by charpent

Replying to tscrim:

A notice about this should be posted to sage-devel, but I am in favor of this change.

Done here. Thanks for the reminder...

Last edited 6 years ago by charpent (previous) (diff)

comment:7 Changed 5 years ago by mkoeppe

  • Milestone changed from sage-7.5 to sage-7.6
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

The outcome of the poll on sage-devel seems to have been positive, so I'm setting this to positive review. (I'd like to use xz for a CGAL package, #18197.)

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/charpent/make_zx_a_standard_package to b4da3219e9369394213b9a382073e412c83f530a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.