Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#2173 closed enhancement (fixed)

[with patch; positive review] SAGE setup.py should run cython as "python2.5 cython" and other debian fixes

Reported by: tabbott Owned by: tabbott
Priority: major Milestone: sage-2.11
Component: debian-package Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

the cython in debian runs as #!/usr/bin/python, and /usr/bin/python is python2.4 by default in Debian. Thus, the SAGE setup.py should explicitly run "python2.5 cython" to get python2.5.

I'm submitting in non-mercurial format since I get the following error when I try to:

[tabbott@mega-man sage$] hg diff abort: index 00changelog.i invalid format 2! [tabbott@mega-man sage$] cat .hg/00changelog.i ; echo dummy changelog to prevent using the old repo layout

Attachments (2)

setup.py.diff (534 bytes) - added by tabbott 15 years ago.
sage-spkg-debian.patch (2.4 KB) - added by tabbott 14 years ago.

Download all attachments as: .zip

Change History (9)

Changed 15 years ago by tabbott

comment:1 Changed 15 years ago by mabshoff

  • Summary changed from [with patch; needs review] SAGE setup.py should run cython as "python2.5 cython" to [with patch; with negative review] SAGE setup.py should run cython as "python2.5 cython"

The patch doesn't work as is for the non-Debianized build:

Building sage/matrix/matrix_dense.c because it depends on sage/matrix/matrix_dense.pyx.
python2.5 cython --embed-positions --incref-local-binop -I/scratch/mabshoff/release-cycle/sage-2.10.2.alpha1/devel/sage-main -o sage/matrix/matrix_dense.c sage/matrix/matrix_dense.pyx
python2.5: can't open file 'cython': [Errno 2] No such file or directory
sage: Error running cython.
sage: There was an error installing modified sage library code.

Cheers,

Michael

comment:2 Changed 15 years ago by mabshoff

I guess it is a patch issue: python2.5 `which cython` works. We could just do something analog like the other places in setup.py and introduce a special case for the Debianized build.

Cheers,

Michael

comment:3 Changed 15 years ago by tabbott

Yeah, python2.5 which cython is what I'd intended; for non-debian builds, SAGE_LOCAL/bin should be in PATH, and for Debian builds, /usr/bin/cython will be in PATH, so I think that's best.

comment:4 Changed 14 years ago by tabbott

  • Summary changed from [with patch; with negative review] SAGE setup.py should run cython as "python2.5 cython" to [with patch; needs review] SAGE setup.py should run cython as "python2.5 cython" and other debian fixes

I'm attaching a new patch that includes the python2.5 which cython change and also the other things that were needed to get SAGE 2.10.4 to build on Debian.

I think the changeset can be cleaned up to just create a symlink 'python' in SAGE_LOCAL/bin that goes to the working python2.5 and then one would not have to do as many changes that replace 'python' with 'python2.5' in the build process.

Changed 14 years ago by tabbott

comment:5 Changed 14 years ago by mabshoff

  • Summary changed from [with patch; needs review] SAGE setup.py should run cython as "python2.5 cython" and other debian fixes to [with patch; positive review] SAGE setup.py should run cython as "python2.5 cython" and other debian fixes

sage-spkg-debian.patch looks good to me. Positive review.

Cheers,

Michael

comment:6 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.11.rc0

comment:7 Changed 14 years ago by mabshoff

  • Milestone changed from sage-3.0 to sage-2.11
Note: See TracTickets for help on using tickets.