Opened 3 years ago

Closed 3 years ago

#21722 closed defect (fixed)

Fix build of gap3

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.5
Component: packages: experimental Keywords:
Cc: dimpase, stumpc5, tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6b07191 (Commits) Commit: 6b071914705c4d245c981969338a0c6e8f92a574
Dependencies: Stopgaps:

Description

Currently, gap3 does not build. This branch fixes it.

It also uses the standard patching procedure and it no longer copies the content of build/pkgs/gap3 to the install directory.

Change History (6)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_build_of_gap3

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to 6b071914705c4d245c981969338a0c6e8f92a574
  • Status changed from new to needs_review

New commits:

​6b07191Fix build of gap3; standardize patches

comment:3 Changed 3 years ago by tscrim

  • Cc tscrim added

comment:4 Changed 3 years ago by stumpc5

Thanks for fixing this! Could you tell why it stopped working? Is it a change how to patch packages?

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think it has to do with some of the recent changes to the build system that Jeroen, Erik, and Matthias have been doing. Anyways, positive review.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_build_of_gap3 to 6b071914705c4d245c981969338a0c6e8f92a574
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.