Opened 4 years ago
Closed 4 years ago
#21721 closed defect (fixed)
Standardize patches in fricas, frobby
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | packages: experimental | Keywords: | |
Cc: | embray, dimpase | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 683e7b9 (Commits, GitHub, GitLab) | Commit: | 683e7b9f0ac762d3da2c6ad4de2f99839bc4347c |
Dependencies: | Stopgaps: |
Description (last modified by )
The packages fricas
and frobby
use non-standard patching.
Change History (14)
comment:1 Changed 4 years ago by
- Branch set to u/jdemeyer/standardize_patches_in_fricas__frobby__gap3
comment:2 Changed 4 years ago by
- Commit set to 683e7b9f0ac762d3da2c6ad4de2f99839bc4347c
- Description modified (diff)
- Summary changed from Standardize patches in fricas, frobby, gap3 to Standardize patches in fricas, frobby
comment:3 Changed 4 years ago by
I think that fricas shouldn't need the patch anymore, at least with #21377 (but I admit, I cannot package)
comment:4 Changed 4 years ago by
- Status changed from new to needs_review
comment:5 follow-up: ↓ 6 Changed 4 years ago by
- Cc dimpase added
Cc'ing dimpase, who probably has a script that created the frobby patches.
comment:6 in reply to: ↑ 5 Changed 4 years ago by
Replying to mkoeppe:
Cc'ing dimpase, who probably has a script that created the frobby patches.
no, I think I simply used git to create/update patches.
Otherwise, this simply moves things around, right?
comment:7 Changed 4 years ago by
This ticket *edits* the patch to make it -p1 instead of -p0 Wouldn't it be better if there was a public git of the modified frobby, and a script that regenerated the patches?
comment:8 Changed 4 years ago by
I don't think that we ever use scripts in Sage to generate patches...
comment:9 Changed 4 years ago by
I know that we don't (with some exceptions), but my point is that it would be better if we did.
Our patch management seems ad-hoc (in contrast for example to Debian's tools and documented workflow for this)
and few people seem to be aware of git format-patch
, which can be used to create a set of patches.
comment:10 Changed 4 years ago by
I used git format-patch
yesterday for the 1st time :-)
comment:11 Changed 4 years ago by
Nice. Let's add a short section on how to manage patchsets with git format-patch to the developers' guide...
comment:12 Changed 4 years ago by
This is #21781.
comment:13 Changed 4 years ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:14 Changed 4 years ago by
- Branch changed from u/jdemeyer/standardize_patches_in_fricas__frobby__gap3 to 683e7b9f0ac762d3da2c6ad4de2f99839bc4347c
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Standardize patches in fricas and frobby