[with patch; positive review] followup to #2169 -- (magma/sage interface) some further optimizations and fixes

[William Stein]

Apply the patches from #2169, then apply both these patches. To test do

sage -t --optional SAGE_ROOT/devel/sage/sage/interfaces/magma.py

Conversion of Magma matrices over ZZ back to Sage should also be much faster now.

[William Stein]

Apply all the attached files -- the sage- ones to hg_sage and the extcode ones to hg_extcode.

[Mike Hansen]

I get a reject with ​http://sagetrac.org/sage_trac/attachment/ticket/2171/sage-trac2171.patch on rc1. It looks like it is depending on a patch that isn't there. This is the failure:

--- expect.py
+++ expect.py
@@ -860,10 +860,15 @@ If this all works, you can then make cal
         return self.eval(var)
 
     def get_using_file(self, var):
-        """
+        r"""
         Return the string representation of the variable var in self
         using a file.  Use this if var has a huge string
         representation.  It'll be way faster.
+
+        WARNING: In fact unless a special derived class implements
+        this, it will \emph{not} be any faster.  This is the case for
+        this class if you're reading it through introspection and
+        seeing this.
         """
         return self.get(var)

and this is expect.py in rc1:

    def get_using_file(self, var):
        return self.get(var)

[Craig Citro]

The patch that this code depends on is attached to trac #2120. I guess this will have to wait until that patch is ready to go? Or should we pull over that part of the patch to this ticket so we can get it merged? William, what's the status of the Maple ticket?

[Michael Abshoff]

Craig,

can you review this? It has been potentially bitrotting for a long, long time :)

Cheers,

Michael

[William Stein]

I rebased these patches against 3.2.alpha0 and got rid of the dependence on #2120. This should be easy to apply and go into sage-3.2.

[Michael Abshoff]

In sage-trac2171-part1.patch there is still a change to sage/interfaces/maple.py. I will delete that hunk and test the patch. Other than that I expect a positive review assuming the doctests pass.

Cheers,

Michael

[Minh Van Nguyen]

For the patch extcode-trac2171-part2.patch, here's a possible documentation fix:

-{Conver the ring of integers to Sage.}
+{Convert the ring of integers to Sage.}

[Michael Abshoff]

Positive review.

Cheers,

Michael

[Michael Abshoff]

Merged sage-trac2171-part1.patch and sage-trac2171-part2.patch in Sage 3.2.alpha1

[Michael Abshoff]

Oops, I didn't merge extcode-trac2171.patch and extcode-trac2171-part2.patch. Those two patches have been merged in Sage 3.2.alpha2.

Cheers,

Michael