Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#21675 closed defect (fixed)

Revert the renaming libfplll -> fplll

Reported by: Jeroen Demeyer Owned by:
Priority: blocker Milestone: sage-7.4
Component: packages: standard Keywords:
Cc: Thierry Monteil, Jean-Pierre Flori, Clément Pernet, Martin Albrecht Merged in:
Authors: Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: 618a581 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

In #21221, the package libfplll was renamed to fplll.

When building fplll, the old libfplll from sage-7.4.beta6 and earlier is still marked as installed.

This causes downgrades sage-7.4.rc0 -> sage-7.4.beta6 to fail since the build system does not know that libfplll was replaced by fplll. Therefore, after such a downgrade, the libfplll package is not reinstalled.

Solution:

  1. Revert the renaming and remove installed/fplll* when installing libfplll (this ticket).
  1. After the MPFR upgrade (#21660), rename libfplll -> fplll and remove installed/libfplll* when installing fplll.

Since (lib)fplll depends on MPFR, the changing of MPFR version will force a reinstallation of (lib)fplll. If both the spkg-install of libfplll and of fplll delete the other "installed" file, both downgrades and upgrades will work as expected.

Change History (21)

comment:1 Changed 6 years ago by Jeroen Demeyer

Cc: Thierry Monteil Jean-Pierre Flori Clément Pernet Martin Albrecht added

comment:2 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 6 years ago by Jean-Pierre Flori

Can't we just remove the installed/libfplll file from fplll's spkg-install?

comment:5 Changed 6 years ago by Jean-Pierre Flori

Authors: Jean-Pierre Flori
Branch: u/jpflori/21675
Commit: 88a7a70fadc943a5fd3574663396852235426233

Here is something. I have to go now so I did not have time to test it correctly, fplll is still compiling.


New commits:

88a7a70Make sure dowgrading from fplll to libfplll works.

comment:6 in reply to:  4 Changed 6 years ago by Jeroen Demeyer

Replying to jpflori:

Can't we just remove the installed/libfplll file from fplll's spkg-install?

That only solves the problem in one direction and will break a downgrade followed by an upgrade (fplll -> libfplll -> fplll).

comment:7 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Deal better with renaming libfplll -> fplllRevert the renaming libfplll -> fplll

comment:8 Changed 6 years ago by Jean-Pierre Flori

Description: modified (diff)
Summary: Revert the renaming libfplll -> fplllDeal better with renaming libfplll -> fplll

You mean that fplll (and cython files depending on the lib) won't get rebuilt the second time?

comment:9 Changed 6 years ago by Jeroen Demeyer

Branch: u/jpflori/21675u/jdemeyer/21675

comment:10 Changed 6 years ago by Jean-Pierre Flori

Commit: 88a7a70fadc943a5fd3574663396852235426233618a581220339d4af6985080be5d7a2172de49a8

Oops, I was doing two things at the same time and did not pay attention to the warning...


New commits:

3951f91Rename fplll -> libfplll
618a581sagelib no longer depends on fplll

comment:11 in reply to:  8 Changed 6 years ago by Jeroen Demeyer

Summary: Deal better with renaming libfplll -> fplllRevert the renaming libfplll -> fplll

Replying to jpflori:

You mean that fplll won't get rebuilt the second time?

Exactly, because the build system will think that fplll is still installed.

The only way to get this working is to delete the files from SAGE_SPKG_INST in both directions (the old package should delete the new installed files and the new package should delete the old installed files).

Luckily, we can use the MPFR upgrade as an extra way to force a rebuild of libfplll when downgrading to sage-7.4.beta6 or earlier.

comment:12 Changed 6 years ago by Jeroen Demeyer

Authors: Jean-Pierre FloriJeroen Demeyer
Status: newneeds_review

comment:13 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:14 Changed 6 years ago by Jean-Pierre Flori

Reviewers: Jean-Pierre Flori
Status: needs_reviewpositive_review

Ok, let's hack this in.

comment:15 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/21675618a581220339d4af6985080be5d7a2172de49a8
Resolution: fixed
Status: positive_reviewclosed

comment:16 Changed 6 years ago by Jeroen Demeyer

Commit: 618a581220339d4af6985080be5d7a2172de49a8

Just mentioning that I have been hit by this issue several times since the release of Sage 7.4.rc0 while working on different tickets.

comment:17 Changed 6 years ago by Jeroen Demeyer

Volker: this was closed before the release of Sage 7.4.rc1 but still isn't contained in Sage 7.4.rc1. And I don't see it appearing in https://github.com/vbraun/sage/commits/develop

Was this intentional or did something go wrong?

comment:18 Changed 6 years ago by Volker Braun

it'll be in rc2

comment:19 Changed 6 years ago by Jean-Pierre Flori

Should we rerevert this now?

comment:20 in reply to:  19 Changed 6 years ago by Jeroen Demeyer

Replying to jpflori:

Should we rerevert this now?

We could.

comment:21 Changed 6 years ago by Jean-Pierre Flori

I guess 5.1.0 is coming, that would be a good opportunity.

Note: See TracTickets for help on using tickets.