Opened 6 years ago

Closed 6 years ago

#21653 closed enhancement (fixed)

Upgrade cysignals

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.5
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: a53866c (Commits, GitHub, GitLab) Commit: a53866c4ced409db80ce4a209d929286824d68e6
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This upgrades cysignals to version 1.3.2.

In addition, this ticket

  • moves src/sage/ext/pselect.pyx to cysignals because it fits well within the scope of cysignals.
  • adds support for SAGE_DEBUG=yes.
  • uses pip instead of distutils to install cysignals.

Upstream: ​https://github.com/sagemath/cysignals/releases/download/1.3.2/cysignals-1.3.2.tar.bz2

Change History (18)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_cysignals

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 39d0f013b327579c4e83a5e4b422ca00a61a95d3
  • Status changed from new to needs_review

New commits:

​ccd9442Add a sage-pip-install wrapper for pip which handles uninstallation better.
​29957faVarious fixes and simplifications to sage-pip-install
​783cd7dRe-install all pip-installed packages
​8fd8273Fix various dependencies
​77a70ceUpgrade to cysignals-1.2.0
​39d0f01Use pip to install cysignals; support SAGE_DEBUG

comment:3 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Milestone changed from sage-7.4 to sage-7.5
  • Status changed from needs_review to needs_work

comment:4 Changed 6 years ago by jdemeyer

  • Dependencies #21441 deleted

comment:5 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 6 years ago by git

  • Commit changed from 39d0f013b327579c4e83a5e4b422ca00a61a95d3 to 60fd53c166ae18914ffba031050cffccba4251bd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​d8b6f54Upgrade to cysignals-1.3.1
​ba5cd2fUse pip to install cysignals; support SAGE_DEBUG
​60fd53cMove ext/pselect.pyx to cysignals

comment:8 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:9 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work

comment:10 Changed 6 years ago by git

  • Commit changed from 60fd53c166ae18914ffba031050cffccba4251bd to a85ae7128b9c2a4a0c548bc502b69f2abc9f135b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​87688aeUpgrade to cysignals-1.3.1
​648a2ffUse pip to install cysignals; support SAGE_DEBUG
​a85ae71Move ext/pselect.pyx to cysignals

comment:11 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:12 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 6 years ago by git

  • Commit changed from a85ae7128b9c2a4a0c548bc502b69f2abc9f135b to a53866c4ced409db80ce4a209d929286824d68e6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​41420f6Upgrade to cysignals-1.3.2
​3c952a9Use pip to install cysignals; support SAGE_DEBUG
​a53866cMove ext/pselect.pyx to cysignals

comment:14 Changed 6 years ago by dimpase 

$ wget ​https://github.com/sagemath/cysignals/releases/download/1.3.2/cysignals-1.3.2.tar.bz2
https://github.com/sagemath/cysignals/releases/download/1.3.2/cysignals-1.3.2.tar.bz2: Scheme missing.

comment:15 follow-up: Changed 6 years ago by jdemeyer

You copied badly. Try this: 

wget https://trac.sagemath.org/ticket/21653#comment:14
Version 0, edited 6 years ago by jdemeyer (next)

comment:16 in reply to: ↑ 15 Changed 6 years ago by dimpase

Replying to jdemeyer:

You copied badly. Try this: 

wget https://github.com/sagemath/cysignals/releases/download/1.3.2/cysignals-1.3.2.tar.bz2

ah, OK...

comment:17 Changed 6 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Looks good, installs fine.

comment:18 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_cysignals to a53866c4ced409db80ce4a209d929286824d68e6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.