Changes between Initial Version and Version 1 of Ticket #21645, comment 6
- Timestamp:
- Nov 10, 2016, 5:48:12 PM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #21645, comment 6
initial v1 1 Looking at the patch, I see presently special work happens on maxima's return values, which replaces maxima's "inert" sum with sage's newly grown symbolic sum function. I think that's problematic (for instance, we could have nested sums, and the nested sums would escape this treatment). 1 Looking at the patch, I see presently special work happens on maxima's return values, which replaces maxima's "inert" sum with sage's newly grown symbolic sum function. I think that's problematic (for instance, we could have nested sums, and the nested sums would escape this treatment). Also, the test used (`isinstance(op,SymbolicFunction)`) is a little suspicious: I think it would get the result from 2 {{{ 3 sum(f(x),n,0,0) 4 }}} 5 wrong. 2 6 3 7 It should be possible to use the standard SR-to-maxima and maxima-to-SR translation dictionaries for this, just as functions like sin etc. get properly translated. Isn't the line