Opened 5 years ago

Closed 5 years ago

#21640 closed enhancement (fixed)

py3 get rid of last iterkeys

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw, Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 4748b70 (Commits, GitHub, GitLab) Commit: 4748b7048f1bd8edd98f78d18b24f64abd8d692e
Dependencies: Stopgaps:

Status badges

Description

as iterkeys is not longer existing in py3

Change History (5)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/21640
  • Commit set to 4748b7048f1bd8edd98f78d18b24f64abd8d692e
  • Status changed from new to needs_review

New commits:

4748b70get rid of last iterkeys

comment:2 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 5 years ago by tmonteil

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Thierry Monteil

Race condition, LGTM too :)

comment:4 Changed 5 years ago by tmonteil

By the way, it is great that such things will be tested by the patchbot or they will likely re-appear, see e.g. #21542.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/21640 to 4748b7048f1bd8edd98f78d18b24f64abd8d692e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.