Opened 3 years ago

Closed 3 years ago

#21626 closed enhancement (fixed)

LatticePoset: Add random distributive lattice

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1ac528b (Commits) Commit: 1ac528bf6341030c9851db5f425d23ebe6ffcb4e
Dependencies: Stopgaps:

Description

This patch will add distributive-keyword to random lattice generation.

Change History (10)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/random-distributive-lattice

comment:2 Changed 3 years ago by jmantysalo

  • Commit set to 0b968a28b1d558f9991112fe44e5aec3cc4e69ac
  • Status changed from new to needs_review

New commits:

0b968a2Add random distributive lattice.

comment:3 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to needs_work

Arghs, see #21584.

comment:4 Changed 3 years ago by git

  • Commit changed from 0b968a28b1d558f9991112fe44e5aec3cc4e69ac to d6d09011550be7bf7321e7fd80c2e9b7a444257d

Branch pushed to git repo; I updated commit sha1. New commits:

d6d0901Numbering correction.

comment:5 Changed 3 years ago by jmantysalo

  • Status changed from needs_work to needs_review

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Change "combing" to "combining" ("combing" comes from "to comb"), otherwise LGTM.

comment:7 Changed 3 years ago by git

  • Commit changed from d6d09011550be7bf7321e7fd80c2e9b7a444257d to 1ac528bf6341030c9851db5f425d23ebe6ffcb4e

Branch pushed to git repo; I updated commit sha1. New commits:

1ac528bTypo.

comment:8 Changed 3 years ago by jmantysalo

Thanks Travis. Typo corrected.

comment:9 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/random-distributive-lattice to 1ac528bf6341030c9851db5f425d23ebe6ffcb4e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.