Opened 6 years ago
Closed 6 years ago
#21621 closed enhancement (fixed)
desolvers: Replace SAGE_ROOT/local by SAGE_LOCAL
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.5 |
Component: | build | Keywords: | |
Cc: | mmarco, vbraun, vdelecroix, jdemeyer, embray | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 63f98fd (Commits, GitHub, GitLab) | Commit: | 63f98fdb8b43432d34e0242a95a1ea1a82231c6a |
Dependencies: | Stopgaps: |
Description
./src/sage/calculus/desolvers.py:1623: os.path.join('$SAGE_ROOT','local','lib','libTIDES.a') + ' $LDFLAGS ' ./src/sage/calculus/desolvers.py:1624: + os.path.join('-L$SAGE_ROOT','local','lib ') +' -lm -O2 ' + ./src/sage/calculus/desolvers.py:1625: os.path.join('-I$SAGE_ROOT','local','include '), ./src/sage/calculus/desolvers.py:1729: os.path.join('$SAGE_ROOT','local','lib','libTIDES.a') + ' $LDFLAGS ' ./src/sage/calculus/desolvers.py:1730: + os.path.join('-L$SAGE_ROOT','local','lib ') + '-lmpfr -lgmp -lm -O2 -w ' + ./src/sage/calculus/desolvers.py:1731: os.path.join('-I$SAGE_ROOT','local','include ') ,
(This is a step toward #21534.
Change History (7)
comment:1 Changed 6 years ago by
- Summary changed from desolve: Replace SAGE_ROOT/local by SAGE_LOCAL to desolvers: Replace SAGE_ROOT/local by SAGE_LOCAL
comment:2 Changed 6 years ago by
- Cc vbraun vdelecroix added
comment:3 Changed 6 years ago by
- Branch set to u/mkoeppe/desolvers__replace_sage_root_local_by_sage_local
comment:4 Changed 6 years ago by
- Cc jdemeyer embray added
- Commit set to 63f98fdb8b43432d34e0242a95a1ea1a82231c6a
- Status changed from new to needs_review
comment:5 Changed 6 years ago by
- Milestone changed from sage-7.4 to sage-7.5
comment:6 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:7 Changed 6 years ago by
- Branch changed from u/mkoeppe/desolvers__replace_sage_root_local_by_sage_local to 63f98fdb8b43432d34e0242a95a1ea1a82231c6a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
desolve_*tides*: Use SAGE_LOCAL instead of SAGE_ROOT/local